You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2019/12/02 15:20:08 UTC

[GitHub] [pulsar] zymap commented on a change in pull request #5714: Add more info in the error messages

zymap commented on a change in pull request #5714: Add more info in the error messages
URL: https://github.com/apache/pulsar/pull/5714#discussion_r352654157
 
 

 ##########
 File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerImpl.java
 ##########
 @@ -1466,7 +1480,10 @@ public void seek(long timestamp) throws PulsarClientException {
             seekFuture.complete(null);
         }).exceptionally(e -> {
             log.error("[{}][{}] Failed to reset subscription: {}", topic, subscription, e.getCause().getMessage());
-            seekFuture.completeExceptionally(e.getCause());
+            seekFuture.completeExceptionally(
+                new PulsarClientException.WrapperException(
 
 Review comment:
   because there are some methods when it uses the exception it will use the `unwrap` method to get the real exception.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services