You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Todd Lipcon (JIRA)" <ji...@apache.org> on 2011/02/15 22:10:57 UTC
[jira] Created: (HADOOP-7146) RPC server leaks file descriptors
RPC server leaks file descriptors
---------------------------------
Key: HADOOP-7146
URL: https://issues.apache.org/jira/browse/HADOOP-7146
Project: Hadoop Common
Issue Type: Bug
Affects Versions: 0.22.0
Reporter: Todd Lipcon
Assignee: Todd Lipcon
Both the Listener and Responder thread call Selector.open but don't have a matching .close(). This causes a leak of anonymous pipes. Not a big deal because people rarely close and re-open servers, but worth fixing.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7146) RPC server leaks file descriptors
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13039680#comment-13039680 ]
Hudson commented on HADOOP-7146:
--------------------------------
Integrated in Hadoop-Common-trunk #700 (See [https://builds.apache.org/hudson/job/Hadoop-Common-trunk/700/])
HADOOP-7146. RPC server leaks file descriptors. Contributed by Todd Lipcon.
todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1127811
Files :
* /hadoop/common/trunk/CHANGES.txt
* /hadoop/common/trunk/src/java/org/apache/hadoop/ipc/Server.java
* /hadoop/common/trunk/src/test/core/org/apache/hadoop/ipc/TestIPC.java
> RPC server leaks file descriptors
> ---------------------------------
>
> Key: HADOOP-7146
> URL: https://issues.apache.org/jira/browse/HADOOP-7146
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 0.22.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Fix For: 0.22.0
>
> Attachments: fd-leak.txt, hadoop-7146.txt, hadoop-7146.txt, hadoop-7146.txt
>
>
> Both the Listener and Responder thread call Selector.open but don't have a matching .close(). This causes a leak of anonymous pipes. Not a big deal because people rarely close and re-open servers, but worth fixing.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7146) RPC server leaks file descriptors
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7146?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Todd Lipcon updated HADOOP-7146:
--------------------------------
Attachment: hadoop-7146.txt
Couldn't find a way to do the test with MXBeans. This patch just uses /proc to see how many FDs are open, and uses junit's Assume support so it won't run on systems where that's not available.
> RPC server leaks file descriptors
> ---------------------------------
>
> Key: HADOOP-7146
> URL: https://issues.apache.org/jira/browse/HADOOP-7146
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 0.22.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Attachments: fd-leak.txt, hadoop-7146.txt
>
>
> Both the Listener and Responder thread call Selector.open but don't have a matching .close(). This causes a leak of anonymous pipes. Not a big deal because people rarely close and re-open servers, but worth fixing.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7146) RPC server leaks file descriptors
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13038747#comment-13038747 ]
Hadoop QA commented on HADOOP-7146:
-----------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12480303/hadoop-7146.txt
against trunk revision 1127215.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 system test framework. The patch passed system test framework compile.
Test results: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/518//testReport/
Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/518//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/518//console
This message is automatically generated.
> RPC server leaks file descriptors
> ---------------------------------
>
> Key: HADOOP-7146
> URL: https://issues.apache.org/jira/browse/HADOOP-7146
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 0.22.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Fix For: 0.22.0
>
> Attachments: fd-leak.txt, hadoop-7146.txt, hadoop-7146.txt
>
>
> Both the Listener and Responder thread call Selector.open but don't have a matching .close(). This causes a leak of anonymous pipes. Not a big deal because people rarely close and re-open servers, but worth fixing.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7146) RPC server leaks file descriptors
Posted by "Aaron T. Myers (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13037099#comment-13037099 ]
Aaron T. Myers commented on HADOOP-7146:
----------------------------------------
+1, patch looks great, Todd.
I also ran {{TestDFSStorageStateRecovery}} with this patch applied in the course of debugging HDFS-1884, and can confirm that this patch fixes that test as well.
> RPC server leaks file descriptors
> ---------------------------------
>
> Key: HADOOP-7146
> URL: https://issues.apache.org/jira/browse/HADOOP-7146
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 0.22.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Fix For: 0.22.0
>
> Attachments: fd-leak.txt, hadoop-7146.txt
>
>
> Both the Listener and Responder thread call Selector.open but don't have a matching .close(). This causes a leak of anonymous pipes. Not a big deal because people rarely close and re-open servers, but worth fixing.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7146) RPC server leaks file descriptors
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13039640#comment-13039640 ]
Hudson commented on HADOOP-7146:
--------------------------------
Integrated in Hadoop-Common-trunk-Commit #623 (See [https://builds.apache.org/hudson/job/Hadoop-Common-trunk-Commit/623/])
HADOOP-7146. RPC server leaks file descriptors. Contributed by Todd Lipcon.
todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1127811
Files :
* /hadoop/common/trunk/CHANGES.txt
* /hadoop/common/trunk/src/java/org/apache/hadoop/ipc/Server.java
* /hadoop/common/trunk/src/test/core/org/apache/hadoop/ipc/TestIPC.java
> RPC server leaks file descriptors
> ---------------------------------
>
> Key: HADOOP-7146
> URL: https://issues.apache.org/jira/browse/HADOOP-7146
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 0.22.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Fix For: 0.22.0
>
> Attachments: fd-leak.txt, hadoop-7146.txt, hadoop-7146.txt, hadoop-7146.txt
>
>
> Both the Listener and Responder thread call Selector.open but don't have a matching .close(). This causes a leak of anonymous pipes. Not a big deal because people rarely close and re-open servers, but worth fixing.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7146) RPC server leaks file descriptors
Posted by "Matt Foley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13038865#comment-13038865 ]
Matt Foley commented on HADOOP-7146:
------------------------------------
bq. I didn't add null checks - the variables in question are never reassigned to null, so there's no way they could be, as far as I can tell.
Quite right. To safeguard that, could you please make those two variables "final"?
Minor: In Reader.doRunLoop(), the LOG.Info() could use ", e" instead of "+ StringUtils.stringifyException(e)"
+1 if those small changes are okay with you.
> RPC server leaks file descriptors
> ---------------------------------
>
> Key: HADOOP-7146
> URL: https://issues.apache.org/jira/browse/HADOOP-7146
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 0.22.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Fix For: 0.22.0
>
> Attachments: fd-leak.txt, hadoop-7146.txt, hadoop-7146.txt
>
>
> Both the Listener and Responder thread call Selector.open but don't have a matching .close(). This causes a leak of anonymous pipes. Not a big deal because people rarely close and re-open servers, but worth fixing.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7146) RPC server leaks file descriptors
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7146?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Todd Lipcon updated HADOOP-7146:
--------------------------------
Status: Patch Available (was: Open)
> RPC server leaks file descriptors
> ---------------------------------
>
> Key: HADOOP-7146
> URL: https://issues.apache.org/jira/browse/HADOOP-7146
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 0.22.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Fix For: 0.22.0
>
> Attachments: fd-leak.txt, hadoop-7146.txt, hadoop-7146.txt
>
>
> Both the Listener and Responder thread call Selector.open but don't have a matching .close(). This causes a leak of anonymous pipes. Not a big deal because people rarely close and re-open servers, but worth fixing.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7146) RPC server leaks file descriptors
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7146?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Todd Lipcon updated HADOOP-7146:
--------------------------------
Fix Version/s: 0.22.0
Status: Patch Available (was: Open)
> RPC server leaks file descriptors
> ---------------------------------
>
> Key: HADOOP-7146
> URL: https://issues.apache.org/jira/browse/HADOOP-7146
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 0.22.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Fix For: 0.22.0
>
> Attachments: fd-leak.txt, hadoop-7146.txt
>
>
> Both the Listener and Responder thread call Selector.open but don't have a matching .close(). This causes a leak of anonymous pipes. Not a big deal because people rarely close and re-open servers, but worth fixing.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7146) RPC server leaks file descriptors
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7146?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Todd Lipcon updated HADOOP-7146:
--------------------------------
Status: Open (was: Patch Available)
> RPC server leaks file descriptors
> ---------------------------------
>
> Key: HADOOP-7146
> URL: https://issues.apache.org/jira/browse/HADOOP-7146
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 0.22.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Fix For: 0.22.0
>
> Attachments: fd-leak.txt, hadoop-7146.txt
>
>
> Both the Listener and Responder thread call Selector.open but don't have a matching .close(). This causes a leak of anonymous pipes. Not a big deal because people rarely close and re-open servers, but worth fixing.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7146) RPC server leaks file descriptors
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7146?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Todd Lipcon updated HADOOP-7146:
--------------------------------
Attachment: hadoop-7146.txt
New patch addressing Matt's latest comments.
I did change the log messages, though they weren't new from this patch. I agree that it's better not to use stringify, though.
> RPC server leaks file descriptors
> ---------------------------------
>
> Key: HADOOP-7146
> URL: https://issues.apache.org/jira/browse/HADOOP-7146
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 0.22.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Fix For: 0.22.0
>
> Attachments: fd-leak.txt, hadoop-7146.txt, hadoop-7146.txt, hadoop-7146.txt
>
>
> Both the Listener and Responder thread call Selector.open but don't have a matching .close(). This causes a leak of anonymous pipes. Not a big deal because people rarely close and re-open servers, but worth fixing.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7146) RPC server leaks file descriptors
Posted by "Matt Foley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13037737#comment-13037737 ]
Matt Foley commented on HADOOP-7146:
------------------------------------
Todd, kudos for finding this and how to fix it, and also to Aaron for nailing the TestDFSStorageStateRecovery problem.
I'd like to suggest a more structured fix:
1. Move the "readSelector = Selector.open()" statement from Listener() to the Reader() ctor, and change the ctor to have no arguments.
2. In Reader.run(), wrap the whole method in a try/finally context, with your five-line fix in the "finally" clause, and make it conditional on (readSelector != null).
3. In Responder.run(), similarly wrap the whole method in a try/finally context, with your five-line fix in the "finally" clause, and make it conditional on (writeSelector != null).
I would have liked to recommend putting the "readSelector = Selector.open()" [Reader] and "writeSelector = Selector.open()" [Responder] statements at the beginning of their respective run() methods, so the try/finally context would really be structured right, but I'm not sure its okay in the Responder context -- it looks like some of its methods may invoke writeSelector without the run() being running.
> RPC server leaks file descriptors
> ---------------------------------
>
> Key: HADOOP-7146
> URL: https://issues.apache.org/jira/browse/HADOOP-7146
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 0.22.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Fix For: 0.22.0
>
> Attachments: fd-leak.txt, hadoop-7146.txt
>
>
> Both the Listener and Responder thread call Selector.open but don't have a matching .close(). This causes a leak of anonymous pipes. Not a big deal because people rarely close and re-open servers, but worth fixing.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7146) RPC server leaks file descriptors
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7146?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Todd Lipcon updated HADOOP-7146:
--------------------------------
Attachment: hadoop-7146.txt
I took all of your suggestions, except I didn't add null checks - the variables in question are never reassigned to null, so there's no way they could be, as far as I can tell.
> RPC server leaks file descriptors
> ---------------------------------
>
> Key: HADOOP-7146
> URL: https://issues.apache.org/jira/browse/HADOOP-7146
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 0.22.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Fix For: 0.22.0
>
> Attachments: fd-leak.txt, hadoop-7146.txt, hadoop-7146.txt
>
>
> Both the Listener and Responder thread call Selector.open but don't have a matching .close(). This causes a leak of anonymous pipes. Not a big deal because people rarely close and re-open servers, but worth fixing.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HADOOP-7146) RPC server leaks file descriptors
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7146?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Todd Lipcon updated HADOOP-7146:
--------------------------------
Attachment: fd-leak.txt
here's a fix, but should add a unit test. There's a way you can use platform mxbeans to find the number of open FDs, but I can't quite track down the right API at the moment.
> RPC server leaks file descriptors
> ---------------------------------
>
> Key: HADOOP-7146
> URL: https://issues.apache.org/jira/browse/HADOOP-7146
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 0.22.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Attachments: fd-leak.txt
>
>
> Both the Listener and Responder thread call Selector.open but don't have a matching .close(). This causes a leak of anonymous pipes. Not a big deal because people rarely close and re-open servers, but worth fixing.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7146) RPC server leaks file descriptors
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13039638#comment-13039638 ]
Hudson commented on HADOOP-7146:
--------------------------------
Integrated in Hadoop-Common-22-branch #57 (See [https://builds.apache.org/hudson/job/Hadoop-Common-22-branch/57/])
HADOOP-7146. RPC server leaks file descriptors. Contributed by Todd Lipcon.
todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1127815
Files :
* /hadoop/common/branches/branch-0.22/src/java/org/apache/hadoop/ipc/Server.java
* /hadoop/common/branches/branch-0.22/src/test/core/org/apache/hadoop/ipc/TestIPC.java
* /hadoop/common/branches/branch-0.22/CHANGES.txt
> RPC server leaks file descriptors
> ---------------------------------
>
> Key: HADOOP-7146
> URL: https://issues.apache.org/jira/browse/HADOOP-7146
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 0.22.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Fix For: 0.22.0
>
> Attachments: fd-leak.txt, hadoop-7146.txt, hadoop-7146.txt, hadoop-7146.txt
>
>
> Both the Listener and Responder thread call Selector.open but don't have a matching .close(). This causes a leak of anonymous pipes. Not a big deal because people rarely close and re-open servers, but worth fixing.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7146) RPC server leaks file descriptors
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7146?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Todd Lipcon updated HADOOP-7146:
--------------------------------
Resolution: Fixed
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
Committed to 22 and trunk. Thanks Matt and Aaron
> RPC server leaks file descriptors
> ---------------------------------
>
> Key: HADOOP-7146
> URL: https://issues.apache.org/jira/browse/HADOOP-7146
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 0.22.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Fix For: 0.22.0
>
> Attachments: fd-leak.txt, hadoop-7146.txt, hadoop-7146.txt, hadoop-7146.txt
>
>
> Both the Listener and Responder thread call Selector.open but don't have a matching .close(). This causes a leak of anonymous pipes. Not a big deal because people rarely close and re-open servers, but worth fixing.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7146) RPC server leaks file descriptors
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13039193#comment-13039193 ]
Hadoop QA commented on HADOOP-7146:
-----------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12480424/hadoop-7146.txt
against trunk revision 1127215.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 system test framework. The patch passed system test framework compile.
Test results: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/525//testReport/
Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/525//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/525//console
This message is automatically generated.
> RPC server leaks file descriptors
> ---------------------------------
>
> Key: HADOOP-7146
> URL: https://issues.apache.org/jira/browse/HADOOP-7146
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 0.22.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Fix For: 0.22.0
>
> Attachments: fd-leak.txt, hadoop-7146.txt, hadoop-7146.txt, hadoop-7146.txt
>
>
> Both the Listener and Responder thread call Selector.open but don't have a matching .close(). This causes a leak of anonymous pipes. Not a big deal because people rarely close and re-open servers, but worth fixing.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7146) RPC server leaks file descriptors
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13037686#comment-13037686 ]
Hadoop QA commented on HADOOP-7146:
-----------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12479955/hadoop-7146.txt
against trunk revision 1125221.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 system test framework. The patch passed system test framework compile.
Test results: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/501//testReport/
Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/501//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/501//console
This message is automatically generated.
> RPC server leaks file descriptors
> ---------------------------------
>
> Key: HADOOP-7146
> URL: https://issues.apache.org/jira/browse/HADOOP-7146
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 0.22.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Fix For: 0.22.0
>
> Attachments: fd-leak.txt, hadoop-7146.txt
>
>
> Both the Listener and Responder thread call Selector.open but don't have a matching .close(). This causes a leak of anonymous pipes. Not a big deal because people rarely close and re-open servers, but worth fixing.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7146) RPC server leaks file descriptors
Posted by "Matt Foley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13039461#comment-13039461 ]
Matt Foley commented on HADOOP-7146:
------------------------------------
+1. Looks great! Thanks, Todd.
> RPC server leaks file descriptors
> ---------------------------------
>
> Key: HADOOP-7146
> URL: https://issues.apache.org/jira/browse/HADOOP-7146
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 0.22.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Fix For: 0.22.0
>
> Attachments: fd-leak.txt, hadoop-7146.txt, hadoop-7146.txt, hadoop-7146.txt
>
>
> Both the Listener and Responder thread call Selector.open but don't have a matching .close(). This causes a leak of anonymous pipes. Not a big deal because people rarely close and re-open servers, but worth fixing.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira