You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hbase.apache.org by "stack (JIRA)" <ji...@apache.org> on 2008/11/19 20:38:44 UTC

[jira] Created: (HBASE-1010) IOE on regionserver shutdown because hadn't opened an HLog.

IOE on regionserver shutdown because hadn't opened an HLog.
-----------------------------------------------------------

                 Key: HBASE-1010
                 URL: https://issues.apache.org/jira/browse/HBASE-1010
             Project: Hadoop HBase
          Issue Type: Bug
            Reporter: stack
            Priority: Minor


{code}
2008-11-19 11:32:55,120 INFO org.apache.hadoop.hbase.regionserver.CompactSplitThread: regionserver/0:0:0:0:0:0:0:0:60020.compactor exiting
2008-11-19 11:32:55,137 ERROR org.apache.hadoop.hbase.regionserver.HRegionServer: Close and delete failed
java.io.IOException: Filesystem closed
        at org.apache.hadoop.dfs.DFSClient.checkOpen(DFSClient.java:196)
        at org.apache.hadoop.dfs.DFSClient.access$600(DFSClient.java:59)
        at org.apache.hadoop.dfs.DFSClient$DFSOutputStream.closeInternal(DFSClient.java:2681)
        at org.apache.hadoop.dfs.DFSClient$DFSOutputStream.close(DFSClient.java:2647)
        at org.apache.hadoop.fs.FSDataOutputStream$PositionCache.close(FSDataOutputStream.java:59)
        at org.apache.hadoop.fs.FSDataOutputStream.close(FSDataOutputStream.java:79)
        at org.apache.hadoop.io.SequenceFile$Writer.close(SequenceFile.java:962)
        at org.apache.hadoop.hbase.regionserver.HLog.close(HLog.java:367)
        at org.apache.hadoop.hbase.regionserver.HLog.closeAndDelete(HLog.java:350)
        at org.apache.hadoop.hbase.regionserver.HRegionServer.run(HRegionServer.java:471)
        at java.lang.Thread.run(Thread.java:636)
{code}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HBASE-1010) IOE on regionserver shutdown because hadn't opened an HLog.

Posted by "stack (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12649454#action_12649454 ] 

stack commented on HBASE-1010:
------------------------------

Looking in code, this is a minor issue; no side effects. Here is code.

{code}
      try {
        log.closeAndDelete();
      } catch (IOException e) {
        LOG.error("Close and delete failed",
            RemoteExceptionHandler.checkIOException(e));
      }
{code}

Situation was a regionserver that had not been given regions just hanging out. Issue should be about making the exit cleaner for this case.

> IOE on regionserver shutdown because hadn't opened an HLog.
> -----------------------------------------------------------
>
>                 Key: HBASE-1010
>                 URL: https://issues.apache.org/jira/browse/HBASE-1010
>             Project: Hadoop HBase
>          Issue Type: Bug
>            Reporter: stack
>            Priority: Minor
>
> {code}
> 2008-11-19 11:32:55,120 INFO org.apache.hadoop.hbase.regionserver.CompactSplitThread: regionserver/0:0:0:0:0:0:0:0:60020.compactor exiting
> 2008-11-19 11:32:55,137 ERROR org.apache.hadoop.hbase.regionserver.HRegionServer: Close and delete failed
> java.io.IOException: Filesystem closed
>         at org.apache.hadoop.dfs.DFSClient.checkOpen(DFSClient.java:196)
>         at org.apache.hadoop.dfs.DFSClient.access$600(DFSClient.java:59)
>         at org.apache.hadoop.dfs.DFSClient$DFSOutputStream.closeInternal(DFSClient.java:2681)
>         at org.apache.hadoop.dfs.DFSClient$DFSOutputStream.close(DFSClient.java:2647)
>         at org.apache.hadoop.fs.FSDataOutputStream$PositionCache.close(FSDataOutputStream.java:59)
>         at org.apache.hadoop.fs.FSDataOutputStream.close(FSDataOutputStream.java:79)
>         at org.apache.hadoop.io.SequenceFile$Writer.close(SequenceFile.java:962)
>         at org.apache.hadoop.hbase.regionserver.HLog.close(HLog.java:367)
>         at org.apache.hadoop.hbase.regionserver.HLog.closeAndDelete(HLog.java:350)
>         at org.apache.hadoop.hbase.regionserver.HRegionServer.run(HRegionServer.java:471)
>         at java.lang.Thread.run(Thread.java:636)
> {code}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (HBASE-1010) IOE on regionserver shutdown because hadn't opened an HLog.

Posted by "stack (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

stack resolved HBASE-1010.
--------------------------

       Resolution: Fixed
    Fix Version/s: 0.20.0

Committed:

{code}
Index: src/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
===================================================================
--- src/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java    (revision 776807)
+++ src/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java    (working copy)
@@ -644,7 +644,9 @@
     } else {
       ArrayList<HRegion> closedRegions = closeAllRegions();
       try {
-        hlog.closeAndDelete();
+        if (this.hlog != null) {
+          hlog.closeAndDelete();
+        }
       } catch (Throwable e) {
         LOG.error("Close and delete failed",
           RemoteExceptionHandler.checkThrowable(e));
{code}

> IOE on regionserver shutdown because hadn't opened an HLog.
> -----------------------------------------------------------
>
>                 Key: HBASE-1010
>                 URL: https://issues.apache.org/jira/browse/HBASE-1010
>             Project: Hadoop HBase
>          Issue Type: Bug
>            Reporter: stack
>            Priority: Minor
>             Fix For: 0.20.0
>
>
> {code}
> 2008-11-19 11:32:55,120 INFO org.apache.hadoop.hbase.regionserver.CompactSplitThread: regionserver/0:0:0:0:0:0:0:0:60020.compactor exiting
> 2008-11-19 11:32:55,137 ERROR org.apache.hadoop.hbase.regionserver.HRegionServer: Close and delete failed
> java.io.IOException: Filesystem closed
>         at org.apache.hadoop.dfs.DFSClient.checkOpen(DFSClient.java:196)
>         at org.apache.hadoop.dfs.DFSClient.access$600(DFSClient.java:59)
>         at org.apache.hadoop.dfs.DFSClient$DFSOutputStream.closeInternal(DFSClient.java:2681)
>         at org.apache.hadoop.dfs.DFSClient$DFSOutputStream.close(DFSClient.java:2647)
>         at org.apache.hadoop.fs.FSDataOutputStream$PositionCache.close(FSDataOutputStream.java:59)
>         at org.apache.hadoop.fs.FSDataOutputStream.close(FSDataOutputStream.java:79)
>         at org.apache.hadoop.io.SequenceFile$Writer.close(SequenceFile.java:962)
>         at org.apache.hadoop.hbase.regionserver.HLog.close(HLog.java:367)
>         at org.apache.hadoop.hbase.regionserver.HLog.closeAndDelete(HLog.java:350)
>         at org.apache.hadoop.hbase.regionserver.HRegionServer.run(HRegionServer.java:471)
>         at java.lang.Thread.run(Thread.java:636)
> {code}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.