You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bigtop.apache.org by Sean Mackrory <ma...@gmail.com> on 2014/05/10 01:31:24 UTC
Review Request 21293: Adding Apache Accumulo to Apache Bigtop
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21293/
-----------------------------------------------------------
Review request for bigtop.
Bugs: BIGTOP-1175
https://issues.apache.org/jira/browse/BIGTOP-1175
Repository: bigtop
Description
-------
See JIRA
Diffs
-----
bigtop-packages/src/common/accumulo/accumulo-gc.svc PRE-CREATION
bigtop-packages/src/common/accumulo/accumulo-master.svc PRE-CREATION
bigtop-packages/src/common/accumulo/accumulo-monitor.svc PRE-CREATION
bigtop-packages/src/common/accumulo/accumulo-tracer.svc PRE-CREATION
bigtop-packages/src/common/accumulo/accumulo-tserver.svc PRE-CREATION
bigtop-packages/src/common/accumulo/conf/accumulo-env.sh PRE-CREATION
bigtop-packages/src/common/accumulo/conf/accumulo-metrics.xml PRE-CREATION
bigtop-packages/src/common/accumulo/conf/accumulo-site.xml PRE-CREATION
bigtop-packages/src/common/accumulo/conf/generic_logger.xml PRE-CREATION
bigtop-packages/src/common/accumulo/conf/log4j.properties PRE-CREATION
bigtop-packages/src/common/accumulo/conf/monitor_logger.xml PRE-CREATION
bigtop-packages/src/common/accumulo/do-component-build PRE-CREATION
bigtop-packages/src/common/accumulo/install_accumulo.sh PRE-CREATION
bigtop-packages/src/common/hadoop/init-hcfs.json d8825aa33839b88d09ee928e0be83c46e88a2992
bigtop-packages/src/common/hadoop/init-hdfs.sh 3a5fe361dd56308f465a52214835a42900a618cd
bigtop-packages/src/deb/accumulo/accumulo-doc.install PRE-CREATION
bigtop-packages/src/deb/accumulo/accumulo.install PRE-CREATION
bigtop-packages/src/deb/accumulo/accumulo.postinst PRE-CREATION
bigtop-packages/src/deb/accumulo/accumulo.preinst PRE-CREATION
bigtop-packages/src/deb/accumulo/accumulo.prerm PRE-CREATION
bigtop-packages/src/deb/accumulo/compat PRE-CREATION
bigtop-packages/src/deb/accumulo/control PRE-CREATION
bigtop-packages/src/deb/accumulo/copyright PRE-CREATION
bigtop-packages/src/deb/accumulo/install_init_scripts.sh PRE-CREATION
bigtop-packages/src/deb/accumulo/rules PRE-CREATION
bigtop-packages/src/deb/accumulo/service-postinst.tpl PRE-CREATION
bigtop-packages/src/deb/accumulo/service-postrm.tpl PRE-CREATION
bigtop-packages/src/deb/accumulo/source/format PRE-CREATION
bigtop-packages/src/rpm/accumulo/RPMS/.gitignore PRE-CREATION
bigtop-packages/src/rpm/accumulo/SOURCES/.gitignore PRE-CREATION
bigtop-packages/src/rpm/accumulo/SPECS/.gitignore PRE-CREATION
bigtop-packages/src/rpm/accumulo/SPECS/accumulo.spec PRE-CREATION
bigtop-packages/src/rpm/accumulo/SRPMS/.gitignore PRE-CREATION
bigtop-packages/src/templates/init.d.tmpl 57923240c2402c66b758790fcd8522186827f836
bigtop.mk 672562a5d60b1043c7495183c8a5c4bcc571c960
Diff: https://reviews.apache.org/r/21293/diff/
Testing
-------
See JIRA
Thanks,
Sean Mackrory
Re: Review Request 21293: Adding Apache Accumulo to Apache Bigtop
Posted by Sean Mackrory <ma...@gmail.com>.
> On June 9, 2014, 6:22 p.m., Josh Elser wrote:
> > bigtop-packages/src/common/accumulo/install_accumulo.sh, line 163
> > <https://reviews.apache.org/r/21293/diff/1/?file=577870#file577870line163>
> >
> > This can be removed as it's not referenced anywhere.
Yes - I believe that's vestigial from a previous version of Accumulo, which I originally started the packaging on.
- Sean
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21293/#review45098
-----------------------------------------------------------
On May 9, 2014, 11:31 p.m., Sean Mackrory wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21293/
> -----------------------------------------------------------
>
> (Updated May 9, 2014, 11:31 p.m.)
>
>
> Review request for bigtop.
>
>
> Bugs: BIGTOP-1175
> https://issues.apache.org/jira/browse/BIGTOP-1175
>
>
> Repository: bigtop
>
>
> Description
> -------
>
> See JIRA
>
>
> Diffs
> -----
>
> bigtop-packages/src/common/accumulo/accumulo-gc.svc PRE-CREATION
> bigtop-packages/src/common/accumulo/accumulo-master.svc PRE-CREATION
> bigtop-packages/src/common/accumulo/accumulo-monitor.svc PRE-CREATION
> bigtop-packages/src/common/accumulo/accumulo-tracer.svc PRE-CREATION
> bigtop-packages/src/common/accumulo/accumulo-tserver.svc PRE-CREATION
> bigtop-packages/src/common/accumulo/conf/accumulo-env.sh PRE-CREATION
> bigtop-packages/src/common/accumulo/conf/accumulo-metrics.xml PRE-CREATION
> bigtop-packages/src/common/accumulo/conf/accumulo-site.xml PRE-CREATION
> bigtop-packages/src/common/accumulo/conf/generic_logger.xml PRE-CREATION
> bigtop-packages/src/common/accumulo/conf/log4j.properties PRE-CREATION
> bigtop-packages/src/common/accumulo/conf/monitor_logger.xml PRE-CREATION
> bigtop-packages/src/common/accumulo/do-component-build PRE-CREATION
> bigtop-packages/src/common/accumulo/install_accumulo.sh PRE-CREATION
> bigtop-packages/src/common/hadoop/init-hcfs.json d8825aa33839b88d09ee928e0be83c46e88a2992
> bigtop-packages/src/common/hadoop/init-hdfs.sh 3a5fe361dd56308f465a52214835a42900a618cd
> bigtop-packages/src/deb/accumulo/accumulo-doc.install PRE-CREATION
> bigtop-packages/src/deb/accumulo/accumulo.install PRE-CREATION
> bigtop-packages/src/deb/accumulo/accumulo.postinst PRE-CREATION
> bigtop-packages/src/deb/accumulo/accumulo.preinst PRE-CREATION
> bigtop-packages/src/deb/accumulo/accumulo.prerm PRE-CREATION
> bigtop-packages/src/deb/accumulo/compat PRE-CREATION
> bigtop-packages/src/deb/accumulo/control PRE-CREATION
> bigtop-packages/src/deb/accumulo/copyright PRE-CREATION
> bigtop-packages/src/deb/accumulo/install_init_scripts.sh PRE-CREATION
> bigtop-packages/src/deb/accumulo/rules PRE-CREATION
> bigtop-packages/src/deb/accumulo/service-postinst.tpl PRE-CREATION
> bigtop-packages/src/deb/accumulo/service-postrm.tpl PRE-CREATION
> bigtop-packages/src/deb/accumulo/source/format PRE-CREATION
> bigtop-packages/src/rpm/accumulo/RPMS/.gitignore PRE-CREATION
> bigtop-packages/src/rpm/accumulo/SOURCES/.gitignore PRE-CREATION
> bigtop-packages/src/rpm/accumulo/SPECS/.gitignore PRE-CREATION
> bigtop-packages/src/rpm/accumulo/SPECS/accumulo.spec PRE-CREATION
> bigtop-packages/src/rpm/accumulo/SRPMS/.gitignore PRE-CREATION
> bigtop-packages/src/templates/init.d.tmpl 57923240c2402c66b758790fcd8522186827f836
> bigtop.mk 672562a5d60b1043c7495183c8a5c4bcc571c960
>
> Diff: https://reviews.apache.org/r/21293/diff/
>
>
> Testing
> -------
>
> See JIRA
>
>
> Thanks,
>
> Sean Mackrory
>
>
Re: Review Request 21293: Adding Apache Accumulo to Apache Bigtop
Posted by Josh Elser <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21293/#review45098
-----------------------------------------------------------
Two very minor removals, both of which shouldn't break anything if this were committed as-is. LGTM!
bigtop-packages/src/common/accumulo/conf/accumulo-site.xml
<https://reviews.apache.org/r/21293/#comment79760>
I think this line is unnecessary (also is missing the '*') as the following line will encompass this one.
bigtop-packages/src/common/accumulo/install_accumulo.sh
<https://reviews.apache.org/r/21293/#comment79761>
This can be removed as it's not referenced anywhere.
- Josh Elser
On May 9, 2014, 11:31 p.m., Sean Mackrory wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21293/
> -----------------------------------------------------------
>
> (Updated May 9, 2014, 11:31 p.m.)
>
>
> Review request for bigtop.
>
>
> Bugs: BIGTOP-1175
> https://issues.apache.org/jira/browse/BIGTOP-1175
>
>
> Repository: bigtop
>
>
> Description
> -------
>
> See JIRA
>
>
> Diffs
> -----
>
> bigtop-packages/src/common/accumulo/accumulo-gc.svc PRE-CREATION
> bigtop-packages/src/common/accumulo/accumulo-master.svc PRE-CREATION
> bigtop-packages/src/common/accumulo/accumulo-monitor.svc PRE-CREATION
> bigtop-packages/src/common/accumulo/accumulo-tracer.svc PRE-CREATION
> bigtop-packages/src/common/accumulo/accumulo-tserver.svc PRE-CREATION
> bigtop-packages/src/common/accumulo/conf/accumulo-env.sh PRE-CREATION
> bigtop-packages/src/common/accumulo/conf/accumulo-metrics.xml PRE-CREATION
> bigtop-packages/src/common/accumulo/conf/accumulo-site.xml PRE-CREATION
> bigtop-packages/src/common/accumulo/conf/generic_logger.xml PRE-CREATION
> bigtop-packages/src/common/accumulo/conf/log4j.properties PRE-CREATION
> bigtop-packages/src/common/accumulo/conf/monitor_logger.xml PRE-CREATION
> bigtop-packages/src/common/accumulo/do-component-build PRE-CREATION
> bigtop-packages/src/common/accumulo/install_accumulo.sh PRE-CREATION
> bigtop-packages/src/common/hadoop/init-hcfs.json d8825aa33839b88d09ee928e0be83c46e88a2992
> bigtop-packages/src/common/hadoop/init-hdfs.sh 3a5fe361dd56308f465a52214835a42900a618cd
> bigtop-packages/src/deb/accumulo/accumulo-doc.install PRE-CREATION
> bigtop-packages/src/deb/accumulo/accumulo.install PRE-CREATION
> bigtop-packages/src/deb/accumulo/accumulo.postinst PRE-CREATION
> bigtop-packages/src/deb/accumulo/accumulo.preinst PRE-CREATION
> bigtop-packages/src/deb/accumulo/accumulo.prerm PRE-CREATION
> bigtop-packages/src/deb/accumulo/compat PRE-CREATION
> bigtop-packages/src/deb/accumulo/control PRE-CREATION
> bigtop-packages/src/deb/accumulo/copyright PRE-CREATION
> bigtop-packages/src/deb/accumulo/install_init_scripts.sh PRE-CREATION
> bigtop-packages/src/deb/accumulo/rules PRE-CREATION
> bigtop-packages/src/deb/accumulo/service-postinst.tpl PRE-CREATION
> bigtop-packages/src/deb/accumulo/service-postrm.tpl PRE-CREATION
> bigtop-packages/src/deb/accumulo/source/format PRE-CREATION
> bigtop-packages/src/rpm/accumulo/RPMS/.gitignore PRE-CREATION
> bigtop-packages/src/rpm/accumulo/SOURCES/.gitignore PRE-CREATION
> bigtop-packages/src/rpm/accumulo/SPECS/.gitignore PRE-CREATION
> bigtop-packages/src/rpm/accumulo/SPECS/accumulo.spec PRE-CREATION
> bigtop-packages/src/rpm/accumulo/SRPMS/.gitignore PRE-CREATION
> bigtop-packages/src/templates/init.d.tmpl 57923240c2402c66b758790fcd8522186827f836
> bigtop.mk 672562a5d60b1043c7495183c8a5c4bcc571c960
>
> Diff: https://reviews.apache.org/r/21293/diff/
>
>
> Testing
> -------
>
> See JIRA
>
>
> Thanks,
>
> Sean Mackrory
>
>
Re: Review Request 21293: Adding Apache Accumulo to Apache Bigtop
Posted by Sean Mackrory <ma...@gmail.com>.
> On June 24, 2014, 4:20 a.m., Josh Elser wrote:
> > bigtop-packages/src/common/accumulo/conf/accumulo-site.xml, line 63
> > <https://reviews.apache.org/r/21293/diff/1/?file=577865#file577865line63>
> >
> > Why change from the default value of 9999?
It was a port conflict on my specific cluster which I had forgotten about. I will change it back to the upstream default...
> On June 24, 2014, 4:20 a.m., Josh Elser wrote:
> > bigtop-packages/src/common/accumulo/conf/accumulo-site.xml, line 67
> > <https://reviews.apache.org/r/21293/diff/1/?file=577865#file577865line67>
> >
> > Why change from the default value of 9997?
As above. Thanks for the review! Will re-test and update my posted patch soon...
- Sean
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21293/#review46492
-----------------------------------------------------------
On May 9, 2014, 11:31 p.m., Sean Mackrory wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21293/
> -----------------------------------------------------------
>
> (Updated May 9, 2014, 11:31 p.m.)
>
>
> Review request for bigtop.
>
>
> Bugs: BIGTOP-1175
> https://issues.apache.org/jira/browse/BIGTOP-1175
>
>
> Repository: bigtop
>
>
> Description
> -------
>
> See JIRA
>
>
> Diffs
> -----
>
> bigtop-packages/src/common/accumulo/accumulo-gc.svc PRE-CREATION
> bigtop-packages/src/common/accumulo/accumulo-master.svc PRE-CREATION
> bigtop-packages/src/common/accumulo/accumulo-monitor.svc PRE-CREATION
> bigtop-packages/src/common/accumulo/accumulo-tracer.svc PRE-CREATION
> bigtop-packages/src/common/accumulo/accumulo-tserver.svc PRE-CREATION
> bigtop-packages/src/common/accumulo/conf/accumulo-env.sh PRE-CREATION
> bigtop-packages/src/common/accumulo/conf/accumulo-metrics.xml PRE-CREATION
> bigtop-packages/src/common/accumulo/conf/accumulo-site.xml PRE-CREATION
> bigtop-packages/src/common/accumulo/conf/generic_logger.xml PRE-CREATION
> bigtop-packages/src/common/accumulo/conf/log4j.properties PRE-CREATION
> bigtop-packages/src/common/accumulo/conf/monitor_logger.xml PRE-CREATION
> bigtop-packages/src/common/accumulo/do-component-build PRE-CREATION
> bigtop-packages/src/common/accumulo/install_accumulo.sh PRE-CREATION
> bigtop-packages/src/common/hadoop/init-hcfs.json d8825aa33839b88d09ee928e0be83c46e88a2992
> bigtop-packages/src/common/hadoop/init-hdfs.sh 3a5fe361dd56308f465a52214835a42900a618cd
> bigtop-packages/src/deb/accumulo/accumulo-doc.install PRE-CREATION
> bigtop-packages/src/deb/accumulo/accumulo.install PRE-CREATION
> bigtop-packages/src/deb/accumulo/accumulo.postinst PRE-CREATION
> bigtop-packages/src/deb/accumulo/accumulo.preinst PRE-CREATION
> bigtop-packages/src/deb/accumulo/accumulo.prerm PRE-CREATION
> bigtop-packages/src/deb/accumulo/compat PRE-CREATION
> bigtop-packages/src/deb/accumulo/control PRE-CREATION
> bigtop-packages/src/deb/accumulo/copyright PRE-CREATION
> bigtop-packages/src/deb/accumulo/install_init_scripts.sh PRE-CREATION
> bigtop-packages/src/deb/accumulo/rules PRE-CREATION
> bigtop-packages/src/deb/accumulo/service-postinst.tpl PRE-CREATION
> bigtop-packages/src/deb/accumulo/service-postrm.tpl PRE-CREATION
> bigtop-packages/src/deb/accumulo/source/format PRE-CREATION
> bigtop-packages/src/rpm/accumulo/RPMS/.gitignore PRE-CREATION
> bigtop-packages/src/rpm/accumulo/SOURCES/.gitignore PRE-CREATION
> bigtop-packages/src/rpm/accumulo/SPECS/.gitignore PRE-CREATION
> bigtop-packages/src/rpm/accumulo/SPECS/accumulo.spec PRE-CREATION
> bigtop-packages/src/rpm/accumulo/SRPMS/.gitignore PRE-CREATION
> bigtop-packages/src/templates/init.d.tmpl 57923240c2402c66b758790fcd8522186827f836
> bigtop.mk 672562a5d60b1043c7495183c8a5c4bcc571c960
>
> Diff: https://reviews.apache.org/r/21293/diff/
>
>
> Testing
> -------
>
> See JIRA
>
>
> Thanks,
>
> Sean Mackrory
>
>
Re: Review Request 21293: Adding Apache Accumulo to Apache Bigtop
Posted by Josh Elser <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21293/#review46492
-----------------------------------------------------------
bigtop-packages/src/common/accumulo/conf/accumulo-site.xml
<https://reviews.apache.org/r/21293/#comment81881>
Why change from the default value of 9999?
bigtop-packages/src/common/accumulo/conf/accumulo-site.xml
<https://reviews.apache.org/r/21293/#comment81882>
Why change from the default value of 9997?
- Josh Elser
On May 9, 2014, 11:31 p.m., Sean Mackrory wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21293/
> -----------------------------------------------------------
>
> (Updated May 9, 2014, 11:31 p.m.)
>
>
> Review request for bigtop.
>
>
> Bugs: BIGTOP-1175
> https://issues.apache.org/jira/browse/BIGTOP-1175
>
>
> Repository: bigtop
>
>
> Description
> -------
>
> See JIRA
>
>
> Diffs
> -----
>
> bigtop-packages/src/common/accumulo/accumulo-gc.svc PRE-CREATION
> bigtop-packages/src/common/accumulo/accumulo-master.svc PRE-CREATION
> bigtop-packages/src/common/accumulo/accumulo-monitor.svc PRE-CREATION
> bigtop-packages/src/common/accumulo/accumulo-tracer.svc PRE-CREATION
> bigtop-packages/src/common/accumulo/accumulo-tserver.svc PRE-CREATION
> bigtop-packages/src/common/accumulo/conf/accumulo-env.sh PRE-CREATION
> bigtop-packages/src/common/accumulo/conf/accumulo-metrics.xml PRE-CREATION
> bigtop-packages/src/common/accumulo/conf/accumulo-site.xml PRE-CREATION
> bigtop-packages/src/common/accumulo/conf/generic_logger.xml PRE-CREATION
> bigtop-packages/src/common/accumulo/conf/log4j.properties PRE-CREATION
> bigtop-packages/src/common/accumulo/conf/monitor_logger.xml PRE-CREATION
> bigtop-packages/src/common/accumulo/do-component-build PRE-CREATION
> bigtop-packages/src/common/accumulo/install_accumulo.sh PRE-CREATION
> bigtop-packages/src/common/hadoop/init-hcfs.json d8825aa33839b88d09ee928e0be83c46e88a2992
> bigtop-packages/src/common/hadoop/init-hdfs.sh 3a5fe361dd56308f465a52214835a42900a618cd
> bigtop-packages/src/deb/accumulo/accumulo-doc.install PRE-CREATION
> bigtop-packages/src/deb/accumulo/accumulo.install PRE-CREATION
> bigtop-packages/src/deb/accumulo/accumulo.postinst PRE-CREATION
> bigtop-packages/src/deb/accumulo/accumulo.preinst PRE-CREATION
> bigtop-packages/src/deb/accumulo/accumulo.prerm PRE-CREATION
> bigtop-packages/src/deb/accumulo/compat PRE-CREATION
> bigtop-packages/src/deb/accumulo/control PRE-CREATION
> bigtop-packages/src/deb/accumulo/copyright PRE-CREATION
> bigtop-packages/src/deb/accumulo/install_init_scripts.sh PRE-CREATION
> bigtop-packages/src/deb/accumulo/rules PRE-CREATION
> bigtop-packages/src/deb/accumulo/service-postinst.tpl PRE-CREATION
> bigtop-packages/src/deb/accumulo/service-postrm.tpl PRE-CREATION
> bigtop-packages/src/deb/accumulo/source/format PRE-CREATION
> bigtop-packages/src/rpm/accumulo/RPMS/.gitignore PRE-CREATION
> bigtop-packages/src/rpm/accumulo/SOURCES/.gitignore PRE-CREATION
> bigtop-packages/src/rpm/accumulo/SPECS/.gitignore PRE-CREATION
> bigtop-packages/src/rpm/accumulo/SPECS/accumulo.spec PRE-CREATION
> bigtop-packages/src/rpm/accumulo/SRPMS/.gitignore PRE-CREATION
> bigtop-packages/src/templates/init.d.tmpl 57923240c2402c66b758790fcd8522186827f836
> bigtop.mk 672562a5d60b1043c7495183c8a5c4bcc571c960
>
> Diff: https://reviews.apache.org/r/21293/diff/
>
>
> Testing
> -------
>
> See JIRA
>
>
> Thanks,
>
> Sean Mackrory
>
>
Re: Review Request 21293: Adding Apache Accumulo to Apache Bigtop
Posted by Sean Mackrory <ma...@gmail.com>.
> On June 24, 2014, 4:09 a.m., Josh Elser wrote:
> > bigtop-packages/src/common/accumulo/accumulo-master.svc, line 42
> > <https://reviews.apache.org/r/21293/diff/1/?file=577859#file577859line42>
> >
> > This is doing some unexpected output echo (note the password not being hidden):
> >
> > <snip>
> > Instance name : accumulo-bigtop
> > accumulo-bigtop
> > Enter initial password for root (this may not be applicable for your security setup): password
> > ********
> > Confirm initial password for root: password
> > ********
> > </snip>
> >
> > I should get the text that appears on the newline to the right of the prompt.
> >
> > Changing this line to `sudo -u $SVC_USER ${EXEC_PATH} init` makes the command operate as expected. I don't quite understand why, but it appears that something with the su is messing things up with the shell output.
> >
That makes sense - I had wondered about that because IIRC it's like that on Debian, but it works on Red Hat, so I had put it down to perhaps some difference in LSB init functions or something. Will change...
- Sean
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21293/#review46491
-----------------------------------------------------------
On May 9, 2014, 11:31 p.m., Sean Mackrory wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21293/
> -----------------------------------------------------------
>
> (Updated May 9, 2014, 11:31 p.m.)
>
>
> Review request for bigtop.
>
>
> Bugs: BIGTOP-1175
> https://issues.apache.org/jira/browse/BIGTOP-1175
>
>
> Repository: bigtop
>
>
> Description
> -------
>
> See JIRA
>
>
> Diffs
> -----
>
> bigtop-packages/src/common/accumulo/accumulo-gc.svc PRE-CREATION
> bigtop-packages/src/common/accumulo/accumulo-master.svc PRE-CREATION
> bigtop-packages/src/common/accumulo/accumulo-monitor.svc PRE-CREATION
> bigtop-packages/src/common/accumulo/accumulo-tracer.svc PRE-CREATION
> bigtop-packages/src/common/accumulo/accumulo-tserver.svc PRE-CREATION
> bigtop-packages/src/common/accumulo/conf/accumulo-env.sh PRE-CREATION
> bigtop-packages/src/common/accumulo/conf/accumulo-metrics.xml PRE-CREATION
> bigtop-packages/src/common/accumulo/conf/accumulo-site.xml PRE-CREATION
> bigtop-packages/src/common/accumulo/conf/generic_logger.xml PRE-CREATION
> bigtop-packages/src/common/accumulo/conf/log4j.properties PRE-CREATION
> bigtop-packages/src/common/accumulo/conf/monitor_logger.xml PRE-CREATION
> bigtop-packages/src/common/accumulo/do-component-build PRE-CREATION
> bigtop-packages/src/common/accumulo/install_accumulo.sh PRE-CREATION
> bigtop-packages/src/common/hadoop/init-hcfs.json d8825aa33839b88d09ee928e0be83c46e88a2992
> bigtop-packages/src/common/hadoop/init-hdfs.sh 3a5fe361dd56308f465a52214835a42900a618cd
> bigtop-packages/src/deb/accumulo/accumulo-doc.install PRE-CREATION
> bigtop-packages/src/deb/accumulo/accumulo.install PRE-CREATION
> bigtop-packages/src/deb/accumulo/accumulo.postinst PRE-CREATION
> bigtop-packages/src/deb/accumulo/accumulo.preinst PRE-CREATION
> bigtop-packages/src/deb/accumulo/accumulo.prerm PRE-CREATION
> bigtop-packages/src/deb/accumulo/compat PRE-CREATION
> bigtop-packages/src/deb/accumulo/control PRE-CREATION
> bigtop-packages/src/deb/accumulo/copyright PRE-CREATION
> bigtop-packages/src/deb/accumulo/install_init_scripts.sh PRE-CREATION
> bigtop-packages/src/deb/accumulo/rules PRE-CREATION
> bigtop-packages/src/deb/accumulo/service-postinst.tpl PRE-CREATION
> bigtop-packages/src/deb/accumulo/service-postrm.tpl PRE-CREATION
> bigtop-packages/src/deb/accumulo/source/format PRE-CREATION
> bigtop-packages/src/rpm/accumulo/RPMS/.gitignore PRE-CREATION
> bigtop-packages/src/rpm/accumulo/SOURCES/.gitignore PRE-CREATION
> bigtop-packages/src/rpm/accumulo/SPECS/.gitignore PRE-CREATION
> bigtop-packages/src/rpm/accumulo/SPECS/accumulo.spec PRE-CREATION
> bigtop-packages/src/rpm/accumulo/SRPMS/.gitignore PRE-CREATION
> bigtop-packages/src/templates/init.d.tmpl 57923240c2402c66b758790fcd8522186827f836
> bigtop.mk 672562a5d60b1043c7495183c8a5c4bcc571c960
>
> Diff: https://reviews.apache.org/r/21293/diff/
>
>
> Testing
> -------
>
> See JIRA
>
>
> Thanks,
>
> Sean Mackrory
>
>
Re: Review Request 21293: Adding Apache Accumulo to Apache Bigtop
Posted by Sean Mackrory <ma...@gmail.com>.
> On June 24, 2014, 4:09 a.m., Josh Elser wrote:
> > bigtop-packages/src/common/accumulo/accumulo-master.svc, line 42
> > <https://reviews.apache.org/r/21293/diff/1/?file=577859#file577859line42>
> >
> > This is doing some unexpected output echo (note the password not being hidden):
> >
> > <snip>
> > Instance name : accumulo-bigtop
> > accumulo-bigtop
> > Enter initial password for root (this may not be applicable for your security setup): password
> > ********
> > Confirm initial password for root: password
> > ********
> > </snip>
> >
> > I should get the text that appears on the newline to the right of the prompt.
> >
> > Changing this line to `sudo -u $SVC_USER ${EXEC_PATH} init` makes the command operate as expected. I don't quite understand why, but it appears that something with the su is messing things up with the shell output.
> >
>
> Sean Mackrory wrote:
> That makes sense - I had wondered about that because IIRC it's like that on Debian, but it works on Red Hat, so I had put it down to perhaps some difference in LSB init functions or something. Will change...
One other issue here is that I know we've avoided using sudo in the past because not all Linux systems have it, and we didn't want to require it. I'll do a bit of digging and see if there's a way to make it work with su.
- Sean
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21293/#review46491
-----------------------------------------------------------
On May 9, 2014, 11:31 p.m., Sean Mackrory wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21293/
> -----------------------------------------------------------
>
> (Updated May 9, 2014, 11:31 p.m.)
>
>
> Review request for bigtop.
>
>
> Bugs: BIGTOP-1175
> https://issues.apache.org/jira/browse/BIGTOP-1175
>
>
> Repository: bigtop
>
>
> Description
> -------
>
> See JIRA
>
>
> Diffs
> -----
>
> bigtop-packages/src/common/accumulo/accumulo-gc.svc PRE-CREATION
> bigtop-packages/src/common/accumulo/accumulo-master.svc PRE-CREATION
> bigtop-packages/src/common/accumulo/accumulo-monitor.svc PRE-CREATION
> bigtop-packages/src/common/accumulo/accumulo-tracer.svc PRE-CREATION
> bigtop-packages/src/common/accumulo/accumulo-tserver.svc PRE-CREATION
> bigtop-packages/src/common/accumulo/conf/accumulo-env.sh PRE-CREATION
> bigtop-packages/src/common/accumulo/conf/accumulo-metrics.xml PRE-CREATION
> bigtop-packages/src/common/accumulo/conf/accumulo-site.xml PRE-CREATION
> bigtop-packages/src/common/accumulo/conf/generic_logger.xml PRE-CREATION
> bigtop-packages/src/common/accumulo/conf/log4j.properties PRE-CREATION
> bigtop-packages/src/common/accumulo/conf/monitor_logger.xml PRE-CREATION
> bigtop-packages/src/common/accumulo/do-component-build PRE-CREATION
> bigtop-packages/src/common/accumulo/install_accumulo.sh PRE-CREATION
> bigtop-packages/src/common/hadoop/init-hcfs.json d8825aa33839b88d09ee928e0be83c46e88a2992
> bigtop-packages/src/common/hadoop/init-hdfs.sh 3a5fe361dd56308f465a52214835a42900a618cd
> bigtop-packages/src/deb/accumulo/accumulo-doc.install PRE-CREATION
> bigtop-packages/src/deb/accumulo/accumulo.install PRE-CREATION
> bigtop-packages/src/deb/accumulo/accumulo.postinst PRE-CREATION
> bigtop-packages/src/deb/accumulo/accumulo.preinst PRE-CREATION
> bigtop-packages/src/deb/accumulo/accumulo.prerm PRE-CREATION
> bigtop-packages/src/deb/accumulo/compat PRE-CREATION
> bigtop-packages/src/deb/accumulo/control PRE-CREATION
> bigtop-packages/src/deb/accumulo/copyright PRE-CREATION
> bigtop-packages/src/deb/accumulo/install_init_scripts.sh PRE-CREATION
> bigtop-packages/src/deb/accumulo/rules PRE-CREATION
> bigtop-packages/src/deb/accumulo/service-postinst.tpl PRE-CREATION
> bigtop-packages/src/deb/accumulo/service-postrm.tpl PRE-CREATION
> bigtop-packages/src/deb/accumulo/source/format PRE-CREATION
> bigtop-packages/src/rpm/accumulo/RPMS/.gitignore PRE-CREATION
> bigtop-packages/src/rpm/accumulo/SOURCES/.gitignore PRE-CREATION
> bigtop-packages/src/rpm/accumulo/SPECS/.gitignore PRE-CREATION
> bigtop-packages/src/rpm/accumulo/SPECS/accumulo.spec PRE-CREATION
> bigtop-packages/src/rpm/accumulo/SRPMS/.gitignore PRE-CREATION
> bigtop-packages/src/templates/init.d.tmpl 57923240c2402c66b758790fcd8522186827f836
> bigtop.mk 672562a5d60b1043c7495183c8a5c4bcc571c960
>
> Diff: https://reviews.apache.org/r/21293/diff/
>
>
> Testing
> -------
>
> See JIRA
>
>
> Thanks,
>
> Sean Mackrory
>
>
Re: Review Request 21293: Adding Apache Accumulo to Apache Bigtop
Posted by Sean Mackrory <ma...@gmail.com>.
> On June 24, 2014, 4:09 a.m., Josh Elser wrote:
> > bigtop-packages/src/common/accumulo/accumulo-master.svc, line 42
> > <https://reviews.apache.org/r/21293/diff/1/?file=577859#file577859line42>
> >
> > This is doing some unexpected output echo (note the password not being hidden):
> >
> > <snip>
> > Instance name : accumulo-bigtop
> > accumulo-bigtop
> > Enter initial password for root (this may not be applicable for your security setup): password
> > ********
> > Confirm initial password for root: password
> > ********
> > </snip>
> >
> > I should get the text that appears on the newline to the right of the prompt.
> >
> > Changing this line to `sudo -u $SVC_USER ${EXEC_PATH} init` makes the command operate as expected. I don't quite understand why, but it appears that something with the su is messing things up with the shell output.
> >
>
> Sean Mackrory wrote:
> That makes sense - I had wondered about that because IIRC it's like that on Debian, but it works on Red Hat, so I had put it down to perhaps some difference in LSB init functions or something. Will change...
>
> Sean Mackrory wrote:
> One other issue here is that I know we've avoided using sudo in the past because not all Linux systems have it, and we didn't want to require it. I'll do a bit of digging and see if there's a way to make it work with su.
>
> Josh Elser wrote:
> Yup, that's a valid concern. I didn't entire understand what was going on. The `sudo` variant was just enough to keep me going to verify functionality :)
Since I've gone ahead and pushed this to it's own branch until there's a formal +1 to merge it into the main branch, I've filed this as a separate issue to look into further: BIGTOP-1353.
- Sean
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21293/#review46491
-----------------------------------------------------------
On May 9, 2014, 11:31 p.m., Sean Mackrory wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21293/
> -----------------------------------------------------------
>
> (Updated May 9, 2014, 11:31 p.m.)
>
>
> Review request for bigtop.
>
>
> Bugs: BIGTOP-1175
> https://issues.apache.org/jira/browse/BIGTOP-1175
>
>
> Repository: bigtop
>
>
> Description
> -------
>
> See JIRA
>
>
> Diffs
> -----
>
> bigtop-packages/src/common/accumulo/accumulo-gc.svc PRE-CREATION
> bigtop-packages/src/common/accumulo/accumulo-master.svc PRE-CREATION
> bigtop-packages/src/common/accumulo/accumulo-monitor.svc PRE-CREATION
> bigtop-packages/src/common/accumulo/accumulo-tracer.svc PRE-CREATION
> bigtop-packages/src/common/accumulo/accumulo-tserver.svc PRE-CREATION
> bigtop-packages/src/common/accumulo/conf/accumulo-env.sh PRE-CREATION
> bigtop-packages/src/common/accumulo/conf/accumulo-metrics.xml PRE-CREATION
> bigtop-packages/src/common/accumulo/conf/accumulo-site.xml PRE-CREATION
> bigtop-packages/src/common/accumulo/conf/generic_logger.xml PRE-CREATION
> bigtop-packages/src/common/accumulo/conf/log4j.properties PRE-CREATION
> bigtop-packages/src/common/accumulo/conf/monitor_logger.xml PRE-CREATION
> bigtop-packages/src/common/accumulo/do-component-build PRE-CREATION
> bigtop-packages/src/common/accumulo/install_accumulo.sh PRE-CREATION
> bigtop-packages/src/common/hadoop/init-hcfs.json d8825aa33839b88d09ee928e0be83c46e88a2992
> bigtop-packages/src/common/hadoop/init-hdfs.sh 3a5fe361dd56308f465a52214835a42900a618cd
> bigtop-packages/src/deb/accumulo/accumulo-doc.install PRE-CREATION
> bigtop-packages/src/deb/accumulo/accumulo.install PRE-CREATION
> bigtop-packages/src/deb/accumulo/accumulo.postinst PRE-CREATION
> bigtop-packages/src/deb/accumulo/accumulo.preinst PRE-CREATION
> bigtop-packages/src/deb/accumulo/accumulo.prerm PRE-CREATION
> bigtop-packages/src/deb/accumulo/compat PRE-CREATION
> bigtop-packages/src/deb/accumulo/control PRE-CREATION
> bigtop-packages/src/deb/accumulo/copyright PRE-CREATION
> bigtop-packages/src/deb/accumulo/install_init_scripts.sh PRE-CREATION
> bigtop-packages/src/deb/accumulo/rules PRE-CREATION
> bigtop-packages/src/deb/accumulo/service-postinst.tpl PRE-CREATION
> bigtop-packages/src/deb/accumulo/service-postrm.tpl PRE-CREATION
> bigtop-packages/src/deb/accumulo/source/format PRE-CREATION
> bigtop-packages/src/rpm/accumulo/RPMS/.gitignore PRE-CREATION
> bigtop-packages/src/rpm/accumulo/SOURCES/.gitignore PRE-CREATION
> bigtop-packages/src/rpm/accumulo/SPECS/.gitignore PRE-CREATION
> bigtop-packages/src/rpm/accumulo/SPECS/accumulo.spec PRE-CREATION
> bigtop-packages/src/rpm/accumulo/SRPMS/.gitignore PRE-CREATION
> bigtop-packages/src/templates/init.d.tmpl 57923240c2402c66b758790fcd8522186827f836
> bigtop.mk 672562a5d60b1043c7495183c8a5c4bcc571c960
>
> Diff: https://reviews.apache.org/r/21293/diff/
>
>
> Testing
> -------
>
> See JIRA
>
>
> Thanks,
>
> Sean Mackrory
>
>
Re: Review Request 21293: Adding Apache Accumulo to Apache Bigtop
Posted by Josh Elser <jo...@gmail.com>.
> On June 24, 2014, 4:09 a.m., Josh Elser wrote:
> > bigtop-packages/src/common/accumulo/accumulo-master.svc, line 42
> > <https://reviews.apache.org/r/21293/diff/1/?file=577859#file577859line42>
> >
> > This is doing some unexpected output echo (note the password not being hidden):
> >
> > <snip>
> > Instance name : accumulo-bigtop
> > accumulo-bigtop
> > Enter initial password for root (this may not be applicable for your security setup): password
> > ********
> > Confirm initial password for root: password
> > ********
> > </snip>
> >
> > I should get the text that appears on the newline to the right of the prompt.
> >
> > Changing this line to `sudo -u $SVC_USER ${EXEC_PATH} init` makes the command operate as expected. I don't quite understand why, but it appears that something with the su is messing things up with the shell output.
> >
>
> Sean Mackrory wrote:
> That makes sense - I had wondered about that because IIRC it's like that on Debian, but it works on Red Hat, so I had put it down to perhaps some difference in LSB init functions or something. Will change...
>
> Sean Mackrory wrote:
> One other issue here is that I know we've avoided using sudo in the past because not all Linux systems have it, and we didn't want to require it. I'll do a bit of digging and see if there's a way to make it work with su.
Yup, that's a valid concern. I didn't entire understand what was going on. The `sudo` variant was just enough to keep me going to verify functionality :)
- Josh
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21293/#review46491
-----------------------------------------------------------
On May 9, 2014, 11:31 p.m., Sean Mackrory wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21293/
> -----------------------------------------------------------
>
> (Updated May 9, 2014, 11:31 p.m.)
>
>
> Review request for bigtop.
>
>
> Bugs: BIGTOP-1175
> https://issues.apache.org/jira/browse/BIGTOP-1175
>
>
> Repository: bigtop
>
>
> Description
> -------
>
> See JIRA
>
>
> Diffs
> -----
>
> bigtop-packages/src/common/accumulo/accumulo-gc.svc PRE-CREATION
> bigtop-packages/src/common/accumulo/accumulo-master.svc PRE-CREATION
> bigtop-packages/src/common/accumulo/accumulo-monitor.svc PRE-CREATION
> bigtop-packages/src/common/accumulo/accumulo-tracer.svc PRE-CREATION
> bigtop-packages/src/common/accumulo/accumulo-tserver.svc PRE-CREATION
> bigtop-packages/src/common/accumulo/conf/accumulo-env.sh PRE-CREATION
> bigtop-packages/src/common/accumulo/conf/accumulo-metrics.xml PRE-CREATION
> bigtop-packages/src/common/accumulo/conf/accumulo-site.xml PRE-CREATION
> bigtop-packages/src/common/accumulo/conf/generic_logger.xml PRE-CREATION
> bigtop-packages/src/common/accumulo/conf/log4j.properties PRE-CREATION
> bigtop-packages/src/common/accumulo/conf/monitor_logger.xml PRE-CREATION
> bigtop-packages/src/common/accumulo/do-component-build PRE-CREATION
> bigtop-packages/src/common/accumulo/install_accumulo.sh PRE-CREATION
> bigtop-packages/src/common/hadoop/init-hcfs.json d8825aa33839b88d09ee928e0be83c46e88a2992
> bigtop-packages/src/common/hadoop/init-hdfs.sh 3a5fe361dd56308f465a52214835a42900a618cd
> bigtop-packages/src/deb/accumulo/accumulo-doc.install PRE-CREATION
> bigtop-packages/src/deb/accumulo/accumulo.install PRE-CREATION
> bigtop-packages/src/deb/accumulo/accumulo.postinst PRE-CREATION
> bigtop-packages/src/deb/accumulo/accumulo.preinst PRE-CREATION
> bigtop-packages/src/deb/accumulo/accumulo.prerm PRE-CREATION
> bigtop-packages/src/deb/accumulo/compat PRE-CREATION
> bigtop-packages/src/deb/accumulo/control PRE-CREATION
> bigtop-packages/src/deb/accumulo/copyright PRE-CREATION
> bigtop-packages/src/deb/accumulo/install_init_scripts.sh PRE-CREATION
> bigtop-packages/src/deb/accumulo/rules PRE-CREATION
> bigtop-packages/src/deb/accumulo/service-postinst.tpl PRE-CREATION
> bigtop-packages/src/deb/accumulo/service-postrm.tpl PRE-CREATION
> bigtop-packages/src/deb/accumulo/source/format PRE-CREATION
> bigtop-packages/src/rpm/accumulo/RPMS/.gitignore PRE-CREATION
> bigtop-packages/src/rpm/accumulo/SOURCES/.gitignore PRE-CREATION
> bigtop-packages/src/rpm/accumulo/SPECS/.gitignore PRE-CREATION
> bigtop-packages/src/rpm/accumulo/SPECS/accumulo.spec PRE-CREATION
> bigtop-packages/src/rpm/accumulo/SRPMS/.gitignore PRE-CREATION
> bigtop-packages/src/templates/init.d.tmpl 57923240c2402c66b758790fcd8522186827f836
> bigtop.mk 672562a5d60b1043c7495183c8a5c4bcc571c960
>
> Diff: https://reviews.apache.org/r/21293/diff/
>
>
> Testing
> -------
>
> See JIRA
>
>
> Thanks,
>
> Sean Mackrory
>
>
Re: Review Request 21293: Adding Apache Accumulo to Apache Bigtop
Posted by Josh Elser <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21293/#review46491
-----------------------------------------------------------
I pulled down your patch and applied it against master to do some testing. I had to make a few fixes (noted here) to get it working, but it seems solid otherwise!
bigtop-packages/src/common/accumulo/accumulo-master.svc
<https://reviews.apache.org/r/21293/#comment81879>
This is doing some unexpected output echo (note the password not being hidden):
<snip>
Instance name : accumulo-bigtop
accumulo-bigtop
Enter initial password for root (this may not be applicable for your security setup): password
********
Confirm initial password for root: password
********
</snip>
I should get the text that appears on the newline to the right of the prompt.
Changing this line to `sudo -u $SVC_USER ${EXEC_PATH} init` makes the command operate as expected. I don't quite understand why, but it appears that something with the su is messing things up with the shell output.
bigtop-packages/src/common/accumulo/conf/accumulo-site.xml
<https://reviews.apache.org/r/21293/#comment81880>
Either the HADOOP_CLIENT_HOME or HADOOP_PREFIX/lib entries need to exclude slf4j. Currently, you get a warning about multiple slf4j bindings.
It doesn't matter which you change, but to make it easy, I changed the second to:
$HADOOP_PREFIX/lib/(?!slf4j)[^.].*.jar
- Josh Elser
On May 9, 2014, 11:31 p.m., Sean Mackrory wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21293/
> -----------------------------------------------------------
>
> (Updated May 9, 2014, 11:31 p.m.)
>
>
> Review request for bigtop.
>
>
> Bugs: BIGTOP-1175
> https://issues.apache.org/jira/browse/BIGTOP-1175
>
>
> Repository: bigtop
>
>
> Description
> -------
>
> See JIRA
>
>
> Diffs
> -----
>
> bigtop-packages/src/common/accumulo/accumulo-gc.svc PRE-CREATION
> bigtop-packages/src/common/accumulo/accumulo-master.svc PRE-CREATION
> bigtop-packages/src/common/accumulo/accumulo-monitor.svc PRE-CREATION
> bigtop-packages/src/common/accumulo/accumulo-tracer.svc PRE-CREATION
> bigtop-packages/src/common/accumulo/accumulo-tserver.svc PRE-CREATION
> bigtop-packages/src/common/accumulo/conf/accumulo-env.sh PRE-CREATION
> bigtop-packages/src/common/accumulo/conf/accumulo-metrics.xml PRE-CREATION
> bigtop-packages/src/common/accumulo/conf/accumulo-site.xml PRE-CREATION
> bigtop-packages/src/common/accumulo/conf/generic_logger.xml PRE-CREATION
> bigtop-packages/src/common/accumulo/conf/log4j.properties PRE-CREATION
> bigtop-packages/src/common/accumulo/conf/monitor_logger.xml PRE-CREATION
> bigtop-packages/src/common/accumulo/do-component-build PRE-CREATION
> bigtop-packages/src/common/accumulo/install_accumulo.sh PRE-CREATION
> bigtop-packages/src/common/hadoop/init-hcfs.json d8825aa33839b88d09ee928e0be83c46e88a2992
> bigtop-packages/src/common/hadoop/init-hdfs.sh 3a5fe361dd56308f465a52214835a42900a618cd
> bigtop-packages/src/deb/accumulo/accumulo-doc.install PRE-CREATION
> bigtop-packages/src/deb/accumulo/accumulo.install PRE-CREATION
> bigtop-packages/src/deb/accumulo/accumulo.postinst PRE-CREATION
> bigtop-packages/src/deb/accumulo/accumulo.preinst PRE-CREATION
> bigtop-packages/src/deb/accumulo/accumulo.prerm PRE-CREATION
> bigtop-packages/src/deb/accumulo/compat PRE-CREATION
> bigtop-packages/src/deb/accumulo/control PRE-CREATION
> bigtop-packages/src/deb/accumulo/copyright PRE-CREATION
> bigtop-packages/src/deb/accumulo/install_init_scripts.sh PRE-CREATION
> bigtop-packages/src/deb/accumulo/rules PRE-CREATION
> bigtop-packages/src/deb/accumulo/service-postinst.tpl PRE-CREATION
> bigtop-packages/src/deb/accumulo/service-postrm.tpl PRE-CREATION
> bigtop-packages/src/deb/accumulo/source/format PRE-CREATION
> bigtop-packages/src/rpm/accumulo/RPMS/.gitignore PRE-CREATION
> bigtop-packages/src/rpm/accumulo/SOURCES/.gitignore PRE-CREATION
> bigtop-packages/src/rpm/accumulo/SPECS/.gitignore PRE-CREATION
> bigtop-packages/src/rpm/accumulo/SPECS/accumulo.spec PRE-CREATION
> bigtop-packages/src/rpm/accumulo/SRPMS/.gitignore PRE-CREATION
> bigtop-packages/src/templates/init.d.tmpl 57923240c2402c66b758790fcd8522186827f836
> bigtop.mk 672562a5d60b1043c7495183c8a5c4bcc571c960
>
> Diff: https://reviews.apache.org/r/21293/diff/
>
>
> Testing
> -------
>
> See JIRA
>
>
> Thanks,
>
> Sean Mackrory
>
>
Re: Review Request 21293: Adding Apache Accumulo to Apache Bigtop
Posted by Jay Vyas <ja...@gmail.com>.
Hi shawn:
I know your excited about getting this in so... given that I cant review
this stuff yet all by myself because it willtake me a very long time to
grasp everything,
if you have the spare time i can review it together with you in a g+
hangout possibly given how big the patch is. just let me know, im available
today
On Fri, May 9, 2014 at 7:31 PM, Sean Mackrory <ma...@gmail.com> wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21293/
> -----------------------------------------------------------
>
> Review request for bigtop.
>
>
> Bugs: BIGTOP-1175
> https://issues.apache.org/jira/browse/BIGTOP-1175
>
>
> Repository: bigtop
>
>
> Description
> -------
>
> See JIRA
>
>
> Diffs
> -----
>
> bigtop-packages/src/common/accumulo/accumulo-gc.svc PRE-CREATION
> bigtop-packages/src/common/accumulo/accumulo-master.svc PRE-CREATION
> bigtop-packages/src/common/accumulo/accumulo-monitor.svc PRE-CREATION
> bigtop-packages/src/common/accumulo/accumulo-tracer.svc PRE-CREATION
> bigtop-packages/src/common/accumulo/accumulo-tserver.svc PRE-CREATION
> bigtop-packages/src/common/accumulo/conf/accumulo-env.sh PRE-CREATION
> bigtop-packages/src/common/accumulo/conf/accumulo-metrics.xml
> PRE-CREATION
> bigtop-packages/src/common/accumulo/conf/accumulo-site.xml PRE-CREATION
> bigtop-packages/src/common/accumulo/conf/generic_logger.xml PRE-CREATION
> bigtop-packages/src/common/accumulo/conf/log4j.properties PRE-CREATION
> bigtop-packages/src/common/accumulo/conf/monitor_logger.xml PRE-CREATION
> bigtop-packages/src/common/accumulo/do-component-build PRE-CREATION
> bigtop-packages/src/common/accumulo/install_accumulo.sh PRE-CREATION
> bigtop-packages/src/common/hadoop/init-hcfs.json
> d8825aa33839b88d09ee928e0be83c46e88a2992
> bigtop-packages/src/common/hadoop/init-hdfs.sh
> 3a5fe361dd56308f465a52214835a42900a618cd
> bigtop-packages/src/deb/accumulo/accumulo-doc.install PRE-CREATION
> bigtop-packages/src/deb/accumulo/accumulo.install PRE-CREATION
> bigtop-packages/src/deb/accumulo/accumulo.postinst PRE-CREATION
> bigtop-packages/src/deb/accumulo/accumulo.preinst PRE-CREATION
> bigtop-packages/src/deb/accumulo/accumulo.prerm PRE-CREATION
> bigtop-packages/src/deb/accumulo/compat PRE-CREATION
> bigtop-packages/src/deb/accumulo/control PRE-CREATION
> bigtop-packages/src/deb/accumulo/copyright PRE-CREATION
> bigtop-packages/src/deb/accumulo/install_init_scripts.sh PRE-CREATION
> bigtop-packages/src/deb/accumulo/rules PRE-CREATION
> bigtop-packages/src/deb/accumulo/service-postinst.tpl PRE-CREATION
> bigtop-packages/src/deb/accumulo/service-postrm.tpl PRE-CREATION
> bigtop-packages/src/deb/accumulo/source/format PRE-CREATION
> bigtop-packages/src/rpm/accumulo/RPMS/.gitignore PRE-CREATION
> bigtop-packages/src/rpm/accumulo/SOURCES/.gitignore PRE-CREATION
> bigtop-packages/src/rpm/accumulo/SPECS/.gitignore PRE-CREATION
> bigtop-packages/src/rpm/accumulo/SPECS/accumulo.spec PRE-CREATION
> bigtop-packages/src/rpm/accumulo/SRPMS/.gitignore PRE-CREATION
> bigtop-packages/src/templates/init.d.tmpl
> 57923240c2402c66b758790fcd8522186827f836
> bigtop.mk 672562a5d60b1043c7495183c8a5c4bcc571c960
>
> Diff: https://reviews.apache.org/r/21293/diff/
>
>
> Testing
> -------
>
> See JIRA
>
>
> Thanks,
>
> Sean Mackrory
>
>
--
Jay Vyas
http://jayunit100.blogspot.com