You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "raulcd (via GitHub)" <gi...@apache.org> on 2024/04/19 08:12:17 UTC
[PR] GH-41282: [Dev] Always prompt next major version on merge script if it exists [arrow]
raulcd opened a new pull request, #41305:
URL: https://github.com/apache/arrow/pull/41305
### Rationale for this change
When we created the `16.1.0` milestone the merge script started prompting it instead of `17.0.0` we want to default to the next major release.
### What changes are included in this PR?
Update archery logic to default to major versions online.
### Are these changes tested?
I've tested locally and now it defaults to `17.0.0`:
```
Enter fix version [17.0.0]:
```
### Are there any user-facing changes?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-41282: [Dev] Always prompt next major version on merge script if it exists [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #41305:
URL: https://github.com/apache/arrow/pull/41305#discussion_r1573566641
##########
dev/merge_arrow_pr.py:
##########
@@ -306,15 +306,15 @@ def version_tuple(x):
# Only suggest versions starting with a number, like 0.x but not JS-0.x
mainline_versions = all_versions
- mainline_non_patch_versions = []
+ major_versions = []
Review Comment:
How about using `endswith`?
```python
major_versions = [v for v in ['1.2.3', '16.1.0', '17.0.0'] if v.endswith('.0.0')]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-41282: [Dev] Always prompt next major version on merge script if it exists [arrow]
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #41305:
URL: https://github.com/apache/arrow/pull/41305#issuecomment-2079780742
After merging your PR, Conbench analyzed the 7 benchmarking runs that have been run so far on merge-commit 6cbdec55b6bbaee3f00a42541bf89998452a3718.
There were no benchmark performance regressions. 🎉
The [full Conbench report](https://github.com/apache/arrow/runs/24309396491) has more details. It also includes information about 19 possible false positives for unstable benchmarks that are known to sometimes produce them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-41282: [Dev] Always prompt next major version on merge script if it exists [arrow]
Posted by "raulcd (via GitHub)" <gi...@apache.org>.
raulcd merged PR #41305:
URL: https://github.com/apache/arrow/pull/41305
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-41282: [Dev] Always prompt next major version on merge script if it exists [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #41305:
URL: https://github.com/apache/arrow/pull/41305#issuecomment-2066062827
:warning: GitHub issue #41282 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org