You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "pprovenzano (via GitHub)" <gi...@apache.org> on 2023/04/11 12:58:18 UTC

[GitHub] [kafka] pprovenzano commented on a diff in pull request #13513: KAFKA-14881: Update UserScramCredentialRecord for SCRAM ZK to KRaft migration

pprovenzano commented on code in PR #13513:
URL: https://github.com/apache/kafka/pull/13513#discussion_r1162780060


##########
metadata/src/main/java/org/apache/kafka/metadata/migration/KRaftMigrationDriver.java:
##########
@@ -458,8 +458,9 @@ public void run() throws Exception {
                 zkMigrationClient.readAllMetadata(batch -> {
                     try {
                         if (log.isTraceEnabled()) {
-                            log.trace("Migrating {} records from ZK: {}", batch.size(), recordBatchToString(batch));
+                            log.info("Migrating {} records from ZK: {}", batch.size(), recordBatchToString(batch));
                         } else {
+                            log.info("Migrating {} records from ZK: {}", batch.size(), recordBatchToString(batch));

Review Comment:
   This file shouldn't have been part of this commit at all. Thanks for catching this.



##########
metadata/src/main/java/org/apache/kafka/metadata/migration/KRaftMigrationDriver.java:
##########
@@ -458,8 +458,9 @@ public void run() throws Exception {
                 zkMigrationClient.readAllMetadata(batch -> {
                     try {
                         if (log.isTraceEnabled()) {
-                            log.trace("Migrating {} records from ZK: {}", batch.size(), recordBatchToString(batch));
+                            log.info("Migrating {} records from ZK: {}", batch.size(), recordBatchToString(batch));

Review Comment:
   This file shouldn't have been part of this commit at all. Thanks for catching this.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org