You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by xubo245 <gi...@git.apache.org> on 2018/03/19 12:02:05 UTC
[GitHub] carbondata pull request #2078: [WIP][CARBONDATA-2262] Support the syntax of ...
GitHub user xubo245 opened a pull request:
https://github.com/apache/carbondata/pull/2078
[WIP][CARBONDATA-2262] Support the syntax of 'STORED AS CARBONDATA' to create table
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
- [ ] Any interfaces changed?
- [ ] Any backward compatibility impacted?
- [ ] Document update required?
- [ ] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance test report.
- Any additional information to help reviewers in testing this change.
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/xubo245/carbondata CARBONDATA-2262UsingAndStoredAs
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/carbondata/pull/2078.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2078
----
commit cfdba6d34a97edc3228afd9e9deb12d3c742e2f1
Author: root <60...@...>
Date: 2018-03-19T11:59:26Z
[CARBONDATA-2262] Support the syntax of 'STORED AS CARBONDATA' to create table
----
---
[GitHub] carbondata issue #2078: [CARBONDATA-2262] Support the syntax of 'STORED AS C...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2078
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4452/
---
[GitHub] carbondata issue #2078: [CARBONDATA-2262] Support the syntax of 'STORED AS C...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2078
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4504/
---
[GitHub] carbondata issue #2078: [CARBONDATA-2262] Support the syntax of 'STORED AS C...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2078
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3299/
---
[GitHub] carbondata issue #2078: [CARBONDATA-2262] Support the syntax of 'STORED AS C...
Posted by xubo245 <gi...@git.apache.org>.
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/2078
retest this please
---
[GitHub] carbondata issue #2078: [CARBONDATA-2262] Support the syntax of 'STORED AS C...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2078
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4018/
---
[GitHub] carbondata pull request #2078: [CARBONDATA-2262] Support the syntax of 'STOR...
Posted by jackylk <gi...@git.apache.org>.
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2078#discussion_r176048872
--- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/parser/CarbonSparkSqlParser.scala ---
@@ -91,6 +91,9 @@ class CarbonHelperSqlAstBuilder(conf: SQLConf,
case Some(value) =>
if (value.children.get(1).getText.equalsIgnoreCase("by")) {
value.storageHandler().STRING().getSymbol.getText
+ } else if (value.children.get(1).getText.equalsIgnoreCase("as")
--- End diff --
can you call `value.children.get(1).getText` once and use the result
---
[GitHub] carbondata issue #2078: [CARBONDATA-2262] Support the syntax of 'STORED AS C...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2078
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3216/
---
[GitHub] carbondata pull request #2078: [CARBONDATA-2262] Support the syntax of 'STOR...
Posted by jackylk <gi...@git.apache.org>.
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2078#discussion_r176049346
--- Diff: integration/spark2/src/main/spark2.1/org/apache/spark/sql/hive/CarbonSessionState.scala ---
@@ -326,7 +326,8 @@ class CarbonSqlAstBuilder(conf: SQLConf, parser: CarbonSpark2SqlParser, sparkSes
val fileStorage = helper.getFileStorage(ctx.createFileFormat)
if (fileStorage.equalsIgnoreCase("'carbondata'") ||
- fileStorage.equalsIgnoreCase("'org.apache.carbondata.format'")) {
+ fileStorage.equalsIgnoreCase("carbondata") ||
--- End diff --
incorrect identation
---
[GitHub] carbondata issue #2078: [WIP][CARBONDATA-2262] Support the syntax of 'STORED...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2078
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3948/
---
[GitHub] carbondata issue #2078: [CARBONDATA-2262] Support the syntax of 'STORED AS C...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2078
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3275/
---
[GitHub] carbondata issue #2078: [CARBONDATA-2262] Support the syntax of 'STORED AS C...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2078
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4079/
---
[GitHub] carbondata issue #2078: [CARBONDATA-2262] Support the syntax of 'STORED AS C...
Posted by xubo245 <gi...@git.apache.org>.
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/2078
retest sdv please
---
[GitHub] carbondata issue #2078: [CARBONDATA-2262] Support the syntax of 'STORED AS C...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2078
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4016/
---
[GitHub] carbondata issue #2078: [CARBONDATA-2262] Support the syntax of 'STORED AS C...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2078
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3202/
---
[GitHub] carbondata issue #2078: [CARBONDATA-2262] Support the syntax of 'STORED AS C...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2078
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4492/
---
[GitHub] carbondata pull request #2078: [CARBONDATA-2262] Support the syntax of 'STOR...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/carbondata/pull/2078
---
[GitHub] carbondata issue #2078: [CARBONDATA-2262] Support the syntax of 'STORED AS C...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2078
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4583/
---
[GitHub] carbondata issue #2078: [CARBONDATA-2262] Support the syntax of 'STORED AS C...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2078
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3263/
---
[GitHub] carbondata pull request #2078: [CARBONDATA-2262] Support the syntax of 'STOR...
Posted by jackylk <gi...@git.apache.org>.
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2078#discussion_r176049956
--- Diff: integration/spark2/src/test/scala/org/apache/spark/SparkCommandSuite.scala ---
@@ -35,4 +35,22 @@ class SparkCommandSuite extends Spark2QueryTest with BeforeAndAfterAll {
sql("CREATE TABLE src_pqt(key INT, value STRING) STORED AS PARQUET")
sql("CREATE TABLE src_orc(key INT, value STRING) STORED AS ORC")
}
+
+ test("CARBONDATA-734: Don't Support the syntax of 'STORED BY 'PARQUET''") {
+ try {
+ sql("CREATE TABLE src_pqt(key INT, value STRING) STORED AS 'PARQUET'")
--- End diff --
This is not correct, stored as parquet or orc should be supported
---
[GitHub] carbondata issue #2078: [CARBONDATA-2262] Support the syntax of 'STORED AS C...
Posted by xubo245 <gi...@git.apache.org>.
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/2078
retest this please
---
[GitHub] carbondata pull request #2078: [CARBONDATA-2262] Support the syntax of 'STOR...
Posted by xubo245 <gi...@git.apache.org>.
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2078#discussion_r176286029
--- Diff: integration/spark2/src/main/spark2.2/org/apache/spark/sql/hive/CarbonSessionState.scala ---
@@ -325,7 +325,8 @@ class CarbonSqlAstBuilder(conf: SQLConf, parser: CarbonSpark2SqlParser, sparkSes
val fileStorage = helper.getFileStorage(ctx.createFileFormat)
if (fileStorage.equalsIgnoreCase("'carbondata'") ||
- fileStorage.equalsIgnoreCase("'org.apache.carbondata.format'")) {
+ fileStorage.equalsIgnoreCase("carbondata") ||
--- End diff --
It's different: 'carbondata' and carbondata.
---
[GitHub] carbondata issue #2078: [CARBONDATA-2262] Support the syntax of 'STORED AS C...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2078
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3282/
---
[GitHub] carbondata issue #2078: [CARBONDATA-2262] Support the syntax of 'STORED AS C...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2078
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4081/
---
[GitHub] carbondata pull request #2078: [CARBONDATA-2262] Support the syntax of 'STOR...
Posted by jackylk <gi...@git.apache.org>.
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2078#discussion_r176719499
--- Diff: integration/spark2/src/main/spark2.1/org/apache/spark/sql/hive/CarbonSessionState.scala ---
@@ -326,7 +326,8 @@ class CarbonSqlAstBuilder(conf: SQLConf, parser: CarbonSpark2SqlParser, sparkSes
val fileStorage = helper.getFileStorage(ctx.createFileFormat)
if (fileStorage.equalsIgnoreCase("'carbondata'") ||
- fileStorage.equalsIgnoreCase("'org.apache.carbondata.format'")) {
+ fileStorage.equalsIgnoreCase("carbondata") ||
--- End diff --
`stored by carbondata` is not required
---
[GitHub] carbondata issue #2078: [CARBONDATA-2262] Support the syntax of 'STORED AS C...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2078
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4004/
---
[GitHub] carbondata issue #2078: [WIP][CARBONDATA-2262] Support the syntax of 'STORED...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2078
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4427/
---
[GitHub] carbondata issue #2078: [CARBONDATA-2262] Support the syntax of 'STORED AS C...
Posted by xubo245 <gi...@git.apache.org>.
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/2078
retest sdv please
---
[GitHub] carbondata issue #2078: [CARBONDATA-2262] Support the syntax of 'STORED AS C...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2078
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4435/
---
[GitHub] carbondata issue #2078: [CARBONDATA-2262] Support the syntax of 'STORED AS C...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2078
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3956/
---
[GitHub] carbondata pull request #2078: [CARBONDATA-2262] Support the syntax of 'STOR...
Posted by xubo245 <gi...@git.apache.org>.
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2078#discussion_r176286684
--- Diff: integration/spark2/src/test/scala/org/apache/spark/SparkCommandSuite.scala ---
@@ -35,4 +35,22 @@ class SparkCommandSuite extends Spark2QueryTest with BeforeAndAfterAll {
sql("CREATE TABLE src_pqt(key INT, value STRING) STORED AS PARQUET")
sql("CREATE TABLE src_orc(key INT, value STRING) STORED AS ORC")
}
+
+ test("CARBONDATA-734: Don't Support the syntax of 'STORED BY 'PARQUET''") {
+ try {
+ sql("CREATE TABLE src_pqt(key INT, value STRING) STORED AS 'PARQUET'")
--- End diff --
Now carbon support syntax "stored as parquet" but don't support syntax "stored as 'parquet'".
Whether do we support syntax "stored as 'parquet'"?
---
[GitHub] carbondata issue #2078: [CARBONDATA-2262] Support the syntax of 'STORED AS C...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2078
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4449/
---
[GitHub] carbondata issue #2078: [CARBONDATA-2262] Support the syntax of 'STORED AS C...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2078
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3219/
---
[GitHub] carbondata issue #2078: [CARBONDATA-2262] Support the syntax of 'STORED AS C...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2078
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3285/
---
[GitHub] carbondata issue #2078: [CARBONDATA-2262] Support the syntax of 'STORED AS C...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2078
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3357/
---
[GitHub] carbondata issue #2078: [CARBONDATA-2262] Support the syntax of 'STORED AS C...
Posted by xubo245 <gi...@git.apache.org>.
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/2078
retest this please
---
[GitHub] carbondata issue #2078: [CARBONDATA-2262] Support the syntax of 'STORED AS C...
Posted by xubo245 <gi...@git.apache.org>.
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/2078
retest this please
---
[GitHub] carbondata pull request #2078: [CARBONDATA-2262] Support the syntax of 'STOR...
Posted by xubo245 <gi...@git.apache.org>.
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2078#discussion_r176286537
--- Diff: integration/spark2/src/main/spark2.1/org/apache/spark/sql/hive/CarbonSessionState.scala ---
@@ -326,7 +326,8 @@ class CarbonSqlAstBuilder(conf: SQLConf, parser: CarbonSpark2SqlParser, sparkSes
val fileStorage = helper.getFileStorage(ctx.createFileFormat)
if (fileStorage.equalsIgnoreCase("'carbondata'") ||
- fileStorage.equalsIgnoreCase("'org.apache.carbondata.format'")) {
+ fileStorage.equalsIgnoreCase("carbondata") ||
--- End diff --
It's different: 'carbondata' and carbondata.
carbon supported syntax "stored by 'carbondata'" before, but didn't supported syntax "stored by carbondata".
we need support syntax "STORED AS carbondata" like "STORED AS parquet"
---
[GitHub] carbondata issue #2078: [CARBONDATA-2262] Support the syntax of 'STORED AS C...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2078
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4439/
---
[GitHub] carbondata pull request #2078: [CARBONDATA-2262] Support the syntax of 'STOR...
Posted by xubo245 <gi...@git.apache.org>.
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2078#discussion_r176288720
--- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/parser/CarbonSparkSqlParser.scala ---
@@ -91,6 +91,9 @@ class CarbonHelperSqlAstBuilder(conf: SQLConf,
case Some(value) =>
if (value.children.get(1).getText.equalsIgnoreCase("by")) {
value.storageHandler().STRING().getSymbol.getText
+ } else if (value.children.get(1).getText.equalsIgnoreCase("as")
--- End diff --
ok, done
---
[GitHub] carbondata issue #2078: [CARBONDATA-2262] Support the syntax of 'STORED AS C...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2078
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4027/
---
[GitHub] carbondata issue #2078: [CARBONDATA-2262] Support the syntax of 'STORED AS C...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2078
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4527/
---
[GitHub] carbondata issue #2078: [CARBONDATA-2262] Support the syntax of 'STORED AS C...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2078
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3206/
---
[GitHub] carbondata issue #2078: [CARBONDATA-2262] Support the syntax of 'STORED AS C...
Posted by jackylk <gi...@git.apache.org>.
Github user jackylk commented on the issue:
https://github.com/apache/carbondata/pull/2078
LGTM
---
[GitHub] carbondata issue #2078: [CARBONDATA-2262] Support the syntax of 'STORED AS C...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2078
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4510/
---
[GitHub] carbondata issue #2078: [CARBONDATA-2262] Support the syntax of 'STORED AS C...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2078
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3961/
---
[GitHub] carbondata pull request #2078: [CARBONDATA-2262] Support the syntax of 'STOR...
Posted by jackylk <gi...@git.apache.org>.
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2078#discussion_r176049685
--- Diff: integration/spark2/src/main/spark2.1/org/apache/spark/sql/hive/CarbonSessionState.scala ---
@@ -326,7 +326,8 @@ class CarbonSqlAstBuilder(conf: SQLConf, parser: CarbonSpark2SqlParser, sparkSes
val fileStorage = helper.getFileStorage(ctx.createFileFormat)
if (fileStorage.equalsIgnoreCase("'carbondata'") ||
- fileStorage.equalsIgnoreCase("'org.apache.carbondata.format'")) {
+ fileStorage.equalsIgnoreCase("carbondata") ||
--- End diff --
line 329 is repeated
---
[GitHub] carbondata issue #2078: [CARBONDATA-2262] Support the syntax of 'STORED AS C...
Posted by xubo245 <gi...@git.apache.org>.
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/2078
@jackylk Please review it.
---
[GitHub] carbondata issue #2078: [CARBONDATA-2262] Support the syntax of 'STORED AS C...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2078
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3968/
---
[GitHub] carbondata issue #2078: [CARBONDATA-2262] Support the syntax of 'STORED AS C...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2078
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3970/
---
[GitHub] carbondata issue #2078: [WIP][CARBONDATA-2262] Support the syntax of 'STORED...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2078
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3193/
---
[GitHub] carbondata pull request #2078: [CARBONDATA-2262] Support the syntax of 'STOR...
Posted by jackylk <gi...@git.apache.org>.
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2078#discussion_r176049748
--- Diff: integration/spark2/src/main/spark2.2/org/apache/spark/sql/hive/CarbonSessionState.scala ---
@@ -325,7 +325,8 @@ class CarbonSqlAstBuilder(conf: SQLConf, parser: CarbonSpark2SqlParser, sparkSes
val fileStorage = helper.getFileStorage(ctx.createFileFormat)
if (fileStorage.equalsIgnoreCase("'carbondata'") ||
- fileStorage.equalsIgnoreCase("'org.apache.carbondata.format'")) {
+ fileStorage.equalsIgnoreCase("carbondata") ||
--- End diff --
repeated logic
---
[GitHub] carbondata issue #2078: [CARBONDATA-2262] Support the syntax of 'STORED AS C...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2078
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4513/
---
[GitHub] carbondata issue #2078: [CARBONDATA-2262] Support the syntax of 'STORED AS C...
Posted by xubo245 <gi...@git.apache.org>.
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/2078
retest sdv please
---