You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@impala.apache.org by jo...@apache.org on 2021/02/03 23:21:52 UTC

[impala] branch master updated (a81c6a7 -> 91fd8fd)

This is an automated email from the ASF dual-hosted git repository.

joemcdonnell pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/impala.git.


    from a81c6a7  IMPALA-10460: Impala should write normalized paths in Iceberg manifests
     new 1a38924  IMPALA-9588: Add extra logging to cancel tests
     new 91fd8fd  [config] bump toolchain build id

The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 bin/impala-config.sh      |  4 ++--
 tests/util/cancel_util.py | 13 ++++++++++++-
 2 files changed, 14 insertions(+), 3 deletions(-)


[impala] 01/02: IMPALA-9588: Add extra logging to cancel tests

Posted by jo...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

joemcdonnell pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/impala.git

commit 1a38924d20679ffeb4550766a30b3be56763dc71
Author: Gabor Kaszab <ga...@cloudera.com>
AuthorDate: Wed Jan 27 17:40:53 2021 +0100

    IMPALA-9588: Add extra logging to cancel tests
    
    There have been some cancel tests that are flaky and their logs didn't
    reveal the root cause of the failures. Adding some extra logging so
    that we can see a bit more of the nature of the failure.
    The extra log message contains:
      - Query SQL
      - Message of the exception thrown during fetching the results
      - Query Status line from the query profile
    
    Change-Id: Ied7100a9ea2e2f0611cf8e328e589b4c8e5d5100
    Reviewed-on: http://gerrit.cloudera.org:8080/16985
    Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
    Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
 tests/util/cancel_util.py | 13 ++++++++++++-
 1 file changed, 12 insertions(+), 1 deletion(-)

diff --git a/tests/util/cancel_util.py b/tests/util/cancel_util.py
index 520f958..7e7bf15 100644
--- a/tests/util/cancel_util.py
+++ b/tests/util/cancel_util.py
@@ -38,7 +38,18 @@ def cancel_query_and_validate_state(client, query, exec_option, table_format,
   thread.start()
 
   sleep(cancel_delay)
-  assert client.get_state(handle) != client.QUERY_STATES['EXCEPTION']
+  if client.get_state(handle) == client.QUERY_STATES['EXCEPTION']:
+      # If some error occurred before trying to cancel the query then we put an error
+      # message together and fail the test.
+      thread.join()
+      error_msg = "The following query returned an error: %s\n" % query
+      if thread.fetch_results_error is not None:
+          error_msg += str(thread.fetch_results_error) + "\n"
+      profile_lines = client.get_runtime_profile(handle).splitlines()
+      for line in profile_lines:
+          if "Query Status:" in line:
+              error_msg += line
+      assert False, error_msg
   cancel_result = client.cancel(handle)
   assert cancel_result.status_code == 0,\
       'Unexpected status code from cancel request: %s' % cancel_result


[impala] 02/02: [config] bump toolchain build id

Posted by jo...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

joemcdonnell pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/impala.git

commit 91fd8fd13075327d03a57bcfebfabec72388a357
Author: Alexey Serbin <as...@cloudera.com>
AuthorDate: Mon Feb 1 16:49:52 2021 -0800

    [config] bump toolchain build id
    
    The motivation for this version patch is two-fold:
    
      * Update the version of Kudu client to reflect the recently
        released Kudu 1.14 (see https://kudu.apache.org/releases/1.14.0/)
    
      * Pick up https://gerrit.cloudera.org/#/c/16705 change to control
        Kudu client connection negotiation timeout in impalad
    
    Change-Id: I20fd6b092ce6a04465624914f6116a33622e977e
    Reviewed-on: http://gerrit.cloudera.org:8080/17018
    Reviewed-by: Thomas Tauber-Marshall <tm...@cloudera.com>
    Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
 bin/impala-config.sh | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/bin/impala-config.sh b/bin/impala-config.sh
index d7baa31..d38770d 100755
--- a/bin/impala-config.sh
+++ b/bin/impala-config.sh
@@ -68,7 +68,7 @@ fi
 # moving to a different build of the toolchain, e.g. when a version is bumped or a
 # compile option is changed. The build id can be found in the output of the toolchain
 # build jobs, it is constructed from the build number and toolchain git hash prefix.
-export IMPALA_TOOLCHAIN_BUILD_ID=69-7644f7fe9c
+export IMPALA_TOOLCHAIN_BUILD_ID=75-4ad03513e3
 # Versions of toolchain dependencies.
 # -----------------------------------
 export IMPALA_AVRO_VERSION=1.7.4-p5
@@ -652,7 +652,7 @@ fi
 # overall build type) and does not apply when using a local Kudu build.
 export USE_KUDU_DEBUG_BUILD=${USE_KUDU_DEBUG_BUILD-false}
 
-export IMPALA_KUDU_VERSION=${IMPALA_KUDU_VERSION-"6a7cadc7e"}
+export IMPALA_KUDU_VERSION=${IMPALA_KUDU_VERSION-"b5e7362e69"}
 export IMPALA_KUDU_HOME=${IMPALA_TOOLCHAIN_PACKAGES_HOME}/kudu-$IMPALA_KUDU_VERSION
 export IMPALA_KUDU_JAVA_HOME=\
 ${IMPALA_TOOLCHAIN_PACKAGES_HOME}/kudu-${IMPALA_KUDU_VERSION}/java