You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/09/21 15:09:31 UTC
[GitHub] [spark] gengliangwang opened a new pull request #34059: [SPARK-36670][FOLLOWUP][TEST] Remove brotli-codec dependency
gengliangwang opened a new pull request #34059:
URL: https://github.com/apache/spark/pull/34059
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
Remove `com.github.rdblue:brotli-codec:0.1.1` dependency.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
As Stephen Coy pointed out in the dev list, we should not have `com.github.rdblue:brotli-codec:0.1.1` dependency which is not available on Maven Central. So that we can avoid possible artifact changes.
Also, the dependency is for tests only. I suggest that we remove it now to unblock the 3.2.0 release ASAP.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
GA tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34059: [SPARK-36670][FOLLOWUP][TEST] Remove brotli-codec dependency
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34059:
URL: https://github.com/apache/spark/pull/34059#issuecomment-924225988
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47989/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34059: [SPARK-36670][FOLLOWUP][TEST] Remove brotli-codec dependency
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34059:
URL: https://github.com/apache/spark/pull/34059#issuecomment-924178269
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/47986/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34059: [SPARK-36670][FOLLOWUP][TEST] Remove brotli-codec dependency
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34059:
URL: https://github.com/apache/spark/pull/34059#issuecomment-924083581
**[Test build #143475 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143475/testReport)** for PR 34059 at commit [`452340c`](https://github.com/apache/spark/commit/452340c4581e8fc33f219e1a14bd5f2ce4da4004).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34059: [SPARK-36670][FOLLOWUP][TEST] Remove brotli-codec dependency
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34059:
URL: https://github.com/apache/spark/pull/34059#issuecomment-924244803
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47990/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #34059: [SPARK-36670][FOLLOWUP][TEST] Remove brotli-codec dependency
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #34059:
URL: https://github.com/apache/spark/pull/34059#discussion_r713238592
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/FileSourceCodecSuite.scala
##########
@@ -56,6 +56,7 @@ class ParquetCodecSuite extends FileSourceCodecSuite {
override def format: String = "parquet"
override val codecConfigName: String = SQLConf.PARQUET_COMPRESSION.key
// Exclude "lzo" because it is GPL-licenced so not included in Hadoop.
+ // TODO: test "brotli" if the system is not of ARM64 CPU architecture.
Review comment:
Stephen casted -1
- https://lists.apache.org/thread.html/rb92464f98a2b15f2a66a7f2c6bea5f422eabfe00e4de0a17d4f0a20b%40%3Cdev.spark.apache.org%3E
> I was going to -1 this because of the com.github.rdblue:brotli-codec:0.1.1 dependency, which is not available on Maven Central, and therefore is not available from our repository manager (Nexus).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34059: [SPARK-36670][FOLLOWUP][TEST] Remove brotli-codec dependency
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34059:
URL: https://github.com/apache/spark/pull/34059#issuecomment-924339518
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143479/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #34059: [SPARK-36670][FOLLOWUP][TEST] Remove brotli-codec dependency
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #34059:
URL: https://github.com/apache/spark/pull/34059#discussion_r713237721
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/FileSourceCodecSuite.scala
##########
@@ -56,6 +56,7 @@ class ParquetCodecSuite extends FileSourceCodecSuite {
override def format: String = "parquet"
override val codecConfigName: String = SQLConf.PARQUET_COMPRESSION.key
// Exclude "lzo" because it is GPL-licenced so not included in Hadoop.
+ // TODO: test "brotli" if the system is not of ARM64 CPU architecture.
Review comment:
Ur, @gengliangwang . This is not a TODO item. I must be more clear. Like `lzo`, I expected our decision statement here why we exclude `brotli`. It's a kind of information not to add `brotli` back in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34059: [SPARK-36670][FOLLOWUP][TEST] Remove brotli-codec dependency
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34059:
URL: https://github.com/apache/spark/pull/34059#issuecomment-924297306
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/47989/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34059: [SPARK-36670][FOLLOWUP][TEST] Remove brotli-codec dependency
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34059:
URL: https://github.com/apache/spark/pull/34059#issuecomment-924297306
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/47989/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #34059: [SPARK-36670][FOLLOWUP][TEST] Remove brotli-codec dependency
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #34059:
URL: https://github.com/apache/spark/pull/34059#discussion_r713211475
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/FileSourceCodecSuite.scala
##########
@@ -57,12 +57,7 @@ class ParquetCodecSuite extends FileSourceCodecSuite {
override val codecConfigName: String = SQLConf.PARQUET_COMPRESSION.key
// Exclude "lzo" because it is GPL-licenced so not included in Hadoop.
override protected def availableCodecs: Seq[String] =
- if (System.getProperty("os.arch") == "aarch64") {
- // Exclude "brotli" due to PARQUET-1975.
- Seq("none", "uncompressed", "snappy", "lz4", "gzip", "zstd")
- } else {
- Seq("none", "uncompressed", "snappy", "lz4", "gzip", "brotli", "zstd")
- }
Review comment:
BTW, @gengliangwang . Could you add some comment? Otherwise, someone may want to try to re-add it in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34059: [SPARK-36670][FOLLOWUP][TEST] Remove brotli-codec dependency
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34059:
URL: https://github.com/apache/spark/pull/34059#issuecomment-924324901
**[Test build #143479 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143479/testReport)** for PR 34059 at commit [`eaeba81`](https://github.com/apache/spark/commit/eaeba81aa6a2895673b614c9aebf02bf79c4a66b).
* This patch **fails PySpark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34059: [SPARK-36670][FOLLOWUP][TEST] Remove brotli-codec dependency
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34059:
URL: https://github.com/apache/spark/pull/34059#issuecomment-924303372
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/47990/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34059: [SPARK-36670][FOLLOWUP][TEST] Remove brotli-codec dependency
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34059:
URL: https://github.com/apache/spark/pull/34059#issuecomment-924303344
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47990/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34059: [SPARK-36670][FOLLOWUP][TEST] Remove brotli-codec dependency
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34059:
URL: https://github.com/apache/spark/pull/34059#issuecomment-924298068
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143478/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34059: [SPARK-36670][FOLLOWUP][TEST] Remove brotli-codec dependency
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34059:
URL: https://github.com/apache/spark/pull/34059#issuecomment-924209652
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143475/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34059: [SPARK-36670][FOLLOWUP][TEST] Remove brotli-codec dependency
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34059:
URL: https://github.com/apache/spark/pull/34059#issuecomment-924178269
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/47986/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #34059: [SPARK-36670][FOLLOWUP][TEST] Remove brotli-codec dependency
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #34059:
URL: https://github.com/apache/spark/pull/34059#discussion_r713237721
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/FileSourceCodecSuite.scala
##########
@@ -56,6 +56,7 @@ class ParquetCodecSuite extends FileSourceCodecSuite {
override def format: String = "parquet"
override val codecConfigName: String = SQLConf.PARQUET_COMPRESSION.key
// Exclude "lzo" because it is GPL-licenced so not included in Hadoop.
+ // TODO: test "brotli" if the system is not of ARM64 CPU architecture.
Review comment:
Ur, @gengliangwang . This is not a TODO item. Like `lzo`, I expect our decision why we exclude `brotli` here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34059: [SPARK-36670][FOLLOWUP][TEST] Remove brotli-codec dependency
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34059:
URL: https://github.com/apache/spark/pull/34059#issuecomment-924209652
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143475/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34059: [SPARK-36670][FOLLOWUP][TEST] Remove brotli-codec dependency
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34059:
URL: https://github.com/apache/spark/pull/34059#issuecomment-924124884
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47986/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34059: [SPARK-36670][FOLLOWUP][TEST] Remove brotli-codec dependency
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34059:
URL: https://github.com/apache/spark/pull/34059#issuecomment-924207846
**[Test build #143475 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143475/testReport)** for PR 34059 at commit [`452340c`](https://github.com/apache/spark/commit/452340c4581e8fc33f219e1a14bd5f2ce4da4004).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #34059: [SPARK-36670][FOLLOWUP][TEST] Remove brotli-codec dependency
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #34059:
URL: https://github.com/apache/spark/pull/34059#issuecomment-924225981
Thank you. The first commit passed UTs and the other commits are only touching comments.
Merged to master/3.2.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #34059: [SPARK-36670][FOLLOWUP][TEST] Remove brotli-codec dependency
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #34059:
URL: https://github.com/apache/spark/pull/34059#discussion_r713237721
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/FileSourceCodecSuite.scala
##########
@@ -56,6 +56,7 @@ class ParquetCodecSuite extends FileSourceCodecSuite {
override def format: String = "parquet"
override val codecConfigName: String = SQLConf.PARQUET_COMPRESSION.key
// Exclude "lzo" because it is GPL-licenced so not included in Hadoop.
+ // TODO: test "brotli" if the system is not of ARM64 CPU architecture.
Review comment:
Ur, @gengliangwang . This is not a TODO item. I must be more clear. Like `lzo`, I expected our decision here why we exclude `brotli`. It's a kind of information not to add `brotli` back in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang commented on a change in pull request #34059: [SPARK-36670][FOLLOWUP][TEST] Remove brotli-codec dependency
Posted by GitBox <gi...@apache.org>.
gengliangwang commented on a change in pull request #34059:
URL: https://github.com/apache/spark/pull/34059#discussion_r713259622
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/FileSourceCodecSuite.scala
##########
@@ -56,6 +56,7 @@ class ParquetCodecSuite extends FileSourceCodecSuite {
override def format: String = "parquet"
override val codecConfigName: String = SQLConf.PARQUET_COMPRESSION.key
// Exclude "lzo" because it is GPL-licenced so not included in Hadoop.
+ // TODO: test "brotli" if the system is not of ARM64 CPU architecture.
Review comment:
Got it. I misunderstood your point. I have updated the comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34059: [SPARK-36670][FOLLOWUP][TEST] Remove brotli-codec dependency
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34059:
URL: https://github.com/apache/spark/pull/34059#issuecomment-924198692
**[Test build #143479 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143479/testReport)** for PR 34059 at commit [`eaeba81`](https://github.com/apache/spark/commit/eaeba81aa6a2895673b614c9aebf02bf79c4a66b).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34059: [SPARK-36670][FOLLOWUP][TEST] Remove brotli-codec dependency
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34059:
URL: https://github.com/apache/spark/pull/34059#issuecomment-924083581
**[Test build #143475 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143475/testReport)** for PR 34059 at commit [`452340c`](https://github.com/apache/spark/commit/452340c4581e8fc33f219e1a14bd5f2ce4da4004).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang commented on a change in pull request #34059: [SPARK-36670][FOLLOWUP][TEST] Remove brotli-codec dependency
Posted by GitBox <gi...@apache.org>.
gengliangwang commented on a change in pull request #34059:
URL: https://github.com/apache/spark/pull/34059#discussion_r713223137
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/FileSourceCodecSuite.scala
##########
@@ -57,12 +57,7 @@ class ParquetCodecSuite extends FileSourceCodecSuite {
override val codecConfigName: String = SQLConf.PARQUET_COMPRESSION.key
// Exclude "lzo" because it is GPL-licenced so not included in Hadoop.
override protected def availableCodecs: Seq[String] =
- if (System.getProperty("os.arch") == "aarch64") {
- // Exclude "brotli" due to PARQUET-1975.
- Seq("none", "uncompressed", "snappy", "lz4", "gzip", "zstd")
- } else {
- Seq("none", "uncompressed", "snappy", "lz4", "gzip", "brotli", "zstd")
- }
Review comment:
Added one comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34059: [SPARK-36670][FOLLOWUP][TEST] Remove brotli-codec dependency
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34059:
URL: https://github.com/apache/spark/pull/34059#issuecomment-924271789
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47989/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34059: [SPARK-36670][FOLLOWUP][TEST] Remove brotli-codec dependency
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34059:
URL: https://github.com/apache/spark/pull/34059#issuecomment-924298068
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143478/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34059: [SPARK-36670][FOLLOWUP][TEST] Remove brotli-codec dependency
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34059:
URL: https://github.com/apache/spark/pull/34059#issuecomment-924303372
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/47990/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34059: [SPARK-36670][FOLLOWUP][TEST] Remove brotli-codec dependency
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34059:
URL: https://github.com/apache/spark/pull/34059#issuecomment-924296887
**[Test build #143478 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143478/testReport)** for PR 34059 at commit [`fbae6ac`](https://github.com/apache/spark/commit/fbae6ac0ecf2d15c98e9e751cf812ffcd1e44d0b).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34059: [SPARK-36670][FOLLOWUP][TEST] Remove brotli-codec dependency
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34059:
URL: https://github.com/apache/spark/pull/34059#issuecomment-924180989
**[Test build #143478 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143478/testReport)** for PR 34059 at commit [`fbae6ac`](https://github.com/apache/spark/commit/fbae6ac0ecf2d15c98e9e751cf812ffcd1e44d0b).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on a change in pull request #34059: [SPARK-36670][FOLLOWUP][TEST] Remove brotli-codec dependency
Posted by GitBox <gi...@apache.org>.
viirya commented on a change in pull request #34059:
URL: https://github.com/apache/spark/pull/34059#discussion_r713212244
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/FileSourceCodecSuite.scala
##########
@@ -57,12 +57,7 @@ class ParquetCodecSuite extends FileSourceCodecSuite {
override val codecConfigName: String = SQLConf.PARQUET_COMPRESSION.key
// Exclude "lzo" because it is GPL-licenced so not included in Hadoop.
override protected def availableCodecs: Seq[String] =
- if (System.getProperty("os.arch") == "aarch64") {
- // Exclude "brotli" due to PARQUET-1975.
- Seq("none", "uncompressed", "snappy", "lz4", "gzip", "zstd")
- } else {
- Seq("none", "uncompressed", "snappy", "lz4", "gzip", "brotli", "zstd")
- }
Review comment:
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34059: [SPARK-36670][FOLLOWUP][TEST] Remove brotli-codec dependency
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34059:
URL: https://github.com/apache/spark/pull/34059#issuecomment-924339518
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143479/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34059: [SPARK-36670][FOLLOWUP][TEST] Remove brotli-codec dependency
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34059:
URL: https://github.com/apache/spark/pull/34059#issuecomment-924163045
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47986/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #34059: [SPARK-36670][FOLLOWUP][TEST] Remove brotli-codec dependency
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #34059:
URL: https://github.com/apache/spark/pull/34059#discussion_r713237721
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/FileSourceCodecSuite.scala
##########
@@ -56,6 +56,7 @@ class ParquetCodecSuite extends FileSourceCodecSuite {
override def format: String = "parquet"
override val codecConfigName: String = SQLConf.PARQUET_COMPRESSION.key
// Exclude "lzo" because it is GPL-licenced so not included in Hadoop.
+ // TODO: test "brotli" if the system is not of ARM64 CPU architecture.
Review comment:
Ur, @gengliangwang . This is not a TODO item. I must be more clear. Like `lzo`, I expected our decision why we exclude `brotli` here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on pull request #34059: [SPARK-36670][FOLLOWUP][TEST] Remove brotli-codec dependency
Posted by GitBox <gi...@apache.org>.
srowen commented on pull request #34059:
URL: https://github.com/apache/spark/pull/34059#issuecomment-924099517
Seems fine to me for now. I don't think it has to block 3.2.0 even, being a test dependency, but fine to roll another RC too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun closed pull request #34059: [SPARK-36670][FOLLOWUP][TEST] Remove brotli-codec dependency
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #34059:
URL: https://github.com/apache/spark/pull/34059
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34059: [SPARK-36670][FOLLOWUP][TEST] Remove brotli-codec dependency
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34059:
URL: https://github.com/apache/spark/pull/34059#issuecomment-924198692
**[Test build #143479 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143479/testReport)** for PR 34059 at commit [`eaeba81`](https://github.com/apache/spark/commit/eaeba81aa6a2895673b614c9aebf02bf79c4a66b).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34059: [SPARK-36670][FOLLOWUP][TEST] Remove brotli-codec dependency
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34059:
URL: https://github.com/apache/spark/pull/34059#issuecomment-924180989
**[Test build #143478 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143478/testReport)** for PR 34059 at commit [`fbae6ac`](https://github.com/apache/spark/commit/fbae6ac0ecf2d15c98e9e751cf812ffcd1e44d0b).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org