You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "AdamGS (via GitHub)" <gi...@apache.org> on 2025/10/03 19:12:08 UTC
[PR] [branch-50] Backport: More decimal 32/64 support [datafusion]
AdamGS opened a new pull request, #17908:
URL: https://github.com/apache/datafusion/pull/17908
## Which issue does this PR close?
- Backports https://github.com/apache/datafusion/pull/17808
- Related to https://github.com/apache/datafusion/issues/17849
- Currently also includes https://github.com/apache/datafusion/pull/17907, should be rebased and merged after it.
## Rationale for this change
Fills up decimal32/64 support as introduced in https://github.com/apache/datafusion/pull/17501
## What changes are included in this PR?
The biggest change in this PR is that type coercion for binary expression now not only supports the new decimal types, but it will try and extend one side into the other, which would just fail right now.
### Minor changes
1. Support `abs(deicmal32/64)`
2. Support SMJ on Decimal32/64 (256 was left out, and I'm unclear if it was overlooked or omitted intentionally).
## Are these changes tested?
Additional coercion tests
## Are there any user-facing changes?
No public API changes, but more combination of operations should work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] [branch-50] Backport: More decimal 32/64 support [datafusion]
Posted by "AdamGS (via GitHub)" <gi...@apache.org>.
AdamGS commented on PR #17908:
URL: https://github.com/apache/datafusion/pull/17908#issuecomment-3368029403
See #17907
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] [branch-50] Backport: More decimal 32/64 support [datafusion]
Posted by "AdamGS (via GitHub)" <gi...@apache.org>.
AdamGS closed pull request #17908: [branch-50] Backport: More decimal 32/64 support
URL: https://github.com/apache/datafusion/pull/17908
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] [branch-50] Backport: More decimal 32/64 support [datafusion]
Posted by "AdamGS (via GitHub)" <gi...@apache.org>.
AdamGS commented on PR #17908:
URL: https://github.com/apache/datafusion/pull/17908#issuecomment-3366905010
@alamb this is the best way I figured out to set up the changes across repos, seems like pointing the PR at the intermediate branch did not make the followup point to `branch-50` once it was merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org