You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "alamb (via GitHub)" <gi...@apache.org> on 2024/11/19 12:07:03 UTC

[I] Remove `opt_filter` optional parameter in GroupsAccumulator:merge [datafusion]

alamb opened a new issue, #13484:
URL: https://github.com/apache/datafusion/issues/13484

                 That is why I return error for now, we can remove the `opt_filter` after couple of months
   
   _Originally posted by @jayzhan211 in https://github.com/apache/datafusion/pull/13463#discussion_r1847462304_
               
   
   The idea is that the parameter is never used, so we can remove it to simplify GroupsAccumulator implementations. 
   
   @jayzhan211s PRs above throws an error if this assumption is not true. 
   
   If we haven't hit any errors in a few months, we should just remove the parameter entirely


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org