You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/05/14 06:50:30 UTC
[GitHub] [flink] twalthr commented on a change in pull request #8435:
[FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in
blink
twalthr commented on a change in pull request #8435: [FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in blink
URL: https://github.com/apache/flink/pull/8435#discussion_r283644686
##########
File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/logical/TypeInformationAnyType.java
##########
@@ -68,6 +68,10 @@ public TypeInformationAnyType(TypeInformation<T> typeInfo) {
this(true, typeInfo);
}
+ public TypeInformationAnyType(Class<T> clazz) {
Review comment:
This does not belong into a logical type but into some utility functions. It calls the type extractor and can potentially throw exceptions that need to be catched.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services