[jira] [Commented] (STORM-1379) Removed Redundant Structure

["Robert Joseph Evans (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/STORM-1379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15089455#comment-15089455 ] 

Robert Joseph Evans commented on STORM-1379:
--------------------------------------------

[~darion],

This kind of fell off my radar.  Sorry about it.  The code change looks good.  There was a minor merge conflict, but it looks like it was just white space changes in partition manger.  I am +1 on this.

In the future putting a pull request against http://github.com/apache/storm is a lot simpler and triggers our CI process, so I don't have to run things manually.

> Removed Redundant Structure
> ---------------------------
>
>                 Key: STORM-1379
>                 URL: https://issues.apache.org/jira/browse/STORM-1379
>             Project: Apache Storm
>          Issue Type: Improvement
>          Components: storm-kafka
>    Affects Versions: 0.10.0, 0.9.4, 0.9.5, 0.9.6
>         Environment: CentOS 6  JDK1.7.0_75
>            Reporter: darion yaphets
>            Priority: Minor
>         Attachments: STORM-1379.patch
>
>
> Storm KafkaSpout have a static class MessageAndRealOffset which is same with Kafka API 's  kafka.message.MessageAndOffset . So I hava remove MessageAndRealOffset and replace with MessageAndOffset :)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)