You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@jena.apache.org by GitBox <gi...@apache.org> on 2022/12/17 14:46:32 UTC
[GitHub] [jena] phillipross opened a new pull request, #1687: GH-1686: fix recursive delete on macos for service enhancer TestServiceEnhancerDatasetAssembler test
phillipross opened a new pull request, #1687:
URL: https://github.com/apache/jena/pull/1687
GH-1686: fix recursive delete on macos for service enhancer TestServiceEnhancerDatasetAssembler test
Signed-off-by: Phillip Ross <ph...@gmail.com>
GitHub issue resolved #1686
Pull request Description: Modifies post-test cleanup with recursive temp dir delete using standard Java NIO2 code.
----
- [ ] Tests are included.
- [ ] Documentation change and updates are provided for the [Apache Jena website](https://github.com/apache/jena-site/)
- [X] Commits have been squashed to remove intermediate development commit messages.
- [X] Key commit messages start with the issue number (GH-xxxx or JENA-xxxx)
By submitting this pull request, I acknowledge that I am making a contribution to the Apache Software Foundation under the terms and conditions of the [Contributor's Agreement](https://www.apache.org/licenses/contributor-agreements.html).
----
See the [Apache Jena "Contributing" guide](https://github.com/apache/jena/blob/main/CONTRIBUTING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
[GitHub] [jena] afs commented on pull request #1687: GH-1686: fix recursive delete on macos for service enhancer TestServiceEnhancerDatasetAssembler test
Posted by GitBox <gi...@apache.org>.
afs commented on PR #1687:
URL: https://github.com/apache/jena/pull/1687#issuecomment-1356462766
LGTM. Tested (on Linux).
A JUnit rule for `TemporaryFolder` should also be possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
[GitHub] [jena] afs merged pull request #1687: GH-1686: fix recursive delete on macos for service enhancer TestServiceEnhancerDatasetAssembler test
Posted by GitBox <gi...@apache.org>.
afs merged PR #1687:
URL: https://github.com/apache/jena/pull/1687
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org