[GitHub] [hbase] wchevreuil commented on a change in pull request #1903: HBASE-24562: Stabilize master startup with meta replicas enabled

[GitBox <gi...@apache.org>]

wchevreuil commented on a change in pull request #1903:
URL: https://github.com/apache/hbase/pull/1903#discussion_r440297695



##########
File path: hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestMetaWithReplicas.java
##########
@@ -355,4 +362,58 @@ public void testShutdownOfReplicaHolder() throws Exception {
       assertNotEquals(3, i);
     }
   }
+
+  @Test
+  public void testFailedReplicaAssigment() throws InterruptedException, IOException {

Review comment:
       As the main purpose of the change is to allow Master to complete initialisation in case of meta replica failures, shouldn't this test assert that _HMaster.finishActiveMasterInitialization_ completes properly even with the induced replicas assignment failures? I can see we are asserting that replicas assignment fails, which is not what we actually want to safeguard from.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org