You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by jd...@apache.org on 2005/12/01 17:59:28 UTC

svn commit: r350274 - /maven/plugins/trunk/maven-checkstyle-plugin/pom.xml

Author: jdcasey
Date: Thu Dec  1 08:59:24 2005
New Revision: 350274

URL: http://svn.apache.org/viewcvs?rev=350274&view=rev
Log:
Adding runtime dep on log4j to prevent commons-logging from crapping out.

Modified:
    maven/plugins/trunk/maven-checkstyle-plugin/pom.xml

Modified: maven/plugins/trunk/maven-checkstyle-plugin/pom.xml
URL: http://svn.apache.org/viewcvs/maven/plugins/trunk/maven-checkstyle-plugin/pom.xml?rev=350274&r1=350273&r2=350274&view=diff
==============================================================================
--- maven/plugins/trunk/maven-checkstyle-plugin/pom.xml (original)
+++ maven/plugins/trunk/maven-checkstyle-plugin/pom.xml Thu Dec  1 08:59:24 2005
@@ -35,6 +35,12 @@
       <artifactId>maven-reporting-impl</artifactId>
       <version>2.0</version>
     </dependency>
+    <dependency>
+      <groupId>log4j</groupId>
+      <artifactId>log4j</artifactId>
+      <version>1.2.12</version>
+      <scope>runtime</scope>
+    </dependency>
     <!-- Eventually, use the shared libs to keep it consistent with other plugins... -->
     <!-- dependency>
       <groupId>org.apache.maven.shared</groupId>



Re: svn commit: r350274 - /maven/plugins/trunk/maven-checkstyle-plugin/pom.xml

Posted by Brett Porter <br...@apache.org>.
John,

A better solution might be have the plugin set the c-logging system
property - see the Jetty6 plugin docs for an example.

- Brett

jdcasey@apache.org wrote:
> Author: jdcasey
> Date: Thu Dec  1 08:59:24 2005
> New Revision: 350274
> 
> URL: http://svn.apache.org/viewcvs?rev=350274&view=rev
> Log:
> Adding runtime dep on log4j to prevent commons-logging from crapping out.
> 
> Modified:
>     maven/plugins/trunk/maven-checkstyle-plugin/pom.xml
> 
> Modified: maven/plugins/trunk/maven-checkstyle-plugin/pom.xml
> URL: http://svn.apache.org/viewcvs/maven/plugins/trunk/maven-checkstyle-plugin/pom.xml?rev=350274&r1=350273&r2=350274&view=diff
> ==============================================================================
> --- maven/plugins/trunk/maven-checkstyle-plugin/pom.xml (original)
> +++ maven/plugins/trunk/maven-checkstyle-plugin/pom.xml Thu Dec  1 08:59:24 2005
> @@ -35,6 +35,12 @@
>        <artifactId>maven-reporting-impl</artifactId>
>        <version>2.0</version>
>      </dependency>
> +    <dependency>
> +      <groupId>log4j</groupId>
> +      <artifactId>log4j</artifactId>
> +      <version>1.2.12</version>
> +      <scope>runtime</scope>
> +    </dependency>
>      <!-- Eventually, use the shared libs to keep it consistent with other plugins... -->
>      <!-- dependency>
>        <groupId>org.apache.maven.shared</groupId>
> 
> 

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org