You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@myfaces.apache.org by lo...@apache.org on 2013/11/15 18:11:10 UTC

svn commit: r1542331 [4/28] - in /myfaces/tobago/trunk: tobago-core/src/main/java/org/apache/myfaces/tobago/ajax/ tobago-core/src/main/java/org/apache/myfaces/tobago/application/ tobago-core/src/main/java/org/apache/myfaces/tobago/compat/ tobago-core/s...

Modified: myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/facelets/TobagoComponentHandler.java
URL: http://svn.apache.org/viewvc/myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/facelets/TobagoComponentHandler.java?rev=1542331&r1=1542330&r2=1542331&view=diff
==============================================================================
--- myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/facelets/TobagoComponentHandler.java (original)
+++ myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/facelets/TobagoComponentHandler.java Fri Nov 15 17:10:58 2013
@@ -57,12 +57,12 @@ public class TobagoComponentHandler exte
     LOG.error("init");
   }
 
-  public TobagoComponentHandler(ComponentConfig componentConfig) {
+  public TobagoComponentHandler(final ComponentConfig componentConfig) {
     super(componentConfig);
   }
 
-  protected MetaRuleset createMetaRuleset(Class aClass) {
-    MetaRuleset metaRuleset = super.createMetaRuleset(aClass);
+  protected MetaRuleset createMetaRuleset(final Class aClass) {
+    final MetaRuleset metaRuleset = super.createMetaRuleset(aClass);
     if (SortActionSource.class.isAssignableFrom(aClass)) {
       metaRuleset.addRule(SortActionSourceRule.INSTANCE);
     }
@@ -96,7 +96,7 @@ public class TobagoComponentHandler exte
     return metaRuleset;
   }
 
-  public void onComponentCreated(FaceletContext context, UIComponent component, UIComponent parent) {
+  public void onComponentCreated(final FaceletContext context, final UIComponent component, final UIComponent parent) {
     if (component instanceof OnComponentCreated
         && component.getAttributes().get(OnComponentCreated.MARKER) == null) {
       component.getAttributes().put(OnComponentCreated.MARKER, Boolean.TRUE);
@@ -104,7 +104,8 @@ public class TobagoComponentHandler exte
     }
   }
 
-  public void onComponentPopulated(FaceletContext context, UIComponent component, UIComponent parent) {
+  public void onComponentPopulated(
+      final FaceletContext context, final UIComponent component, final UIComponent parent) {
     if (component instanceof OnComponentPopulated
         && component.getAttributes().get(OnComponentPopulated.MARKER) == null) {
       component.getAttributes().put(OnComponentPopulated.MARKER, Boolean.TRUE);
@@ -116,28 +117,28 @@ public class TobagoComponentHandler exte
     }
   }
 
-  public static void addDefaultValidators(FacesContext context, EditableValueHolder component) {
-    TobagoConfigImpl tobagoConfig = (TobagoConfigImpl) TobagoConfig.getInstance(context);
-    Map validatorInfoMap = tobagoConfig.getDefaultValidatorInfo();
+  public static void addDefaultValidators(final FacesContext context, final EditableValueHolder component) {
+    final TobagoConfigImpl tobagoConfig = (TobagoConfigImpl) TobagoConfig.getInstance(context);
+    final Map validatorInfoMap = tobagoConfig.getDefaultValidatorInfo();
     if (validatorInfoMap.isEmpty()) {
       return;
     }
-    Validator[] validators = component.getValidators();
+    final Validator[] validators = component.getValidators();
     if (validators.length > 0) {
-      Set classNames = new HashSet();
+      final Set classNames = new HashSet();
       // collect classNames of validators
       for (int i = 0; i < validators.length; i++) {
         classNames.add(validators[i].getClass().getName());
       }
-      Iterator it = validatorInfoMap.entrySet().iterator();
+      final Iterator it = validatorInfoMap.entrySet().iterator();
       while (it.hasNext()) {
-        Map.Entry entry = (Map.Entry) it.next();
+        final Map.Entry entry = (Map.Entry) it.next();
         if (!classNames.contains(entry.getValue())) {
           component.addValidator(context.getApplication().createValidator((String) entry.getKey()));
         }
       }
     } else {
-      Iterator it = validatorInfoMap.keySet().iterator();
+      final Iterator it = validatorInfoMap.keySet().iterator();
       while (it.hasNext()) {
         component.addValidator(context.getApplication().createValidator((String) it.next()));
       }

Modified: myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/facelets/TobagoValidateHandler.java
URL: http://svn.apache.org/viewvc/myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/facelets/TobagoValidateHandler.java?rev=1542331&r1=1542330&r2=1542331&view=diff
==============================================================================
--- myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/facelets/TobagoValidateHandler.java (original)
+++ myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/facelets/TobagoValidateHandler.java Fri Nov 15 17:10:58 2013
@@ -27,12 +27,12 @@ import javax.faces.view.facelets.Validat
 
 public class TobagoValidateHandler extends ValidatorHandler {
 
-  public TobagoValidateHandler(ValidatorConfig config) {
+  public TobagoValidateHandler(final ValidatorConfig config) {
     super(config);
   }
 
-  protected MetaRuleset createMetaRuleset(Class aClass) {
-    MetaRuleset metaRuleset = super.createMetaRuleset(aClass);
+  protected MetaRuleset createMetaRuleset(final Class aClass) {
+    final MetaRuleset metaRuleset = super.createMetaRuleset(aClass);
     if (FileItemValidator.class.isAssignableFrom(aClass)) {
       metaRuleset.addRule(ContentTypeRule.INSTANCE);
     }

Modified: myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/facelets/WizardComponentHandler.java
URL: http://svn.apache.org/viewvc/myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/facelets/WizardComponentHandler.java?rev=1542331&r1=1542330&r2=1542331&view=diff
==============================================================================
--- myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/facelets/WizardComponentHandler.java (original)
+++ myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/facelets/WizardComponentHandler.java Fri Nov 15 17:10:58 2013
@@ -29,18 +29,19 @@ public class WizardComponentHandler exte
 
   private TagAttribute outcomeAttribute;
 
-  public WizardComponentHandler(ComponentConfig componentConfig) {
+  public WizardComponentHandler(final ComponentConfig componentConfig) {
     super(componentConfig);
     outcomeAttribute = getAttribute("outcome");
   }
 
-  public void onComponentCreated(FaceletContext faceletContext, UIComponent wizard, UIComponent parent) {
+  public void onComponentCreated(
+      final FaceletContext faceletContext, final UIComponent wizard, final UIComponent parent) {
 
     if (outcomeAttribute != null) {
       if (outcomeAttribute.isLiteral()) {
         wizard.getAttributes().put("outcome", outcomeAttribute.getValue(faceletContext));
       } else {
-        ValueExpression expression = outcomeAttribute.getValueExpression(faceletContext, String.class);
+        final ValueExpression expression = outcomeAttribute.getValueExpression(faceletContext, String.class);
         wizard.setValueExpression("outcome", expression);
       }
     }

Modified: myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/facelets/extension/DateExtensionHandler.java
URL: http://svn.apache.org/viewvc/myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/facelets/extension/DateExtensionHandler.java?rev=1542331&r1=1542330&r2=1542331&view=diff
==============================================================================
--- myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/facelets/extension/DateExtensionHandler.java (original)
+++ myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/facelets/extension/DateExtensionHandler.java Fri Nov 15 17:10:58 2013
@@ -42,7 +42,7 @@ public class DateExtensionHandler extend
   private TagAttribute formIdAttribute;
   private TagAttribute markupAttribute;
 
-  public DateExtensionHandler(ComponentConfig config) {
+  public DateExtensionHandler(final ComponentConfig config) {
     super(config);
     pickerIdAttribute = getAttribute("pickerId");
     formIdAttribute = getAttribute("formId");
@@ -57,13 +57,14 @@ public class DateExtensionHandler extend
     return RendererTypes.DATE;
   }
 
-  public void onComponentPopulated(FaceletContext faceletContext, UIComponent panel, UIComponent parent) {
+  public void onComponentPopulated(
+      final FaceletContext faceletContext, final UIComponent panel, final UIComponent parent) {
     super.onComponentPopulated(faceletContext, panel, parent);
     if (panel.getChildCount() == 2) {
-      Application application = faceletContext.getFacesContext().getApplication();
-      UIViewRoot root = ComponentUtils.findViewRoot(faceletContext, parent);
+      final Application application = faceletContext.getFacesContext().getApplication();
+      final UIViewRoot root = ComponentUtils.findViewRoot(faceletContext, parent);
 
-      UIForm form = (UIForm) application.createComponent(UIForm.COMPONENT_TYPE);
+      final UIForm form = (UIForm) application.createComponent(UIForm.COMPONENT_TYPE);
       form.setRendererType(RendererTypes.FORM);
       final String formId = formIdAttribute != null
           ? formIdAttribute.getValue(faceletContext)
@@ -71,7 +72,7 @@ public class DateExtensionHandler extend
       form.setId(formId);
       panel.getChildren().add(form);
 
-      UIDatePicker picker = (UIDatePicker) application.createComponent(UIDatePicker.COMPONENT_TYPE);
+      final UIDatePicker picker = (UIDatePicker) application.createComponent(UIDatePicker.COMPONENT_TYPE);
       picker.setRendererType(RendererTypes.DATE_PICKER);
       picker.setFor("@auto");
       final String pickerId = pickerIdAttribute != null
@@ -86,7 +87,7 @@ public class DateExtensionHandler extend
         if (markupAttribute.isLiteral()) {
           picker.setMarkup(Markup.valueOf(markupAttribute.getValue()));
         } else {
-          ValueExpression expression = markupAttribute.getValueExpression(faceletContext, Object.class);
+          final ValueExpression expression = markupAttribute.getValueExpression(faceletContext, Object.class);
           picker.setValueExpression(Attributes.MARKUP, expression);
         }
       }
@@ -94,7 +95,7 @@ public class DateExtensionHandler extend
     }
   }
 
-  protected String getColumns(String first) {
+  protected String getColumns(final String first) {
     return first + ";*;auto";
   }
 }

Modified: myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/facelets/extension/FileExtensionHandler.java
URL: http://svn.apache.org/viewvc/myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/facelets/extension/FileExtensionHandler.java?rev=1542331&r1=1542330&r2=1542331&view=diff
==============================================================================
--- myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/facelets/extension/FileExtensionHandler.java (original)
+++ myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/facelets/extension/FileExtensionHandler.java Fri Nov 15 17:10:58 2013
@@ -26,7 +26,7 @@ import javax.faces.view.facelets.Compone
 
 public class FileExtensionHandler extends TobagoLabelExtensionHandler {
 
-  public FileExtensionHandler(ComponentConfig config) {
+  public FileExtensionHandler(final ComponentConfig config) {
     super(config);
   }
 

Modified: myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/facelets/extension/InExtensionHandler.java
URL: http://svn.apache.org/viewvc/myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/facelets/extension/InExtensionHandler.java?rev=1542331&r1=1542330&r2=1542331&view=diff
==============================================================================
--- myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/facelets/extension/InExtensionHandler.java (original)
+++ myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/facelets/extension/InExtensionHandler.java Fri Nov 15 17:10:58 2013
@@ -26,7 +26,7 @@ import javax.faces.view.facelets.Compone
 
 public class InExtensionHandler extends TobagoLabelExtensionHandler {
 
-  public InExtensionHandler(ComponentConfig config) {
+  public InExtensionHandler(final ComponentConfig config) {
     super(config);
   }
 

Modified: myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/facelets/extension/LabelExtensionHandler.java
URL: http://svn.apache.org/viewvc/myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/facelets/extension/LabelExtensionHandler.java?rev=1542331&r1=1542330&r2=1542331&view=diff
==============================================================================
--- myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/facelets/extension/LabelExtensionHandler.java (original)
+++ myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/facelets/extension/LabelExtensionHandler.java Fri Nov 15 17:10:58 2013
@@ -29,7 +29,7 @@ import javax.faces.view.facelets.Compone
  */
 public class LabelExtensionHandler extends TobagoLabelExtensionHandler {
 
-  public LabelExtensionHandler(ComponentConfig config) {
+  public LabelExtensionHandler(final ComponentConfig config) {
     super(config);
   }
 

Modified: myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/facelets/extension/MenuCheckboxExtensionHandler.java
URL: http://svn.apache.org/viewvc/myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/facelets/extension/MenuCheckboxExtensionHandler.java?rev=1542331&r1=1542330&r2=1542331&view=diff
==============================================================================
--- myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/facelets/extension/MenuCheckboxExtensionHandler.java (original)
+++ myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/facelets/extension/MenuCheckboxExtensionHandler.java Fri Nov 15 17:10:58 2013
@@ -38,7 +38,7 @@ import javax.faces.view.facelets.Compone
  */
 public class MenuCheckboxExtensionHandler extends TobagoMenuExtensionHandler {
 
-  public MenuCheckboxExtensionHandler(ComponentConfig config) {
+  public MenuCheckboxExtensionHandler(final ComponentConfig config) {
     super(config);
   }
 

Modified: myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/facelets/extension/MenuRadioExtensionHandler.java
URL: http://svn.apache.org/viewvc/myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/facelets/extension/MenuRadioExtensionHandler.java?rev=1542331&r1=1542330&r2=1542331&view=diff
==============================================================================
--- myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/facelets/extension/MenuRadioExtensionHandler.java (original)
+++ myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/facelets/extension/MenuRadioExtensionHandler.java Fri Nov 15 17:10:58 2013
@@ -42,7 +42,7 @@ import javax.faces.view.facelets.Compone
  */
 public class MenuRadioExtensionHandler extends TobagoMenuExtensionHandler {
 
-  public MenuRadioExtensionHandler(ComponentConfig config) {
+  public MenuRadioExtensionHandler(final ComponentConfig config) {
     super(config);
   }
 

Modified: myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/facelets/extension/SelectBooleanCheckboxExtensionHandler.java
URL: http://svn.apache.org/viewvc/myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/facelets/extension/SelectBooleanCheckboxExtensionHandler.java?rev=1542331&r1=1542330&r2=1542331&view=diff
==============================================================================
--- myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/facelets/extension/SelectBooleanCheckboxExtensionHandler.java (original)
+++ myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/facelets/extension/SelectBooleanCheckboxExtensionHandler.java Fri Nov 15 17:10:58 2013
@@ -33,19 +33,19 @@ public class SelectBooleanCheckboxExtens
 
   private TagAttribute itemLabelAttribute;
 
-  public SelectBooleanCheckboxExtensionHandler(ComponentConfig config) {
+  public SelectBooleanCheckboxExtensionHandler(final ComponentConfig config) {
     super(config);
     itemLabelAttribute = getAttribute(Attributes.ITEM_LABEL);
   }
 
-  protected void enrichInput(FaceletContext faceletContext, UIComponent input) {
+  protected void enrichInput(final FaceletContext faceletContext, final UIComponent input) {
     super.enrichInput(faceletContext, input);
-    UISelectBooleanCheckbox checkbox = (UISelectBooleanCheckbox) input;
+    final UISelectBooleanCheckbox checkbox = (UISelectBooleanCheckbox) input;
     if (itemLabelAttribute != null) {
       if (itemLabelAttribute.isLiteral()) {
         checkbox.setItemLabel(itemLabelAttribute.getValue(faceletContext));
       } else {
-        ValueExpression expression = itemLabelAttribute.getValueExpression(faceletContext, String.class);
+        final ValueExpression expression = itemLabelAttribute.getValueExpression(faceletContext, String.class);
         checkbox.setValueExpression(Attributes.ITEM_LABEL, expression);
       }
     } else {

Modified: myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/facelets/extension/SelectManyCheckboxExtensionHandler.java
URL: http://svn.apache.org/viewvc/myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/facelets/extension/SelectManyCheckboxExtensionHandler.java?rev=1542331&r1=1542330&r2=1542331&view=diff
==============================================================================
--- myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/facelets/extension/SelectManyCheckboxExtensionHandler.java (original)
+++ myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/facelets/extension/SelectManyCheckboxExtensionHandler.java Fri Nov 15 17:10:58 2013
@@ -26,7 +26,7 @@ import javax.faces.view.facelets.Compone
 
 public class SelectManyCheckboxExtensionHandler extends TobagoLabelExtensionHandler {
 
-  public SelectManyCheckboxExtensionHandler(ComponentConfig config) {
+  public SelectManyCheckboxExtensionHandler(final ComponentConfig config) {
     super(config);
   }
 

Modified: myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/facelets/extension/SelectManyListboxExtensionHandler.java
URL: http://svn.apache.org/viewvc/myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/facelets/extension/SelectManyListboxExtensionHandler.java?rev=1542331&r1=1542330&r2=1542331&view=diff
==============================================================================
--- myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/facelets/extension/SelectManyListboxExtensionHandler.java (original)
+++ myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/facelets/extension/SelectManyListboxExtensionHandler.java Fri Nov 15 17:10:58 2013
@@ -19,13 +19,14 @@
 
 package org.apache.myfaces.tobago.facelets.extension;
 
-import javax.faces.view.facelets.ComponentConfig;
 import org.apache.myfaces.tobago.component.RendererTypes;
 import org.apache.myfaces.tobago.component.UISelectManyListbox;
 
+import javax.faces.view.facelets.ComponentConfig;
+
 public class SelectManyListboxExtensionHandler extends TobagoLabelExtensionHandler {
 
-  public SelectManyListboxExtensionHandler(ComponentConfig config) {
+  public SelectManyListboxExtensionHandler(final ComponentConfig config) {
     super(config);
   }
 

Modified: myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/facelets/extension/SelectManyShuttleExtensionHandler.java
URL: http://svn.apache.org/viewvc/myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/facelets/extension/SelectManyShuttleExtensionHandler.java?rev=1542331&r1=1542330&r2=1542331&view=diff
==============================================================================
--- myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/facelets/extension/SelectManyShuttleExtensionHandler.java (original)
+++ myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/facelets/extension/SelectManyShuttleExtensionHandler.java Fri Nov 15 17:10:58 2013
@@ -26,7 +26,7 @@ import javax.faces.view.facelets.Compone
 
 public class SelectManyShuttleExtensionHandler extends TobagoLabelExtensionHandler {
 
-  public SelectManyShuttleExtensionHandler(ComponentConfig config) {
+  public SelectManyShuttleExtensionHandler(final ComponentConfig config) {
     super(config);
   }
 

Modified: myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/facelets/extension/SelectOneChoiceExtensionHandler.java
URL: http://svn.apache.org/viewvc/myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/facelets/extension/SelectOneChoiceExtensionHandler.java?rev=1542331&r1=1542330&r2=1542331&view=diff
==============================================================================
--- myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/facelets/extension/SelectOneChoiceExtensionHandler.java (original)
+++ myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/facelets/extension/SelectOneChoiceExtensionHandler.java Fri Nov 15 17:10:58 2013
@@ -19,13 +19,14 @@
 
 package org.apache.myfaces.tobago.facelets.extension;
 
-import javax.faces.view.facelets.ComponentConfig;
 import org.apache.myfaces.tobago.component.RendererTypes;
 import org.apache.myfaces.tobago.component.UISelectOneChoice;
 
+import javax.faces.view.facelets.ComponentConfig;
+
 public class SelectOneChoiceExtensionHandler extends TobagoLabelExtensionHandler {
 
-  public SelectOneChoiceExtensionHandler(ComponentConfig config) {
+  public SelectOneChoiceExtensionHandler(final ComponentConfig config) {
     super(config);
   }
 

Modified: myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/facelets/extension/SelectOneListboxExtensionHandler.java
URL: http://svn.apache.org/viewvc/myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/facelets/extension/SelectOneListboxExtensionHandler.java?rev=1542331&r1=1542330&r2=1542331&view=diff
==============================================================================
--- myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/facelets/extension/SelectOneListboxExtensionHandler.java (original)
+++ myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/facelets/extension/SelectOneListboxExtensionHandler.java Fri Nov 15 17:10:58 2013
@@ -25,7 +25,7 @@ import org.apache.myfaces.tobago.compone
 
 public class SelectOneListboxExtensionHandler extends TobagoLabelExtensionHandler {
 
-  public SelectOneListboxExtensionHandler(ComponentConfig config) {
+  public SelectOneListboxExtensionHandler(final ComponentConfig config) {
     super(config);
   }
 

Modified: myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/facelets/extension/SelectOneRadioExtensionHandler.java
URL: http://svn.apache.org/viewvc/myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/facelets/extension/SelectOneRadioExtensionHandler.java?rev=1542331&r1=1542330&r2=1542331&view=diff
==============================================================================
--- myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/facelets/extension/SelectOneRadioExtensionHandler.java (original)
+++ myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/facelets/extension/SelectOneRadioExtensionHandler.java Fri Nov 15 17:10:58 2013
@@ -19,13 +19,14 @@
 
 package org.apache.myfaces.tobago.facelets.extension;
 
-import javax.faces.view.facelets.ComponentConfig;
 import org.apache.myfaces.tobago.component.RendererTypes;
 import org.apache.myfaces.tobago.component.UISelectOneRadio;
 
+import javax.faces.view.facelets.ComponentConfig;
+
 public class SelectOneRadioExtensionHandler extends TobagoLabelExtensionHandler {
 
-  public SelectOneRadioExtensionHandler(ComponentConfig config) {
+  public SelectOneRadioExtensionHandler(final ComponentConfig config) {
     super(config);
   }
 

Modified: myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/facelets/extension/SeparatorExtensionHandler.java
URL: http://svn.apache.org/viewvc/myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/facelets/extension/SeparatorExtensionHandler.java?rev=1542331&r1=1542330&r2=1542331&view=diff
==============================================================================
--- myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/facelets/extension/SeparatorExtensionHandler.java (original)
+++ myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/facelets/extension/SeparatorExtensionHandler.java Fri Nov 15 17:10:58 2013
@@ -23,14 +23,12 @@ import org.apache.myfaces.tobago.compone
 import org.apache.myfaces.tobago.component.Facets;
 import org.apache.myfaces.tobago.component.UILabel;
 import org.apache.myfaces.tobago.component.UISeparator;
-import org.apache.myfaces.tobago.util.ComponentUtils;
 
 import javax.el.ELException;
 import javax.el.ValueExpression;
 import javax.faces.application.Application;
 import javax.faces.component.UIComponent;
 import javax.faces.component.UIOutput;
-import javax.faces.component.UIViewRoot;
 import javax.faces.view.facelets.ComponentConfig;
 import javax.faces.view.facelets.ComponentHandler;
 import javax.faces.view.facelets.FaceletContext;
@@ -41,15 +39,15 @@ import java.io.IOException;
 public class SeparatorExtensionHandler extends ComponentHandler {
   private TagAttribute labelAttribute;
 
-  public SeparatorExtensionHandler(ComponentConfig config) {
+  public SeparatorExtensionHandler(final ComponentConfig config) {
     super(config);
     labelAttribute = getAttribute(Attributes.LABEL);
   }
 
-  public void applyNextHandler(FaceletContext faceletContext, UIComponent separator)
+  public void applyNextHandler(final FaceletContext faceletContext, final UIComponent separator)
       throws IOException, ELException {
     if (ComponentHandler.isNew(separator)) {
-      UIComponent component = (UIComponent) separator.getFacets().remove(Facets.LABEL);
+      final UIComponent component = (UIComponent) separator.getFacets().remove(Facets.LABEL);
       nextHandler.apply(faceletContext, component);
       separator.getFacets().put(Facets.LABEL, component);
     } else {
@@ -57,10 +55,10 @@ public class SeparatorExtensionHandler e
     }
   }
 
-  public void onComponentCreated(FaceletContext faceletContext, UIComponent separator, UIComponent parent) {
-    Application application = faceletContext.getFacesContext().getApplication();
-    UIViewRoot root = ComponentUtils.findViewRoot(faceletContext, parent);
-    UIOutput label = (UIOutput) application.createComponent(UILabel.COMPONENT_TYPE);
+  public void onComponentCreated(
+      final FaceletContext faceletContext, final UIComponent separator, final UIComponent parent) {
+    final Application application = faceletContext.getFacesContext().getApplication();
+    final UIOutput label = (UIOutput) application.createComponent(UILabel.COMPONENT_TYPE);
     label.setId("_tx_" + faceletContext.generateUniqueId("label"));
     label.setRendererType("Label");
     setAttributes(faceletContext, label);
@@ -69,21 +67,21 @@ public class SeparatorExtensionHandler e
       if (labelAttribute.isLiteral()) {
         label.setValue(labelAttribute.getValue(faceletContext));
       } else {
-        ValueExpression expression = labelAttribute.getValueExpression(faceletContext, String.class);
+        final ValueExpression expression = labelAttribute.getValueExpression(faceletContext, String.class);
         label.setValueExpression(Attributes.VALUE, expression);
       }
     }
   }
 
-  protected MetaRuleset createMetaRuleset(Class aClass) {
-    MetaRuleset metaRuleset = super.createMetaRuleset(aClass);
+  protected MetaRuleset createMetaRuleset(final Class aClass) {
+    final MetaRuleset metaRuleset = super.createMetaRuleset(aClass);
     if (UISeparator.class.isAssignableFrom(aClass)) {
       metaRuleset.ignore(Attributes.LABEL);
       return metaRuleset;
     } else {
-      TagAttribute[] attrs = tag.getAttributes().getAll();
+      final TagAttribute[] attrs = tag.getAttributes().getAll();
       for (int i = 0; i < attrs.length; i++) {
-        TagAttribute attr = attrs[i];
+        final TagAttribute attr = attrs[i];
         metaRuleset.ignore(attr.getLocalName());
       }
       return metaRuleset;

Modified: myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/facelets/extension/TextareaExtensionHandler.java
URL: http://svn.apache.org/viewvc/myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/facelets/extension/TextareaExtensionHandler.java?rev=1542331&r1=1542330&r2=1542331&view=diff
==============================================================================
--- myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/facelets/extension/TextareaExtensionHandler.java (original)
+++ myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/facelets/extension/TextareaExtensionHandler.java Fri Nov 15 17:10:58 2013
@@ -26,7 +26,7 @@ import javax.faces.view.facelets.Compone
 
 public class TextareaExtensionHandler extends TobagoLabelExtensionHandler {
 
-  public TextareaExtensionHandler(ComponentConfig config) {
+  public TextareaExtensionHandler(final ComponentConfig config) {
     super(config);
   }
 

Modified: myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/facelets/extension/TimeExtensionHandler.java
URL: http://svn.apache.org/viewvc/myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/facelets/extension/TimeExtensionHandler.java?rev=1542331&r1=1542330&r2=1542331&view=diff
==============================================================================
--- myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/facelets/extension/TimeExtensionHandler.java (original)
+++ myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/facelets/extension/TimeExtensionHandler.java Fri Nov 15 17:10:58 2013
@@ -26,7 +26,7 @@ import javax.faces.view.facelets.Compone
 
 public class TimeExtensionHandler extends TobagoLabelExtensionHandler {
 
-  public TimeExtensionHandler(ComponentConfig config) {
+  public TimeExtensionHandler(final ComponentConfig config) {
     super(config);
   }
 

Modified: myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/facelets/extension/TobagoLabelExtensionHandler.java
URL: http://svn.apache.org/viewvc/myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/facelets/extension/TobagoLabelExtensionHandler.java?rev=1542331&r1=1542330&r2=1542331&view=diff
==============================================================================
--- myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/facelets/extension/TobagoLabelExtensionHandler.java (original)
+++ myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/facelets/extension/TobagoLabelExtensionHandler.java Fri Nov 15 17:10:58 2013
@@ -64,7 +64,7 @@ public abstract class TobagoLabelExtensi
   private Class subComponentLastType = Object.class;
   private Metadata subComponentMapper;
 
-  public TobagoLabelExtensionHandler(ComponentConfig config) {
+  public TobagoLabelExtensionHandler(final ComponentConfig config) {
     super(config);
     labelWidthAttribute = getAttribute("labelWidth");
     tipAttribute = getAttribute(Attributes.TIP);
@@ -81,15 +81,15 @@ public abstract class TobagoLabelExtensi
     return "auto";
   }
 
-  protected String getColumns(String first) {
+  protected String getColumns(final String first) {
     return first + ";*";
   }
 
-  public void applyNextHandler(FaceletContext ctx, UIComponent panel)
+  public void applyNextHandler(final FaceletContext ctx, final UIComponent panel)
       throws IOException, ELException {
     if (ComponentHandler.isNew(panel)) {
       // ensure that input has no parent (isNew)
-      UIComponent input = panel.getChildren().remove(1);
+      final UIComponent input = panel.getChildren().remove(1);
       try {
         input.getAttributes().put("tobago.panel", panel);
         nextHandler.apply(ctx, input);
@@ -105,19 +105,20 @@ public abstract class TobagoLabelExtensi
         panel.getChildren().add(date);
       }
     } else {
-      UIComponent input = panel.getChildren().get(1);
+      final UIComponent input = panel.getChildren().get(1);
       nextHandler.apply(ctx, input);
     }
   }
 
-  public void onComponentCreated(FaceletContext faceletContext, UIComponent panel, UIComponent parent) {
+  public void onComponentCreated(
+      final FaceletContext faceletContext, final UIComponent panel, final UIComponent parent) {
 
     final Application application = faceletContext.getFacesContext().getApplication();
 
     addGridLayout(faceletContext, panel, application);
     addLabel(faceletContext, (UIPanel) panel, application);
 
-    String uid;
+    final String uid;
     if (fieldIdAttribute != null) {
       uid = fieldIdAttribute.getValue(faceletContext);
     } else {
@@ -127,7 +128,7 @@ public abstract class TobagoLabelExtensi
       return;
     }
 
-    UIComponent input = application.createComponent(getSubComponentType());
+    final UIComponent input = application.createComponent(getSubComponentType());
     input.setRendererType(getSubRendererType());
     input.setId(uid);
 
@@ -137,10 +138,10 @@ public abstract class TobagoLabelExtensi
     panel.getChildren().add(input);
   }
 
-  protected void enrichInput(FaceletContext faceletContext, UIComponent input) {
+  protected void enrichInput(final FaceletContext faceletContext, final UIComponent input) {
   }
 
-  private void addLabel(FaceletContext faceletContext, UIPanel panel, final Application application) {
+  private void addLabel(final FaceletContext faceletContext, final UIPanel panel, final Application application) {
     final String uid = "_tx_" + faceletContext.generateUniqueId("label");
     if (checkForAlreadyCreated(panel, uid)) {
       return;
@@ -176,9 +177,9 @@ public abstract class TobagoLabelExtensi
     panel.getChildren().add(label);
   }
 
-  private boolean checkForAlreadyCreated(UIComponent panel, String uid) {
+  private boolean checkForAlreadyCreated(final UIComponent panel, final String uid) {
     if (panel.getChildCount() > 0) {
-      for (UIComponent child : panel.getChildren()) {
+      for (final UIComponent child : panel.getChildren()) {
         if (uid.equals(child.getId())) {
           return true;
         }
@@ -187,11 +188,12 @@ public abstract class TobagoLabelExtensi
     return false;
   }
 
-  public void onComponentPopulated(FaceletContext faceletContext, UIComponent component, UIComponent parent) {
+  public void onComponentPopulated(
+      final FaceletContext faceletContext, final UIComponent component, final UIComponent parent) {
     super.onComponentPopulated(faceletContext, component, parent);
 
     if (component.getChildren().size() > 1) {
-      UIComponent input = component.getChildren().get(1);
+      final UIComponent input = component.getChildren().get(1);
       if (input instanceof EditableValueHolder) {
         TobagoComponentHandler.addDefaultValidators(faceletContext.getFacesContext(), (EditableValueHolder) input);
       }
@@ -201,7 +203,8 @@ public abstract class TobagoLabelExtensi
     }
   }
 
-  private void addGridLayout(FaceletContext faceletContext, UIComponent panel, final Application application) {
+  private void addGridLayout(
+      final FaceletContext faceletContext, final UIComponent panel, final Application application) {
     final UIGridLayout gridLayout = (UIGridLayout) application.createComponent(UIGridLayout.COMPONENT_TYPE);
     gridLayout.setRendererType(RendererTypes.GRID_LAYOUT);
     if (labelWidthAttribute != null) {
@@ -225,9 +228,9 @@ public abstract class TobagoLabelExtensi
     }
   }
 
-  private void setSubComponentAttributes(FaceletContext ctx, Object instance) {
+  private void setSubComponentAttributes(final FaceletContext ctx, final Object instance) {
     if (instance != null) {
-      Class type = instance.getClass();
+      final Class type = instance.getClass();
       if (subComponentMapper == null || !subComponentLastType.equals(type)) {
         subComponentLastType = type;
         subComponentMapper = createSubComponentMetaRuleset(type).finish();
@@ -236,8 +239,8 @@ public abstract class TobagoLabelExtensi
     }
   }
 
-  protected MetaRuleset createSubComponentMetaRuleset(Class aClass) {
-    MetaRuleset metaRuleset = super.createMetaRuleset(aClass);
+  protected MetaRuleset createSubComponentMetaRuleset(final Class aClass) {
+    final MetaRuleset metaRuleset = super.createMetaRuleset(aClass);
     //metaRuleset.ignore(Attributes.LABEL);
     metaRuleset.ignore(Attributes.TIP);
     metaRuleset.ignore("labelWidth");
@@ -250,11 +253,11 @@ public abstract class TobagoLabelExtensi
     return metaRuleset;
   }
 
-  protected MetaRuleset createMetaRuleset(Class aClass) {
-    MetaRuleset metaRuleset = super.createMetaRuleset(aClass);
-    TagAttribute[] attrs = tag.getAttributes().getAll();
+  protected MetaRuleset createMetaRuleset(final Class aClass) {
+    final MetaRuleset metaRuleset = super.createMetaRuleset(aClass);
+    final TagAttribute[] attrs = tag.getAttributes().getAll();
     for (int i = 0; i < attrs.length; i++) {
-      TagAttribute attr = attrs[i];
+      final TagAttribute attr = attrs[i];
       if (!attr.getLocalName().equals("rendered")) {
         metaRuleset.ignore(attr.getLocalName());
       }

Modified: myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/facelets/extension/TobagoMenuExtensionHandler.java
URL: http://svn.apache.org/viewvc/myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/facelets/extension/TobagoMenuExtensionHandler.java?rev=1542331&r1=1542330&r2=1542331&view=diff
==============================================================================
--- myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/facelets/extension/TobagoMenuExtensionHandler.java (original)
+++ myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/facelets/extension/TobagoMenuExtensionHandler.java Fri Nov 15 17:10:58 2013
@@ -41,7 +41,7 @@ public abstract class TobagoMenuExtensio
   private Metadata subComponentMapper;
   private TagAttribute fieldIdAttribute;
 
-  public TobagoMenuExtensionHandler(ComponentConfig config) {
+  public TobagoMenuExtensionHandler(final ComponentConfig config) {
     super(config);
     fieldIdAttribute = getAttribute("fieldId");
   }
@@ -52,9 +52,9 @@ public abstract class TobagoMenuExtensio
 
   protected abstract String getFacetName();
 
-  public void applyNextHandler(FaceletContext faceletContext, UIComponent menuCommand) throws IOException {
+  public void applyNextHandler(final FaceletContext faceletContext, final UIComponent menuCommand) throws IOException {
     if (ComponentHandler.isNew(menuCommand)) {
-      UIComponent component = (UIComponent) menuCommand.getFacets().remove(getFacetName());
+      final UIComponent component = (UIComponent) menuCommand.getFacets().remove(getFacetName());
       nextHandler.apply(faceletContext, component);
       menuCommand.getFacets().put(getFacetName(), component);
     } else {
@@ -62,7 +62,8 @@ public abstract class TobagoMenuExtensio
     }
   }
 
-  public void onComponentCreated(FaceletContext faceletContext, UIComponent menuCommand, UIComponent parent) {
+  public void onComponentCreated(
+      final FaceletContext faceletContext, final UIComponent menuCommand, final UIComponent parent) {
 
     final Application application = faceletContext.getFacesContext().getApplication();
     final UIComponent component = application.createComponent(getSubComponentType());
@@ -75,9 +76,9 @@ public abstract class TobagoMenuExtensio
     menuCommand.getFacets().put(getFacetName(), component);
   }
 
-  private void setSubComponentAttributes(FaceletContext ctx, Object instance) {
+  private void setSubComponentAttributes(final FaceletContext ctx, final Object instance) {
     if (instance != null) {
-      Class type = instance.getClass();
+      final Class type = instance.getClass();
       if (subComponentMapper == null || !subComponentLastType.equals(type)) {
         subComponentLastType = type;
         subComponentMapper = createSubComponentMetaRuleset(type).finish();
@@ -86,11 +87,11 @@ public abstract class TobagoMenuExtensio
     }
   }
 
-  protected MetaRuleset createSubComponentMetaRuleset(Class aClass) {
-    MetaRuleset metaRuleset = super.createMetaRuleset(aClass);
-    TagAttribute [] attrs = tag.getAttributes().getAll();
+  protected MetaRuleset createSubComponentMetaRuleset(final Class aClass) {
+    final MetaRuleset metaRuleset = super.createMetaRuleset(aClass);
+    final TagAttribute [] attrs = tag.getAttributes().getAll();
     for (int i = 0; i < attrs.length; i++) {
-      TagAttribute attr = attrs[i];
+      final TagAttribute attr = attrs[i];
       if (!(attr.getLocalName().equals(Attributes.CONVERTER)
           || attr.getLocalName().equals(Attributes.VALUE))) {
         metaRuleset.ignore(attr.getLocalName());
@@ -99,8 +100,8 @@ public abstract class TobagoMenuExtensio
     return metaRuleset;
   }
 
-  protected MetaRuleset createMetaRuleset(Class aClass) {
-    MetaRuleset metaRuleset = super.createMetaRuleset(aClass);
+  protected MetaRuleset createMetaRuleset(final Class aClass) {
+    final MetaRuleset metaRuleset = super.createMetaRuleset(aClass);
     metaRuleset.ignore(Attributes.CONVERTER);
     metaRuleset.ignore(Attributes.VALUE);
     return metaRuleset;

Modified: myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/ajax/AjaxInternalUtils.java
URL: http://svn.apache.org/viewvc/myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/ajax/AjaxInternalUtils.java?rev=1542331&r1=1542330&r2=1542331&view=diff
==============================================================================
--- myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/ajax/AjaxInternalUtils.java (original)
+++ myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/ajax/AjaxInternalUtils.java Fri Nov 15 17:10:58 2013
@@ -50,7 +50,8 @@ public final class AjaxInternalUtils {
   private AjaxInternalUtils() {
   }
 
-  public static void checkParamValidity(FacesContext facesContext, UIComponent uiComponent, Class compClass) {
+  public static void checkParamValidity(
+      final FacesContext facesContext, final UIComponent uiComponent, final Class compClass) {
     if (facesContext == null) {
       throw new NullPointerException("facesContext may not be null");
     }
@@ -66,30 +67,31 @@ public final class AjaxInternalUtils {
     }
   }
 
-  public static void encodeAjaxComponent(FacesContext facesContext, UIComponent component) throws IOException {
+  public static void encodeAjaxComponent(final FacesContext facesContext, final UIComponent component)
+      throws IOException {
     if (facesContext == null) {
       throw new NullPointerException("facesContext");
     }
     if (!component.isRendered()) {
       return;
     }
-    RendererBase renderer = ComponentUtils.getRenderer(facesContext, component);
+    final RendererBase renderer = ComponentUtils.getRenderer(facesContext, component);
     if (renderer != null && renderer instanceof AjaxRenderer) {
       ((AjaxRenderer) renderer).encodeAjax(facesContext, component);
     }
   }
 
-  public static void setRenderAllComponents(FacesContext facesContext) {
-    Map<String, UIComponent> ajaxComponents = new HashMap<String, UIComponent>();
+  public static void setRenderAllComponents(final FacesContext facesContext) {
+    final Map<String, UIComponent> ajaxComponents = new HashMap<String, UIComponent>();
     facesContext.getExternalContext().getRequestMap().put(AJAX_COMPONENTS, ajaxComponents);
-    javax.faces.component.UIViewRoot viewRoot = facesContext.getViewRoot();
-    UIComponent page = viewRoot.getChildren().get(0);
+    final javax.faces.component.UIViewRoot viewRoot = facesContext.getViewRoot();
+    final UIComponent page = viewRoot.getChildren().get(0);
     ajaxComponents.put(page.getClientId(facesContext), page);
   }
 
-  public static void storeMessagesClientIds(FacesContext facesContext, AbstractUIMessages messages) {
-    Map attributes = facesContext.getAttributes();
-    List<String> messageClientIds;
+  public static void storeMessagesClientIds(final FacesContext facesContext, final AbstractUIMessages messages) {
+    final Map attributes = facesContext.getAttributes();
+    final List<String> messageClientIds;
     if (attributes.containsKey(TOBAGO_MESSAGES_CLIENT_IDS)) {
       messageClientIds = (List<String>) attributes.get(TOBAGO_MESSAGES_CLIENT_IDS);
     } else {
@@ -99,20 +101,20 @@ public final class AjaxInternalUtils {
     messageClientIds.add(messages.getClientId(facesContext));
   }
 
-  public static List<String> getMessagesClientIds(FacesContext facesContext) {
+  public static List<String> getMessagesClientIds(final FacesContext facesContext) {
      return (List<String>) facesContext.getAttributes().get(TOBAGO_MESSAGES_CLIENT_IDS);
   }
 
-  public static List<String> getMessagesComponentIds(FacesContext facesContext) {
-    Map parameterMap = facesContext.getExternalContext().getRequestParameterMap();
-    UIComponent component = facesContext.getViewRoot().getChildren().get(0);
-    String clientId = component.getClientId(facesContext);
-    String ids = (String) parameterMap.get(clientId + ComponentUtils.SUB_SEPARATOR + "messagesClientIds");
-    List<String> list = new ArrayList<String>();
+  public static List<String> getMessagesComponentIds(final FacesContext facesContext) {
+    final Map parameterMap = facesContext.getExternalContext().getRequestParameterMap();
+    final UIComponent component = facesContext.getViewRoot().getChildren().get(0);
+    final String clientId = component.getClientId(facesContext);
+    final String ids = (String) parameterMap.get(clientId + ComponentUtils.SUB_SEPARATOR + "messagesClientIds");
+    final List<String> list = new ArrayList<String>();
     if (ids != null) {
-      StringTokenizer tokenizer = new StringTokenizer(ids, ",");
+      final StringTokenizer tokenizer = new StringTokenizer(ids, ",");
       while (tokenizer.hasMoreTokens()) {
-        String id = tokenizer.nextToken();
+        final String id = tokenizer.nextToken();
         list.add(id);
       }
     }
@@ -120,21 +122,21 @@ public final class AjaxInternalUtils {
 
   }
 
-  public static Map<String, UIComponent> parseAndStoreComponents(FacesContext facesContext) {
-    Map parameterMap = facesContext.getExternalContext().getRequestParameterMap();
-    String ajaxComponentIds = (String) parameterMap.get(TOBAGO_PARTIAL_IDS);
+  public static Map<String, UIComponent> parseAndStoreComponents(final FacesContext facesContext) {
+    final Map parameterMap = facesContext.getExternalContext().getRequestParameterMap();
+    final String ajaxComponentIds = (String) parameterMap.get(TOBAGO_PARTIAL_IDS);
     if (ajaxComponentIds != null) {
       if (LOG.isDebugEnabled()) {
         LOG.debug("ajaxComponentIds = \"" + ajaxComponentIds + "\"");
       }
-      StringTokenizer tokenizer = new StringTokenizer(ajaxComponentIds, ",");
-      Map<String, UIComponent> ajaxComponents = new HashMap<String, UIComponent>(tokenizer.countTokens());
+      final StringTokenizer tokenizer = new StringTokenizer(ajaxComponentIds, ",");
+      final Map<String, UIComponent> ajaxComponents = new HashMap<String, UIComponent>(tokenizer.countTokens());
       //noinspection unchecked
       facesContext.getExternalContext().getRequestMap().put(AJAX_COMPONENTS, ajaxComponents);
-      javax.faces.component.UIViewRoot viewRoot = facesContext.getViewRoot();
+      final javax.faces.component.UIViewRoot viewRoot = facesContext.getViewRoot();
       while (tokenizer.hasMoreTokens()) {
-        String ajaxId = tokenizer.nextToken();
-        UIComponent ajaxComponent = viewRoot.findComponent(ajaxId);
+        final String ajaxId = tokenizer.nextToken();
+        final UIComponent ajaxComponent = viewRoot.findComponent(ajaxId);
         if (ajaxComponent != null) {
           if (LOG.isDebugEnabled()) {
             LOG.debug("ajaxComponent for \"" + ajaxId + "\" = \"" + ajaxComponent + "\"");
@@ -147,14 +149,14 @@ public final class AjaxInternalUtils {
     return null;
   }
 
-  public static Map<String, UIComponent> getAjaxComponents(FacesContext facesContext) {
+  public static Map<String, UIComponent> getAjaxComponents(final FacesContext facesContext) {
     //noinspection unchecked
     return (Map<String, UIComponent>)
         facesContext.getExternalContext().getRequestMap().get(AJAX_COMPONENTS);
   }
 
-  public static void addAjaxComponent(FacesContext facesContext, UIComponent component) {
-    Map<String, UIComponent> ajaxComponents =
+  public static void addAjaxComponent(final FacesContext facesContext, final UIComponent component) {
+    final Map<String, UIComponent> ajaxComponents =
         (Map<String, UIComponent>) facesContext.getExternalContext().getRequestMap().get(AJAX_COMPONENTS);
     if (ajaxComponents != null) {
       if (!alreadyContained(component, ajaxComponents)) {
@@ -163,15 +165,15 @@ public final class AjaxInternalUtils {
     }
   }
 
-  public static String encodeJavaScriptString(String value) {
+  public static String encodeJavaScriptString(final String value) {
     String result = StringUtils.replace(value, "\\", "\\\\");
     result = StringUtils.replace(result, "\n", "\\n");
     result = StringUtils.replace(result, "\r", "\\r");
     return StringUtils.replace(result, "\"", "\\\"");
   }
 
-  public static boolean alreadyContained(UIComponent component, Map<String, UIComponent> ajaxComponents) {
-    for (UIComponent uiComponent : ajaxComponents.values()) {
+  public static boolean alreadyContained(final UIComponent component, final Map<String, UIComponent> ajaxComponents) {
+    for (final UIComponent uiComponent : ajaxComponents.values()) {
       // is component or a parent of it in the list?
       UIComponent parent = component;
       while (parent != null) {
@@ -185,7 +187,7 @@ public final class AjaxInternalUtils {
     return false;
   }
 
-  public static boolean addNextPossibleAjaxComponent(FacesContext context, String componentClientId) {
+  public static boolean addNextPossibleAjaxComponent(final FacesContext context, final String componentClientId) {
     UIComponent component = ComponentUtils.findComponent(context.getViewRoot(), componentClientId);
     component = component.getParent();
     if (component instanceof UIPanel) {
@@ -198,16 +200,16 @@ public final class AjaxInternalUtils {
     }
   }
 
-  public static void ensureDecoded(FacesContext facesContext, String clientId) {
+  public static void ensureDecoded(final FacesContext facesContext, final String clientId) {
     ensureDecoded(facesContext, facesContext.getViewRoot().findComponent(clientId));
   }
 
-  public static void ensureDecoded(FacesContext facesContext, UIComponent component) {
+  public static void ensureDecoded(final FacesContext facesContext, final UIComponent component) {
     if (component == null) {
       LOG.warn("Ignore AjaxComponent: null");
       return;
     }
-    Map<String, UIComponent> ajaxComponents = getAjaxComponents(facesContext);
+    final Map<String, UIComponent> ajaxComponents = getAjaxComponents(facesContext);
     if (ajaxComponents != null) {
       if (!alreadyContained(component, ajaxComponents)) {
         component.processDecodes(facesContext);

Modified: myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/ajax/AjaxNavigationListener.java
URL: http://svn.apache.org/viewvc/myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/ajax/AjaxNavigationListener.java?rev=1542331&r1=1542330&r2=1542331&view=diff
==============================================================================
--- myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/ajax/AjaxNavigationListener.java (original)
+++ myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/ajax/AjaxNavigationListener.java Fri Nov 15 17:10:58 2013
@@ -25,13 +25,13 @@ import javax.faces.event.PhaseListener;
 
 public class AjaxNavigationListener implements PhaseListener {
 
-  public void afterPhase(PhaseEvent phaseEvent) {
+  public void afterPhase(final PhaseEvent phaseEvent) {
     if (phaseEvent.getPhaseId() == PhaseId.RESTORE_VIEW) {
       AjaxNavigationState.storeIncomingView(phaseEvent.getFacesContext());
     }
   }
 
-  public void beforePhase(PhaseEvent phaseEvent) {
+  public void beforePhase(final PhaseEvent phaseEvent) {
     if (phaseEvent.getPhaseId() == PhaseId.RESTORE_VIEW) {
       AjaxNavigationState.handleNavigation(phaseEvent.getFacesContext());
     }

Modified: myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/ajax/AjaxNavigationState.java
URL: http://svn.apache.org/viewvc/myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/ajax/AjaxNavigationState.java?rev=1542331&r1=1542330&r2=1542331&view=diff
==============================================================================
--- myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/ajax/AjaxNavigationState.java (original)
+++ myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/ajax/AjaxNavigationState.java Fri Nov 15 17:10:58 2013
@@ -44,33 +44,33 @@ public final class AjaxNavigationState {
 
   private Map<String, List<FacesMessage>> messages;
 
-  private AjaxNavigationState(FacesContext facesContext) {
-    ExternalContext externalContext = facesContext.getExternalContext();
+  private AjaxNavigationState(final FacesContext facesContext) {
+    final ExternalContext externalContext = facesContext.getExternalContext();
     externalContext.getSessionMap().put(SESSION_KEY, this);
     viewRoot = facesContext.getViewRoot();
     messages = new HashMap<String, List<FacesMessage>>();
-    Iterator<String> iterator = facesContext.getClientIdsWithMessages();
+    final Iterator<String> iterator = facesContext.getClientIdsWithMessages();
     while (iterator.hasNext()) {
       addFacesMessages(facesContext, iterator.next());
     }
     if (LOG.isTraceEnabled()) {
       LOG.trace("Saved viewRoot.getViewId() = \"{}\"", viewRoot.getViewId());
-      for (Map.Entry<String, List<FacesMessage>> entry : messages.entrySet()) {
-        for (FacesMessage message : entry.getValue()) {
+      for (final Map.Entry<String, List<FacesMessage>> entry : messages.entrySet()) {
+        for (final FacesMessage message : entry.getValue()) {
           LOG.trace("Saved message \"{}\" : \"{}\"", entry.getKey(), message);
         }
       }
     }
   }
 
-  private void addFacesMessages(FacesContext facesContext, String clientId) {
-    Iterator<FacesMessage> facesMessages = facesContext.getMessages(clientId);
+  private void addFacesMessages(final FacesContext facesContext, final String clientId) {
+    final Iterator<FacesMessage> facesMessages = facesContext.getMessages(clientId);
     while (facesMessages.hasNext()) {
       addFacesMessage(clientId, facesMessages.next());
     }
   }
 
-  private void addFacesMessage(String clientId, FacesMessage facesMessage) {
+  private void addFacesMessage(final String clientId, final FacesMessage facesMessage) {
     List<FacesMessage> facesMessages = messages.get(clientId);
     if (facesMessages == null) {
       facesMessages = new ArrayList<FacesMessage>();
@@ -79,18 +79,18 @@ public final class AjaxNavigationState {
     facesMessages.add(facesMessage);
   }
 
-  private void restoreView(FacesContext facesContext) {
+  private void restoreView(final FacesContext facesContext) {
     facesContext.setViewRoot(viewRoot);
-    for (Map.Entry<String, List<FacesMessage>> entry : messages.entrySet()) {
-      for (FacesMessage facesMessage : entry.getValue()) {
+    for (final Map.Entry<String, List<FacesMessage>> entry : messages.entrySet()) {
+      for (final FacesMessage facesMessage : entry.getValue()) {
         facesContext.addMessage(entry.getKey(), facesMessage);
       }
     }
     facesContext.renderResponse();
     if (LOG.isTraceEnabled()) {
       LOG.trace("Restored viewRoot.getViewId() = \"{}\"", viewRoot.getViewId());
-      for (Map.Entry<String, List<FacesMessage>> entry : messages.entrySet()) {
-        for (FacesMessage message : entry.getValue()) {
+      for (final Map.Entry<String, List<FacesMessage>> entry : messages.entrySet()) {
+        for (final FacesMessage message : entry.getValue()) {
           LOG.trace("Restored message \"{}\" : \"{}\"", entry.getKey(), message);
         }
       }
@@ -98,7 +98,7 @@ public final class AjaxNavigationState {
 
   }
 
-  public static void storeIncomingView(FacesContext facesContext) {
+  public static void storeIncomingView(final FacesContext facesContext) {
     final UIViewRoot viewRoot = facesContext.getViewRoot();
     if (LOG.isTraceEnabled()) {
       if (viewRoot != null) {
@@ -110,7 +110,7 @@ public final class AjaxNavigationState {
     facesContext.getExternalContext().getRequestMap().put(AjaxNavigationState.VIEW_ROOT_KEY, viewRoot);
   }
 
-  public static boolean isNavigation(FacesContext facesContext) {
+  public static boolean isNavigation(final FacesContext facesContext) {
 
     final UIViewRoot viewRoot = facesContext.getViewRoot();
     if (viewRoot != null) {
@@ -136,9 +136,10 @@ public final class AjaxNavigationState {
     return false;
   }
 
-  public static void handleNavigation(FacesContext facesContext) {
-    Map<String, Object> sessionMap = facesContext.getExternalContext().getSessionMap();
-    AjaxNavigationState navigationState = (AjaxNavigationState) sessionMap.remove(AjaxNavigationState.SESSION_KEY);
+  public static void handleNavigation(final FacesContext facesContext) {
+    final Map<String, Object> sessionMap = facesContext.getExternalContext().getSessionMap();
+    final AjaxNavigationState navigationState
+        = (AjaxNavigationState) sessionMap.remove(AjaxNavigationState.SESSION_KEY);
     if (navigationState != null) {
       navigationState.restoreView(facesContext);
       LOG.trace("force render requested navigation view");

Modified: myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/ajax/AjaxResponseRenderer.java
URL: http://svn.apache.org/viewvc/myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/ajax/AjaxResponseRenderer.java?rev=1542331&r1=1542330&r2=1542331&view=diff
==============================================================================
--- myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/ajax/AjaxResponseRenderer.java (original)
+++ myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/ajax/AjaxResponseRenderer.java Fri Nov 15 17:10:58 2013
@@ -64,14 +64,16 @@ public class AjaxResponseRenderer {
     callback = new EncodeAjaxCallback();
   }
 
-  public void renderResponse(FacesContext facesContext) throws IOException {
+  public void renderResponse(final FacesContext facesContext) throws IOException {
     final UIViewRoot viewRoot = facesContext.getViewRoot();
-    RenderKitFactory renderFactory = (RenderKitFactory) FactoryFinder.getFactory(FactoryFinder.RENDER_KIT_FACTORY);
-    RenderKit renderKit = renderFactory.getRenderKit(facesContext, viewRoot.getRenderKitId());
+    final RenderKitFactory renderFactory
+        = (RenderKitFactory) FactoryFinder.getFactory(FactoryFinder.RENDER_KIT_FACTORY);
+    final RenderKit renderKit = renderFactory.getRenderKit(facesContext, viewRoot.getRenderKitId());
     writeResponse(facesContext, renderKit, AjaxNavigationState.isNavigation(facesContext));
   }
 
-  private void renderComponent(FacesContext facesContext, RenderKit renderKit, String clientId, UIComponent component)
+  private void renderComponent(
+      final FacesContext facesContext, final RenderKit renderKit, final String clientId, final UIComponent component)
       throws IOException {
     final PrintWriter writer = getPrintWriter(facesContext);
     final JsonResponseWriter jsonWriter = getJsonResponseWriter(renderKit, writer);
@@ -102,7 +104,7 @@ public class AjaxResponseRenderer {
     writer.write("\n  }");
   }
 
-  private void saveState(FacesContext facesContext, RenderKit renderKit) throws IOException {
+  private void saveState(final FacesContext facesContext, final RenderKit renderKit) throws IOException {
 
     final ResponseWriter stateWriter = renderKit.createResponseWriter(getPrintWriter(facesContext), CONTENT_TYPE, null);
     facesContext.setResponseWriter(stateWriter);
@@ -112,8 +114,9 @@ public class AjaxResponseRenderer {
     stateManager.writeState(facesContext, serializedView);
   }
 
-  private static void ensureContentTypeHeader(FacesContext facesContext, String charset, String contentType) {
-    StringBuilder sb = new StringBuilder(contentType);
+  private static void ensureContentTypeHeader(
+      final FacesContext facesContext, String charset, final String contentType) {
+    final StringBuilder sb = new StringBuilder(contentType);
     if (charset == null) {
       charset = "UTF-8";
     }
@@ -122,13 +125,13 @@ public class AjaxResponseRenderer {
     ResponseUtils.ensureContentTypeHeader(facesContext, sb.toString());
   }
 
-  private void writeResponse(FacesContext facesContext, RenderKit renderKit, boolean reloadRequired)
+  private void writeResponse(final FacesContext facesContext, final RenderKit renderKit, final boolean reloadRequired)
       throws IOException {
 
     RequestUtils.ensureEncoding(facesContext);
     ResponseUtils.ensureNoCacheHeader(facesContext);
-    UIComponent page = ComponentUtils.findPage(facesContext);
-    String charset;
+    final UIComponent page = ComponentUtils.findPage(facesContext);
+    final String charset;
     if (page != null) {  // in case of CODE_RELOAD_REQUIRED page is null
       charset = (String) page.getAttributes().get(Attributes.CHARSET);
     } else {
@@ -136,21 +139,21 @@ public class AjaxResponseRenderer {
     }
     ensureContentTypeHeader(facesContext, charset, CONTENT_TYPE);
 
-    PrintWriter writer = getPrintWriter(facesContext);
+    final PrintWriter writer = getPrintWriter(facesContext);
     writer.write("{\n  \"tobagoAjaxResponse\": true,\n");
     writer.write("  \"responseCode\": ");
     writer.write(reloadRequired ? Integer.toString(CODE_RELOAD_REQUIRED) : Integer.toString(CODE_SUCCESS));
 
-    Map<String, UIComponent> ajaxComponents = AjaxInternalUtils.getAjaxComponents(facesContext);
+    final Map<String, UIComponent> ajaxComponents = AjaxInternalUtils.getAjaxComponents(facesContext);
     if (!reloadRequired && ajaxComponents != null) {
       int i = 0;
-      for (Map.Entry<String, UIComponent> entry : ajaxComponents.entrySet()) {
+      for (final Map.Entry<String, UIComponent> entry : ajaxComponents.entrySet()) {
         writer.write(",\n");
         writer.write("  \"ajaxPart_");
         writer.write(Integer.toString(i++));
         writer.write("\": ");
 
-        UIComponent component = entry.getValue();
+        final UIComponent component = entry.getValue();
         FacesContextUtils.setAjaxComponentId(facesContext, entry.getKey());
         renderComponent(facesContext, renderKit, entry.getKey(), component);
       }
@@ -168,7 +171,7 @@ public class AjaxResponseRenderer {
     writer.close();
   }
 
-  private PrintWriter getPrintWriter(FacesContext facesContext) throws IOException {
+  private PrintWriter getPrintWriter(final FacesContext facesContext) throws IOException {
     final Object response = facesContext.getExternalContext().getResponse();
     if (response instanceof HttpServletResponse) {
       return ((HttpServletResponse) response).getWriter();
@@ -178,9 +181,9 @@ public class AjaxResponseRenderer {
     throw new IOException("No ResponseWriter found for response " + response);
   }
 
-  private JsonResponseWriter getJsonResponseWriter(RenderKit renderKit, PrintWriter writer) {
+  private JsonResponseWriter getJsonResponseWriter(final RenderKit renderKit, final PrintWriter writer) {
 
-    ResponseWriter newWriter = renderKit.createResponseWriter(writer, CONTENT_TYPE, null);
+    final ResponseWriter newWriter = renderKit.createResponseWriter(writer, CONTENT_TYPE, null);
     if (newWriter instanceof JsonResponseWriter) {
       return (JsonResponseWriter) newWriter;
     } else {

Modified: myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/component/AbstractUIBox.java
URL: http://svn.apache.org/viewvc/myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/component/AbstractUIBox.java?rev=1542331&r1=1542330&r2=1542331&view=diff
==============================================================================
--- myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/component/AbstractUIBox.java (original)
+++ myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/component/AbstractUIBox.java Fri Nov 15 17:10:58 2013
@@ -24,7 +24,7 @@ import javax.faces.context.FacesContext;
 public abstract class AbstractUIBox extends AbstractUIPanel {
 
   @Override
-  public void processDecodes(FacesContext context) {
+  public void processDecodes(final FacesContext context) {
     if (isCollapsed()) {
       decode(context);
     } else {
@@ -33,14 +33,14 @@ public abstract class AbstractUIBox exte
   }
 
   @Override
-  public void processValidators(FacesContext context) {
+  public void processValidators(final FacesContext context) {
     if (!isCollapsed()) {
       super.processValidators(context);
     }
   }
 
   @Override
-  public void processUpdates(FacesContext context) {
+  public void processUpdates(final FacesContext context) {
     if (!isCollapsed()) {
       super.processUpdates(context);
     }

Modified: myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/component/AbstractUICell.java
URL: http://svn.apache.org/viewvc/myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/component/AbstractUICell.java?rev=1542331&r1=1542330&r2=1542331&view=diff
==============================================================================
--- myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/component/AbstractUICell.java (original)
+++ myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/component/AbstractUICell.java Fri Nov 15 17:10:58 2013
@@ -37,7 +37,7 @@ public abstract class AbstractUICell ext
     return getColumnSpan();
   }
 
-  public void setSpanX(Integer spanX) {
+  public void setSpanX(final Integer spanX) {
     setColumnSpan(spanX);
   }
 
@@ -45,7 +45,7 @@ public abstract class AbstractUICell ext
     return getRowSpan();
   }
 
-  public void setSpanY(Integer spanY) {
+  public void setSpanY(final Integer spanY) {
     setRowSpan(spanY);
   }
 }

Modified: myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/component/AbstractUICommandBase.java
URL: http://svn.apache.org/viewvc/myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/component/AbstractUICommandBase.java?rev=1542331&r1=1542330&r2=1542331&view=diff
==============================================================================
--- myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/component/AbstractUICommandBase.java (original)
+++ myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/component/AbstractUICommandBase.java Fri Nov 15 17:10:58 2013
@@ -34,8 +34,8 @@ import java.util.Iterator;
 public abstract class AbstractUICommandBase extends javax.faces.component.UICommand
     implements SupportsRenderedPartially, OnComponentPopulated {
 
-  public void onComponentPopulated(FacesContext facesContext, UIComponent parent) {
-    AbstractUIPopup popup = (AbstractUIPopup) getFacet(Facets.POPUP);
+  public void onComponentPopulated(final FacesContext facesContext, final UIComponent parent) {
+    final AbstractUIPopup popup = (AbstractUIPopup) getFacet(Facets.POPUP);
     if (popup != null) {
       if (!ComponentUtils.containsPopupActionListener(this)) {
         addActionListener(new PopupFacetActionListener());
@@ -43,7 +43,7 @@ public abstract class AbstractUICommandB
     }
   }
 
-  public void processDecodes(FacesContext context) {
+  public void processDecodes(final FacesContext context) {
     if (context == null) {
       throw new NullPointerException();
     }
@@ -56,19 +56,19 @@ public abstract class AbstractUICommandB
     // Process this component itself
     try {
       decode(context);
-    } catch (RuntimeException e) {
+    } catch (final RuntimeException e) {
       context.renderResponse();
       throw e;
     }
 
-    Iterator kids = getFacetsAndChildren();
+    final Iterator kids = getFacetsAndChildren();
     while (kids.hasNext()) {
-      UIComponent kid = (UIComponent) kids.next();
+      final UIComponent kid = (UIComponent) kids.next();
       kid.processDecodes(context);
     }
   }
 
-  public void queueEvent(FacesEvent facesEvent) {
+  public void queueEvent(final FacesEvent facesEvent) {
     // fix for TOBAGO-262
     super.queueEvent(facesEvent);
     if (this == facesEvent.getSource()) {

Modified: myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/component/AbstractUIData.java
URL: http://svn.apache.org/viewvc/myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/component/AbstractUIData.java?rev=1542331&r1=1542330&r2=1542331&view=diff
==============================================================================
--- myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/component/AbstractUIData.java (original)
+++ myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/component/AbstractUIData.java Fri Nov 15 17:10:58 2013
@@ -88,8 +88,8 @@ public abstract class AbstractUIData ext
 
   private void init() {
     if (!initialized) {
-      Object value = getValue();
-      boolean showRoot = isShowRoot();
+      final Object value = getValue();
+      final boolean showRoot = isShowRoot();
       createTreeDataModel(value, showRoot);
 
       initialized = true;
@@ -112,7 +112,7 @@ public abstract class AbstractUIData ext
    *              (comes from the value attribute of the {@link javax.faces.component.UIData})
    * @param showRoot comes from the showRoot attribute.
    */
-  protected void createTreeDataModel(Object value, boolean showRoot) {
+  protected void createTreeDataModel(final Object value, final boolean showRoot) {
     // TODO: use a factory
     if (value instanceof TreeNode) {
       dataModel = new TreeNodeDataModel((TreeNode) value, showRoot, getExpandedState());
@@ -120,7 +120,7 @@ public abstract class AbstractUIData ext
   }
 
   @Override
-  public void encodeBegin(FacesContext context) throws IOException {
+  public void encodeBegin(final FacesContext context) throws IOException {
     initialized = false;
     init();
     if (dataModel != null) {
@@ -184,13 +184,14 @@ public abstract class AbstractUIData ext
     return false;
   }
 
-    // todo: after removing jsf 1.1: @Override
-  public boolean invokeOnComponent(FacesContext facesContext, String clientId, ContextCallback callback)
+  // todo: after removing jsf 1.1: @Override
+  public boolean invokeOnComponent(
+      final FacesContext facesContext, final String clientId, final ContextCallback callback)
       throws FacesException {
     // we may need setRowIndex on UISheet
-    int oldRowIndex = getRowIndex();
+    final int oldRowIndex = getRowIndex();
     try {
-      String sheetId = getClientId(facesContext);
+      final String sheetId = getClientId(facesContext);
       if (clientId.startsWith(sheetId)) {
         String idRemainder = clientId.substring(sheetId.length());
         if (LOG.isDebugEnabled()) {
@@ -198,14 +199,14 @@ public abstract class AbstractUIData ext
         }
         if (idRemainder.matches("^:\\d+:.*")) {
           idRemainder = idRemainder.substring(1);
-          int idx = idRemainder.indexOf(":");
+          final int idx = idRemainder.indexOf(":");
           try {
-            int rowIndex = Integer.parseInt(idRemainder.substring(0, idx));
+            final int rowIndex = Integer.parseInt(idRemainder.substring(0, idx));
             if (LOG.isDebugEnabled()) {
               LOG.debug("set rowIndex = '" + rowIndex + "'");
             }
             setRowIndex(rowIndex);
-          } catch (NumberFormatException e) {
+          } catch (final NumberFormatException e) {
             LOG.warn("idRemainder = '" + idRemainder + "'", e);
           }
         } else {

Modified: myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/component/AbstractUIDatePicker.java
URL: http://svn.apache.org/viewvc/myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/component/AbstractUIDatePicker.java?rev=1542331&r1=1542330&r2=1542331&view=diff
==============================================================================
--- myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/component/AbstractUIDatePicker.java (original)
+++ myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/component/AbstractUIDatePicker.java Fri Nov 15 17:10:58 2013
@@ -45,22 +45,22 @@ public abstract class AbstractUIDatePick
     return ComponentUtils.findFor(this);
   }
 
-  public void broadcast(FacesEvent facesEvent) {
-    FacesContext facesContext = FacesContext.getCurrentInstance();
-    UIComponent popup = (UIComponent) getFacets().get(Facets.POPUP);
-    String clientId = getForComponent().getClientId(facesContext);
-    UIComponent box = popup.findComponent("box");
-    UIComponent calendar = box.findComponent("calendar");
+  public void broadcast(final FacesEvent facesEvent) {
+    final FacesContext facesContext = FacesContext.getCurrentInstance();
+    final UIComponent popup = (UIComponent) getFacets().get(Facets.POPUP);
+    final String clientId = getForComponent().getClientId(facesContext);
+    final UIComponent box = popup.findComponent("box");
+    final UIComponent calendar = box.findComponent("calendar");
     calendar.getAttributes().put(Attributes.DATE_INPUT_ID, clientId);
-    UIComponent time = box.findComponent("time");
+    final UIComponent time = box.findComponent("time");
     if (time != null) {
       time.getAttributes().put(Attributes.DATE_INPUT_ID, clientId);
     }
     super.broadcast(facesEvent);
   }
 
-  public void onComponentCreated(FacesContext context, UIComponent parent) {
-    Renderer renderer = getRenderer(getFacesContext());
+  public void onComponentCreated(final FacesContext context, final UIComponent parent) {
+    final Renderer renderer = getRenderer(getFacesContext());
     if (renderer instanceof RendererBase) {
       ((RendererBase) renderer).onComponentCreated(context, this, parent);
     }

Modified: myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/component/AbstractUIFile.java
URL: http://svn.apache.org/viewvc/myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/component/AbstractUIFile.java?rev=1542331&r1=1542330&r2=1542331&view=diff
==============================================================================
--- myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/component/AbstractUIFile.java (original)
+++ myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/component/AbstractUIFile.java Fri Nov 15 17:10:58 2013
@@ -30,10 +30,10 @@ import javax.faces.context.FacesContext;
 
 public abstract class AbstractUIFile extends UIInput implements LayoutComponent, UIFileInput {
 
-  public void validate(FacesContext facesContext) {
+  public void validate(final FacesContext facesContext) {
     if (isRequired()) {
       if (getSubmittedValue() instanceof FileItem) {
-        FileItem file = (FileItem) getSubmittedValue();
+        final FileItem file = (FileItem) getSubmittedValue();
         if (file == null || file.getName().length() == 0) {
           addErrorMessage(facesContext);
           setValid(false);
@@ -46,7 +46,7 @@ public abstract class AbstractUIFile ext
     super.validate(facesContext);
   }
 
-  private void addErrorMessage(FacesContext facesContext) {
+  private void addErrorMessage(final FacesContext facesContext) {
     MessageUtils.addMessage(
         facesContext, this, FacesMessage.SEVERITY_ERROR, REQUIRED_MESSAGE_ID, new Object[]{getId()});
   }

Modified: myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/component/AbstractUIFlowLayout.java
URL: http://svn.apache.org/viewvc/myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/component/AbstractUIFlowLayout.java?rev=1542331&r1=1542330&r2=1542331&view=diff
==============================================================================
--- myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/component/AbstractUIFlowLayout.java (original)
+++ myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/component/AbstractUIFlowLayout.java Fri Nov 15 17:10:58 2013
@@ -30,16 +30,16 @@ public abstract class AbstractUIFlowLayo
   public void init() {
   }
 
-  public void fixRelativeInsideAuto(Orientation orientation, boolean auto) {
+  public void fixRelativeInsideAuto(final Orientation orientation, final boolean auto) {
   }
 
-  public void preProcessing(Orientation orientation) {
+  public void preProcessing(final Orientation orientation) {
   }
 
-  public void mainProcessing(Orientation orientation) {
+  public void mainProcessing(final Orientation orientation) {
     
   }
 
-  public void postProcessing(Orientation orientation) {
+  public void postProcessing(final Orientation orientation) {
   }
 }

Modified: myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/component/AbstractUIForm.java
URL: http://svn.apache.org/viewvc/myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/component/AbstractUIForm.java?rev=1542331&r1=1542330&r2=1542331&view=diff
==============================================================================
--- myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/component/AbstractUIForm.java (original)
+++ myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/component/AbstractUIForm.java Fri Nov 15 17:10:58 2013
@@ -42,72 +42,72 @@ public abstract class AbstractUIForm ext
   public static final String SUBMITTED_MARKER = COMPONENT_TYPE + ".InSubmitted";
 
   @Override
-  public void processDecodes(FacesContext facesContext) {
+  public void processDecodes(final FacesContext facesContext) {
 
     // Process this component first
     // to know the active actionId
     // for the following childrend
     decode(facesContext);
 
-    Iterator kids = getFacetsAndChildren();
+    final Iterator kids = getFacetsAndChildren();
     while (kids.hasNext()) {
-      UIComponent kid = (UIComponent) kids.next();
+      final UIComponent kid = (UIComponent) kids.next();
       kid.processDecodes(facesContext);
     }
   }
 
   @Override
-  public void setSubmitted(boolean b) {
+  public void setSubmitted(final boolean b) {
     super.setSubmitted(b);
 
     // set submitted for all subforms
-    for (AbstractUIForm subForm : ComponentUtils.findSubForms(this)) {
+    for (final AbstractUIForm subForm : ComponentUtils.findSubForms(this)) {
       subForm.setSubmitted(b);
     }
   }
 
   @Override
-  public void processValidators(FacesContext facesContext) {
+  public void processValidators(final FacesContext facesContext) {
     // if we're not the submitted form, only process subforms.
     if (LOG.isDebugEnabled()) {
       LOG.debug("processValidators for form: {}", getClientId(facesContext));
     }
     if (!isSubmitted()) {
-      for (AbstractUIForm subForm : ComponentUtils.findSubForms(this)) {
+      for (final AbstractUIForm subForm : ComponentUtils.findSubForms(this)) {
         subForm.processValidators(facesContext);
       }
     } else {
       // Process all facets and children of this component
-      Iterator kids = getFacetsAndChildren();
+      final Iterator kids = getFacetsAndChildren();
       while (kids.hasNext()) {
-        UIComponent kid = (UIComponent) kids.next();
+        final UIComponent kid = (UIComponent) kids.next();
         kid.processValidators(facesContext);
       }
     }
   }
 
   @Override
-  public void processUpdates(FacesContext facesContext) {
+  public void processUpdates(final FacesContext facesContext) {
     // if we're not the submitted form, only process subforms.
     if (LOG.isDebugEnabled()) {
       LOG.debug("processUpdates for form: {}", getClientId(facesContext));
     }
     if (!isSubmitted()) {
-      for (AbstractUIForm subForm : ComponentUtils.findSubForms(this)) {
+      for (final AbstractUIForm subForm : ComponentUtils.findSubForms(this)) {
         subForm.processUpdates(facesContext);
       }
     } else {
       // Process all facets and children of this component
-      Iterator kids = getFacetsAndChildren();
+      final Iterator kids = getFacetsAndChildren();
       while (kids.hasNext()) {
-        UIComponent kid = (UIComponent) kids.next();
+        final UIComponent kid = (UIComponent) kids.next();
         kid.processUpdates(facesContext);
       }
     }
   }
 
   @Override
-  public boolean invokeOnComponent(FacesContext context, String clientId, ContextCallback callback)
+  public boolean invokeOnComponent(final FacesContext context, final String clientId, final ContextCallback callback)
       throws FacesException {
     // TODO is this needed?
     if (callback instanceof TobagoCallback) {