Re: Review Request 17531: CLOUDSTACK-5440 - Added new guest OS types.

[Devdeep Singh <de...@citrix.com>]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17531/#review34168
-----------------------------------------------------------


Can you make these changes in master branch on schema-430to440.sql file? Since a RC has already been cut for 4.3, we can put these changes in 4.4 release so that on upgrade from 4.3; these changes will come in.


setup/db/db/schema-421to430.sql
<https://reviews.apache.org/r/17531/#comment64187>

    Can you fix the id values to 225, 226 and 227? The current values go till 224. We can begin from there. Reason being the guest_os_hypervisor table refers the field on this table by 'id'. It would be good to have fixed values for the new os types.



setup/db/db/schema-421to430.sql
<https://reviews.apache.org/r/17531/#comment64186>

    Could you make separate entries for Windows 8.1 (32 bit). and Windows 8.1 (64 bit). Similarly for Windows Server 2012 R2. Similar pattern has been followed for all windows sku.


- Devdeep Singh


On Jan. 30, 2014, 11:18 a.m., Alexander Hitchins wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17531/
> -----------------------------------------------------------
> 
> (Updated Jan. 30, 2014, 11:18 a.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Added new guest OS types in upgrade script.
> 
> 
> Diffs
> -----
> 
>   setup/db/db/schema-421to430.sql afad06c 
> 
> Diff: https://reviews.apache.org/r/17531/diff/
> 
> 
> Testing
> -------
> 
> Ran new SQL, no errors, checked table, contains correct data.
> 
> 
> Thanks,
> 
> Alexander Hitchins
> 
>