[Bug 56546] Improve thread trace logging in WebappClassLoader.clearReferencesThreads()

[bu...@apache.org]

https://issues.apache.org/bugzilla/show_bug.cgi?id=56546

Konstantin Kolinko <kn...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 OS|                            |All

--- Comment #1 from Konstantin Kolinko <kn...@gmail.com> ---
Possible ways to improve this:

A. Reduce the log level for stack trace message from log.error() to log.info().
In the current code there are two "log.error()" messages at once, which looks
like overkill.

> log.error(sm.getString("webappClassLoader.warnThread",
>   getContextName(), threadName));
> log.error(sm.getString("webappClassLoader.stackTrace",
>   threadName, getStackTrace(thread)));

B. Make this an opt-in feature. A new property on <Context>?
Or two properties, to distinct handling of "request threads" vs. "non-request"
threads.

C. Merge similar logs into a single message?
(E.g. if there are many request threads that are stuck in the same place).

I think "A." is a good and easy way to go.

Any additional ideas, concerns?

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org