You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/01/28 15:21:39 UTC
[GitHub] [incubator-nuttx] patacongo opened a new pull request #173:
tools/nxstyle.c: Detect blank line before opening left brace
patacongo opened a new pull request #173: tools/nxstyle.c: Detect blank line before opening left brace
URL: https://github.com/apache/incubator-nuttx/pull/173
Add logic to detect check for left brace in first column, but preceded by a blank line. That should never happen for the outermost opening branch (but could happen with internal compound statements).
Consider junk.c for example:
/****************************************************************************
* xx
****************************************************************************/
/****************************************************************************
* Private Types
****************************************************************************/
struct foo_s
{
int bar;
};
/****************************************************************************
* Public Functions
****************************************************************************/
int dofoo(int barin)
{
barout = barin;
return barout;
}
nxstyle not detects these problems:
$ tools/nxstyle.exe junk.c
junk.c:11:0: error: Blank line before opening left brace
junk.c:21:0: error: Blank line before opening left brace
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] acassis merged pull request #173:
tools/nxstyle.c: Detect blank line before opening left brace
Posted by GitBox <gi...@apache.org>.
acassis merged pull request #173: tools/nxstyle.c: Detect blank line before opening left brace
URL: https://github.com/apache/incubator-nuttx/pull/173
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services