You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/06/09 16:20:12 UTC
[GitHub] [flink] tillrohrmann commented on a change in pull request #12505: [FLINK-17765] Simplify Flink stack traces
tillrohrmann commented on a change in pull request #12505:
URL: https://github.com/apache/flink/pull/12505#discussion_r437280831
##########
File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/StreamExecutionEnvironment.java
##########
@@ -1801,12 +1802,13 @@ public JobClient executeAsync(StreamGraph streamGraph) throws Exception {
JobClient jobClient = jobClientFuture.get();
jobListeners.forEach(jobListener -> jobListener.onJobSubmitted(jobClient, null));
return jobClient;
- } catch (Throwable t) {
- jobListeners.forEach(jobListener -> jobListener.onJobSubmitted(null, t));
- ExceptionUtils.rethrow(t);
+ } catch (ExecutionException executionException) {
+ final Throwable strippedException = ExceptionUtils.stripExecutionException(executionException);
+ jobListeners.forEach(jobListener -> jobListener.onJobSubmitted(null, strippedException));
- // make javac happy, this code path will not be reached
- return null;
+ throw new FlinkException(
+ String.format("Failed to execute job '%s' asynchronously.", streamGraph.getJobName()),
Review comment:
True, I will remove the `asynchronously`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org