You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by venkat sairam <ve...@gmail.com> on 2017/06/15 09:15:51 UTC
Review Request 60114: Remove YARN client mode option from WFM
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60114/
-----------------------------------------------------------
Review request for Ambari, belliraj hb, Padma Priya N, Pallav Kulshreshtha, and Rohit Choudhary.
Bugs: AMBARI-21255
https://issues.apache.org/jira/browse/AMBARI-21255
Repository: ambari
Description
-------
YARN client mode have been removed from WFD as oozie doesnt support Yarn client mode
Diffs
-----
contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js 1cfe755
contrib/views/wfmanager/src/main/resources/ui/app/domain/actionjob_hanlder.js c9dc751
contrib/views/wfmanager/src/main/resources/ui/app/templates/components/flow-designer.hbs 8c07d6d
contrib/views/wfmanager/src/main/resources/ui/app/templates/components/spark-action.hbs de62e77
contrib/views/wfmanager/src/main/resources/ui/app/utils/constants.js bf858d8
Diff: https://reviews.apache.org/r/60114/diff/1/
Testing
-------
Manual testing done.
Thanks,
venkat sairam
Re: Review Request 60114: Remove YARN client mode option from WFM
Posted by Padma Priya N <pa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60114/#review178466
-----------------------------------------------------------
Ship it!
Ship It!
- Padma Priya N
On June 20, 2017, 5:59 p.m., venkat sairam wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60114/
> -----------------------------------------------------------
>
> (Updated June 20, 2017, 5:59 p.m.)
>
>
> Review request for Ambari, belliraj hb, Padma Priya N, Pallav Kulshreshtha, and Rohit Choudhary.
>
>
> Bugs: AMBARI-21255
> https://issues.apache.org/jira/browse/AMBARI-21255
>
>
> Repository: ambari
>
>
> Description
> -------
>
> YARN client mode have been removed from WFD as oozie doesnt support Yarn client mode
>
>
> Diffs
> -----
>
> contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js 1cfe755
> contrib/views/wfmanager/src/main/resources/ui/app/domain/actionjob_hanlder.js c9dc751
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/flow-designer.hbs 8c07d6d
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/spark-action.hbs de62e77
> contrib/views/wfmanager/src/main/resources/ui/app/utils/constants.js bf858d8
>
>
> Diff: https://reviews.apache.org/r/60114/diff/2/
>
>
> Testing
> -------
>
> Manual testing done.
>
>
> Thanks,
>
> venkat sairam
>
>
Re: Review Request 60114: Remove YARN client mode option from WFM
Posted by belliraj hb <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60114/#review178467
-----------------------------------------------------------
Ship it!
Ship It!
- belliraj hb
On June 20, 2017, 5:59 p.m., venkat sairam wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60114/
> -----------------------------------------------------------
>
> (Updated June 20, 2017, 5:59 p.m.)
>
>
> Review request for Ambari, belliraj hb, Padma Priya N, Pallav Kulshreshtha, and Rohit Choudhary.
>
>
> Bugs: AMBARI-21255
> https://issues.apache.org/jira/browse/AMBARI-21255
>
>
> Repository: ambari
>
>
> Description
> -------
>
> YARN client mode have been removed from WFD as oozie doesnt support Yarn client mode
>
>
> Diffs
> -----
>
> contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js 1cfe755
> contrib/views/wfmanager/src/main/resources/ui/app/domain/actionjob_hanlder.js c9dc751
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/flow-designer.hbs 8c07d6d
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/spark-action.hbs de62e77
> contrib/views/wfmanager/src/main/resources/ui/app/utils/constants.js bf858d8
>
>
> Diff: https://reviews.apache.org/r/60114/diff/2/
>
>
> Testing
> -------
>
> Manual testing done.
>
>
> Thanks,
>
> venkat sairam
>
>
Re: Review Request 60114: Remove YARN client mode option from WFM
Posted by venkat sairam <ve...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60114/
-----------------------------------------------------------
(Updated June 20, 2017, 5:59 p.m.)
Review request for Ambari, belliraj hb, Padma Priya N, Pallav Kulshreshtha, and Rohit Choudhary.
Bugs: AMBARI-21255
https://issues.apache.org/jira/browse/AMBARI-21255
Repository: ambari
Description
-------
YARN client mode have been removed from WFD as oozie doesnt support Yarn client mode
Diffs (updated)
-----
contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js 1cfe755
contrib/views/wfmanager/src/main/resources/ui/app/domain/actionjob_hanlder.js c9dc751
contrib/views/wfmanager/src/main/resources/ui/app/templates/components/flow-designer.hbs 8c07d6d
contrib/views/wfmanager/src/main/resources/ui/app/templates/components/spark-action.hbs de62e77
contrib/views/wfmanager/src/main/resources/ui/app/utils/constants.js bf858d8
Diff: https://reviews.apache.org/r/60114/diff/2/
Changes: https://reviews.apache.org/r/60114/diff/1-2/
Testing
-------
Manual testing done.
Thanks,
venkat sairam
Re: Review Request 60114: Remove YARN client mode option from WFM
Posted by venkat sairam <ve...@gmail.com>.
> On June 16, 2017, 10:32 a.m., belliraj hb wrote:
> >
Made necessary changes.Please review again.
- venkat
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60114/#review178094
-----------------------------------------------------------
On June 20, 2017, 5:59 p.m., venkat sairam wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60114/
> -----------------------------------------------------------
>
> (Updated June 20, 2017, 5:59 p.m.)
>
>
> Review request for Ambari, belliraj hb, Padma Priya N, Pallav Kulshreshtha, and Rohit Choudhary.
>
>
> Bugs: AMBARI-21255
> https://issues.apache.org/jira/browse/AMBARI-21255
>
>
> Repository: ambari
>
>
> Description
> -------
>
> YARN client mode have been removed from WFD as oozie doesnt support Yarn client mode
>
>
> Diffs
> -----
>
> contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js 1cfe755
> contrib/views/wfmanager/src/main/resources/ui/app/domain/actionjob_hanlder.js c9dc751
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/flow-designer.hbs 8c07d6d
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/spark-action.hbs de62e77
> contrib/views/wfmanager/src/main/resources/ui/app/utils/constants.js bf858d8
>
>
> Diff: https://reviews.apache.org/r/60114/diff/2/
>
>
> Testing
> -------
>
> Manual testing done.
>
>
> Thanks,
>
> venkat sairam
>
>
Re: Review Request 60114: Remove YARN client mode option from WFM
Posted by belliraj hb <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60114/#review178094
-----------------------------------------------------------
contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js
Lines 401 (patched)
<https://reviews.apache.org/r/60114/#comment251903>
must check with exact match. must first check if the actionType is spark. i guess findby is generic search.
- belliraj hb
On June 15, 2017, 9:15 a.m., venkat sairam wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60114/
> -----------------------------------------------------------
>
> (Updated June 15, 2017, 9:15 a.m.)
>
>
> Review request for Ambari, belliraj hb, Padma Priya N, Pallav Kulshreshtha, and Rohit Choudhary.
>
>
> Bugs: AMBARI-21255
> https://issues.apache.org/jira/browse/AMBARI-21255
>
>
> Repository: ambari
>
>
> Description
> -------
>
> YARN client mode have been removed from WFD as oozie doesnt support Yarn client mode
>
>
> Diffs
> -----
>
> contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js 1cfe755
> contrib/views/wfmanager/src/main/resources/ui/app/domain/actionjob_hanlder.js c9dc751
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/flow-designer.hbs 8c07d6d
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/spark-action.hbs de62e77
> contrib/views/wfmanager/src/main/resources/ui/app/utils/constants.js bf858d8
>
>
> Diff: https://reviews.apache.org/r/60114/diff/1/
>
>
> Testing
> -------
>
> Manual testing done.
>
>
> Thanks,
>
> venkat sairam
>
>