You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2020/02/11 03:44:01 UTC
[GitHub] [incubator-doris] yangzhg opened a new pull request #2879: fix some
typo in bitmap index docs.
yangzhg opened a new pull request #2879: fix some typo in bitmap index docs.
URL: https://github.com/apache/incubator-doris/pull/2879
1. fix some typo in bitmap index docs.
2. full compitiable bitmap index type location with mysql
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] HangyuanLiu commented on issue #2879: fix some
typo in bitmap index docs.
Posted by GitBox <gi...@apache.org>.
HangyuanLiu commented on issue #2879: fix some typo in bitmap index docs.
URL: https://github.com/apache/incubator-doris/pull/2879#issuecomment-584472515
你好，可以在文档中给出一些使用案例吗？比如在某个场景下，使用bitmap会大幅提高doris的性能。作为一个使用方，目前感觉不知如何介入这个优秀的功能。
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] kangkaisen commented on a change in pull request
#2879: fix some typo in bitmap index docs.
Posted by GitBox <gi...@apache.org>.
kangkaisen commented on a change in pull request #2879: fix some typo in bitmap index docs.
URL: https://github.com/apache/incubator-doris/pull/2879#discussion_r377521067
##########
File path: fe/src/main/cup/sql_parser.cup
##########
@@ -967,6 +967,10 @@ create_stmt ::=
{:
RESULT = new AlterTableStmt(tableName, Lists.newArrayList(new CreateIndexClause(tableName, new IndexDef(indexName, cols, indexType, comment), false)));
:}
+// | KW_CREATE KW_INDEX ident:indexName opt_index_type:indexType KW_ON table_name:tableName LPAREN ident_list:cols RPAREN opt_comment:comment
Review comment:
Why not delete these useless code?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] kangkaisen commented on issue #2879: fix some
typo in bitmap index docs.
Posted by GitBox <gi...@apache.org>.
kangkaisen commented on issue #2879: fix some typo in bitmap index docs.
URL: https://github.com/apache/incubator-doris/pull/2879#issuecomment-584583539
> 你好，可以在文档中给出一些使用案例吗？比如在某个场景下，使用bitmap会大幅提高doris的性能。作为一个使用方，目前感觉不知如何介入这个优秀的功能。
倒排索引主要用在多维过滤场景。
这一点 可以加到 http://doris.apache.org/documentation/cn/getting-started/best-practice.html 这个文档里面。
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] kangkaisen merged pull request #2879: fix some
typo in bitmap index docs.
Posted by GitBox <gi...@apache.org>.
kangkaisen merged pull request #2879: fix some typo in bitmap index docs.
URL: https://github.com/apache/incubator-doris/pull/2879
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] imay commented on a change in pull request #2879:
fix some typo in bitmap index docs.
Posted by GitBox <gi...@apache.org>.
imay commented on a change in pull request #2879: fix some typo in bitmap index docs.
URL: https://github.com/apache/incubator-doris/pull/2879#discussion_r377439919
##########
File path: fe/src/main/cup/sql_parser.cup
##########
@@ -967,6 +967,10 @@ create_stmt ::=
{:
RESULT = new AlterTableStmt(tableName, Lists.newArrayList(new CreateIndexClause(tableName, new IndexDef(indexName, cols, indexType, comment), false)));
:}
+ | KW_CREATE KW_INDEX ident:indexName opt_index_type:indexType KW_ON table_name:tableName LPAREN ident_list:cols RPAREN opt_comment:comment
Review comment:
I think we can not support this syntax.
It is enough to give user one option, no need to give users multiple options.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org