You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Nathan Beyer (Apache) (JIRA)" <ji...@codehaus.org> on 2007/11/30 04:58:58 UTC

[jira] Created: (WAGONHTTP-16) when repository URL contians a trailing slash, resolved URLs contain duplicate slashes

when repository URL contians a trailing slash, resolved URLs contain duplicate slashes
--------------------------------------------------------------------------------------

                 Key: WAGONHTTP-16
                 URL: http://jira.codehaus.org/browse/WAGONHTTP-16
             Project: wagon-http
          Issue Type: Bug
    Affects Versions: 1.0-beta-2
            Reporter: Nathan Beyer (Apache)
            Priority: Minor
         Attachments: http-trailing-slash-patch.diff

When a repository URL is configured with a trailing slash, such as http://repo1.maven.org/maven2/, the URLs that are constructed contain double slashes. The currently assembled URL is something like http://repo1.maven.org/maven2//org/apache/maven/maven-2.0-20050406.034330-1.pom.

As a URL that ends in a directory should end with a slash, per the URI syntax, the use of trailing slashes in configured URLs should be a common occurrence. This generally doesn't affect most web servers, as most operating systems don't allow directories with an empty string name, which is what a "//" would indicate.

I've attached a simple patch that cleans this up for wagon-http and wagon-http-lightweight. The patch includes two new test cases to exercise this code. The knew test cases are just duplicates of existing test cases, but with a fixture repository URL that ends in a slash.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Moved: (WAGON-114) when repository URL contians a trailing slash, resolved URLs contain duplicate slashes

Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/WAGON-114?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Brett Porter moved WAGONHTTP-16 to WAGON-114:
---------------------------------------------

    Affects Version/s:     (was: 1.0-beta-2)
        Fix Version/s:     (was: 1.0-beta-3)
                       1.0-beta-3
                  Key: WAGON-114  (was: WAGONHTTP-16)
              Project: Maven Wagon  (was: wagon-http)

> when repository URL contians a trailing slash, resolved URLs contain duplicate slashes
> --------------------------------------------------------------------------------------
>
>                 Key: WAGON-114
>                 URL: http://jira.codehaus.org/browse/WAGON-114
>             Project: Maven Wagon
>          Issue Type: Bug
>            Reporter: Nathan Beyer (Apache)
>            Assignee: Brett Porter
>            Priority: Minor
>             Fix For: 1.0-beta-3
>
>         Attachments: http-trailing-slash-patch.diff
>
>
> When a repository URL is configured with a trailing slash, such as http://repo1.maven.org/maven2/, the URLs that are constructed contain double slashes. The currently assembled URL is something like http://repo1.maven.org/maven2//org/apache/maven/maven-2.0-20050406.034330-1.pom.
> As a URL that ends in a directory should end with a slash, per the URI syntax, the use of trailing slashes in configured URLs should be a common occurrence. This generally doesn't affect most web servers, as most operating systems don't allow directories with an empty string name, which is what a "//" would indicate.
> I've attached a simple patch that cleans this up for wagon-http and wagon-http-lightweight. The patch includes two new test cases to exercise this code. The knew test cases are just duplicates of existing test cases, but with a fixture repository URL that ends in a slash.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (WAGON-114) when repository URL contians a trailing slash, resolved URLs contain duplicate slashes

Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/WAGON-114?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Brett Porter updated WAGON-114:
-------------------------------

    Component/s: wagon-http-lightweight

> when repository URL contians a trailing slash, resolved URLs contain duplicate slashes
> --------------------------------------------------------------------------------------
>
>                 Key: WAGON-114
>                 URL: http://jira.codehaus.org/browse/WAGON-114
>             Project: Maven Wagon
>          Issue Type: Bug
>          Components: wagon-http-lightweight
>            Reporter: Nathan Beyer (Apache)
>            Assignee: Brett Porter
>            Priority: Minor
>             Fix For: 1.0-beta-3
>
>         Attachments: http-trailing-slash-patch.diff
>
>
> When a repository URL is configured with a trailing slash, such as http://repo1.maven.org/maven2/, the URLs that are constructed contain double slashes. The currently assembled URL is something like http://repo1.maven.org/maven2//org/apache/maven/maven-2.0-20050406.034330-1.pom.
> As a URL that ends in a directory should end with a slash, per the URI syntax, the use of trailing slashes in configured URLs should be a common occurrence. This generally doesn't affect most web servers, as most operating systems don't allow directories with an empty string name, which is what a "//" would indicate.
> I've attached a simple patch that cleans this up for wagon-http and wagon-http-lightweight. The patch includes two new test cases to exercise this code. The knew test cases are just duplicates of existing test cases, but with a fixture repository URL that ends in a slash.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Closed: (WAGONHTTP-16) when repository URL contians a trailing slash, resolved URLs contain duplicate slashes

Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/WAGONHTTP-16?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Brett Porter closed WAGONHTTP-16.
---------------------------------

         Assignee: Brett Porter
       Resolution: Fixed
    Fix Version/s: 1.0-beta-3

applied, thanks

> when repository URL contians a trailing slash, resolved URLs contain duplicate slashes
> --------------------------------------------------------------------------------------
>
>                 Key: WAGONHTTP-16
>                 URL: http://jira.codehaus.org/browse/WAGONHTTP-16
>             Project: wagon-http
>          Issue Type: Bug
>    Affects Versions: 1.0-beta-2
>            Reporter: Nathan Beyer (Apache)
>            Assignee: Brett Porter
>            Priority: Minor
>             Fix For: 1.0-beta-3
>
>         Attachments: http-trailing-slash-patch.diff
>
>
> When a repository URL is configured with a trailing slash, such as http://repo1.maven.org/maven2/, the URLs that are constructed contain double slashes. The currently assembled URL is something like http://repo1.maven.org/maven2//org/apache/maven/maven-2.0-20050406.034330-1.pom.
> As a URL that ends in a directory should end with a slash, per the URI syntax, the use of trailing slashes in configured URLs should be a common occurrence. This generally doesn't affect most web servers, as most operating systems don't allow directories with an empty string name, which is what a "//" would indicate.
> I've attached a simple patch that cleans this up for wagon-http and wagon-http-lightweight. The patch includes two new test cases to exercise this code. The knew test cases are just duplicates of existing test cases, but with a fixture repository URL that ends in a slash.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira