You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Daniel Becker (Code Review)" <ge...@cloudera.org> on 2019/08/07 12:43:43 UTC

[Impala-ASF-CR] IMPALA-8840: Check failed: num bytes <= sizeof(T) (5 vs. 4) 

Daniel Becker has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14029


Change subject: IMPALA-8840: Check failed: num_bytes <= sizeof(T) (5 vs. 4)
......................................................................

IMPALA-8840: Check failed: num_bytes <= sizeof(T) (5 vs. 4)

Added a DCHECK to RleBatchDecoder so that it does not accept bit widths
higher than the width of its type parameter.

Also preventing UnpackAndDecodeValues from using higher bit widths than
32, the width of its dictionary index type, with a static assert.

Change-Id: I93461ba2cabb5ec7e0b65dcd62844fcbfa597d16
---
M be/src/util/bit-packing.h
M be/src/util/bit-packing.inline.h
M be/src/util/dict-test.cc
M be/src/util/rle-encoding.h
4 files changed, 13 insertions(+), 7 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/29/14029/1
-- 
To view, visit http://gerrit.cloudera.org:8080/14029
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I93461ba2cabb5ec7e0b65dcd62844fcbfa597d16
Gerrit-Change-Number: 14029
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Becker <da...@cloudera.com>

[Impala-ASF-CR] IMPALA-8840: Check failed: num bytes <= sizeof(T) (5 vs. 4)

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14029 )

Change subject: IMPALA-8840: Check failed: num_bytes <= sizeof(T) (5 vs. 4)
......................................................................


Patch Set 2: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/14029
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I93461ba2cabb5ec7e0b65dcd62844fcbfa597d16
Gerrit-Change-Number: 14029
Gerrit-PatchSet: 2
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 08 Aug 2019 13:35:01 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8840: Check failed: num bytes <= sizeof(T) (5 vs. 4)

Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14029 )

Change subject: IMPALA-8840: Check failed: num_bytes <= sizeof(T) (5 vs. 4)
......................................................................

IMPALA-8840: Check failed: num_bytes <= sizeof(T) (5 vs. 4)

The actual DCHECK failure was fixed by the change for IMPALA-8833.

Added a DCHECK to RleBatchDecoder so that it does not accept bit widths
higher than the width of its type parameter.

Also preventing UnpackAndDecodeValues from using higher bit widths than
32, the width of the dictionary index type, with a static assert. This
also reduces compile time because the compiler does not have to generate
code for invalid bit widths.

Change-Id: I93461ba2cabb5ec7e0b65dcd62844fcbfa597d16
Reviewed-on: http://gerrit.cloudera.org:8080/14029
Reviewed-by: Csaba Ringhofer <cs...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/src/util/bit-packing.h
M be/src/util/bit-packing.inline.h
M be/src/util/dict-test.cc
M be/src/util/rle-encoding.h
4 files changed, 13 insertions(+), 7 deletions(-)

Approvals:
  Csaba Ringhofer: Looks good to me, approved
  Impala Public Jenkins: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/14029
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I93461ba2cabb5ec7e0b65dcd62844fcbfa597d16
Gerrit-Change-Number: 14029
Gerrit-PatchSet: 3
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>

[Impala-ASF-CR] IMPALA-8840: Check failed: num bytes <= sizeof(T) (5 vs. 4)

Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/14029 )

Change subject: IMPALA-8840: Check failed: num_bytes <= sizeof(T) (5 vs. 4)
......................................................................


Patch Set 2: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/14029
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I93461ba2cabb5ec7e0b65dcd62844fcbfa597d16
Gerrit-Change-Number: 14029
Gerrit-PatchSet: 2
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 07 Aug 2019 13:25:40 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8840: Check failed: num bytes <= sizeof(T) (5 vs. 4)

Posted by "Daniel Becker (Code Review)" <ge...@cloudera.org>.
Daniel Becker has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/14029 )

Change subject: IMPALA-8840: Check failed: num_bytes <= sizeof(T) (5 vs. 4)
......................................................................

IMPALA-8840: Check failed: num_bytes <= sizeof(T) (5 vs. 4)

The actual DCHECK failure was fixed by the change for IMPALA-8833.

Added a DCHECK to RleBatchDecoder so that it does not accept bit widths
higher than the width of its type parameter.

Also preventing UnpackAndDecodeValues from using higher bit widths than
32, the width of the dictionary index type, with a static assert. This
also reduces compile time because the compiler does not have to generate
code for invalid bit widths.

Change-Id: I93461ba2cabb5ec7e0b65dcd62844fcbfa597d16
---
M be/src/util/bit-packing.h
M be/src/util/bit-packing.inline.h
M be/src/util/dict-test.cc
M be/src/util/rle-encoding.h
4 files changed, 13 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/29/14029/2
-- 
To view, visit http://gerrit.cloudera.org:8080/14029
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I93461ba2cabb5ec7e0b65dcd62844fcbfa597d16
Gerrit-Change-Number: 14029
Gerrit-PatchSet: 2
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>

[Impala-ASF-CR] IMPALA-8840: Check failed: num bytes <= sizeof(T) (5 vs. 4)

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14029 )

Change subject: IMPALA-8840: Check failed: num_bytes <= sizeof(T) (5 vs. 4)
......................................................................


Patch Set 2:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4752/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/14029
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I93461ba2cabb5ec7e0b65dcd62844fcbfa597d16
Gerrit-Change-Number: 14029
Gerrit-PatchSet: 2
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 07 Aug 2019 13:26:42 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8840: Check failed: num bytes <= sizeof(T) (5 vs. 4)

Posted by "Daniel Becker (Code Review)" <ge...@cloudera.org>.
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/14029 )

Change subject: IMPALA-8840: Check failed: num_bytes <= sizeof(T) (5 vs. 4)
......................................................................


Patch Set 2:

Jenkins failure seems to be unrelated, trying once again.


-- 
To view, visit http://gerrit.cloudera.org:8080/14029
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I93461ba2cabb5ec7e0b65dcd62844fcbfa597d16
Gerrit-Change-Number: 14029
Gerrit-PatchSet: 2
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 08 Aug 2019 09:20:04 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8840: Check failed: num bytes <= sizeof(T) (5 vs. 4)

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14029 )

Change subject: IMPALA-8840: Check failed: num_bytes <= sizeof(T) (5 vs. 4)
......................................................................


Patch Set 2:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4757/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/14029
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I93461ba2cabb5ec7e0b65dcd62844fcbfa597d16
Gerrit-Change-Number: 14029
Gerrit-PatchSet: 2
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 08 Aug 2019 09:21:58 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8840: Check failed: num bytes <= sizeof(T) (5 vs. 4)

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14029 )

Change subject: IMPALA-8840: Check failed: num_bytes <= sizeof(T) (5 vs. 4)
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/4169/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/14029
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I93461ba2cabb5ec7e0b65dcd62844fcbfa597d16
Gerrit-Change-Number: 14029
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 07 Aug 2019 13:26:15 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8840: Check failed: num bytes <= sizeof(T) (5 vs. 4)

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14029 )

Change subject: IMPALA-8840: Check failed: num_bytes <= sizeof(T) (5 vs. 4)
......................................................................


Patch Set 2: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/4752/


-- 
To view, visit http://gerrit.cloudera.org:8080/14029
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I93461ba2cabb5ec7e0b65dcd62844fcbfa597d16
Gerrit-Change-Number: 14029
Gerrit-PatchSet: 2
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 07 Aug 2019 16:22:28 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8840: Check failed: num bytes <= sizeof(T) (5 vs. 4)

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14029 )

Change subject: IMPALA-8840: Check failed: num_bytes <= sizeof(T) (5 vs. 4)
......................................................................


Patch Set 2:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/4170/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/14029
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I93461ba2cabb5ec7e0b65dcd62844fcbfa597d16
Gerrit-Change-Number: 14029
Gerrit-PatchSet: 2
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 07 Aug 2019 13:48:43 +0000
Gerrit-HasComments: No