[GitHub] [incubator-kyuubi] turboFei commented on a diff in pull request #3684: Expose the engine id when registering and show the engine details for list engine command

[GitBox <gi...@apache.org>]

turboFei commented on code in PR #3684:
URL: https://github.com/apache/incubator-kyuubi/pull/3684#discussion_r1003105110


##########
externals/kyuubi-spark-sql-engine/src/main/scala/org/apache/kyuubi/engine/spark/SparkTBinaryFrontendService.scala:
##########
@@ -92,6 +92,10 @@ class SparkTBinaryFrontendService(
       None
     }
   }
+
+  override def extraServiceInfo: Map[String, String] = {

Review Comment:
   <img width="859" alt="image" src="https://user-images.githubusercontent.com/6757692/197497450-0df9f7e4-21ce-4268-978d-17fdabb4dd1f.png">
   
   Now I can only see the `KYUUBI_ENGINE_ID` is used in Spark.
   
   We can extend other engines to support expose kyuubi.engine.id.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org