[kudu-CR] [python] handle DisableOpenSSLInitialization() result status

["Adar Dembo (Code Review)" <ge...@cloudera.org>]

Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12135 )

Change subject: [python] handle DisableOpenSSLInitialization() result status
......................................................................


Patch Set 1: Code-Review+2

(1 comment)

http://gerrit.cloudera.org:8080/#/c/12135/1/python/kudu/client.pyx
File python/kudu/client.pyx:

http://gerrit.cloudera.org:8080/#/c/12135/1/python/kudu/client.pyx@288
PS1, Line 288:         # Python programs will often have already imported _ssl, which
             :         # has the side effect of initializing OpenSSL. So, we detect
             :         # whether _ssl is present, and if we can import it, we disable
             :         # Kudu's initialization to avoid a conflict.
Just to clarify, "import _ssl" is not the "correct" way to initialize OpenSSL in Python, and it will fail if the correct way (whatever it may be) is not followed? Asking because it seems unusual to expect an import statement to fail in Python (unless it's for an optional module), so I want to make sure I understand the behavior here.



-- 
To view, visit http://gerrit.cloudera.org:8080/12135
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1963b6d87d731fbfa87a09b986595aa8ea00da60
Gerrit-Change-Number: 12135
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Comment-Date: Wed, 02 Jan 2019 17:50:25 +0000
Gerrit-HasComments: Yes