You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pagespeed.apache.org by GitBox <gi...@apache.org> on 2020/01/14 12:38:33 UTC

[GitHub] [incubator-pagespeed-mod] Lofesa commented on issue #1876: Image Optimization: Does MPS optimize images?

Lofesa commented on issue #1876: Image Optimization: Does MPS optimize <source> images?
URL: https://github.com/apache/incubator-pagespeed-mod/issues/1876#issuecomment-574154865
 
 
   Hi @FalkoHilbert 
   The PR is intended to solve the data-srcset issue, not to add the picture element.
   I have no tried, cause I don´t use picture elements in my site, but with
   ```
   pagespeed AddUrlValuedAttribute source srcset srcsetimage
   pagespeed AddUrlValuedAttribute source data-srcset srcsetimage
   pagespeed AddUrlValuedAttribute source data-src image
   pagespeed AddUrlValuedAttribute source src image
   ```
   must work if you use these combinations if you only use picture, but if you use audio or video this can´t be used, cause it uses `source src`.
   As far as I know adding the picture element is not planned, people that works in the module are in other things.
   Any chance you make a proposal PR for this?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services