You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2019/12/18 22:01:39 UTC
[GitHub] [incubator-iceberg] rdblue opened a new pull request #706: Add
DeleteFrom support for Spark 3.0
rdblue opened a new pull request #706: Add DeleteFrom support for Spark 3.0
URL: https://github.com/apache/incubator-iceberg/pull/706
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [incubator-iceberg] chenjunjiedada commented on issue #706: Add
DeleteFrom support for Spark 3.0
Posted by GitBox <gi...@apache.org>.
chenjunjiedada commented on issue #706: Add DeleteFrom support for Spark 3.0
URL: https://github.com/apache/incubator-iceberg/pull/706#issuecomment-569663643
LGTM +1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [incubator-iceberg] rdblue commented on issue #706: Add DeleteFrom
support for Spark 3.0
Posted by GitBox <gi...@apache.org>.
rdblue commented on issue #706: Add DeleteFrom support for Spark 3.0
URL: https://github.com/apache/incubator-iceberg/pull/706#issuecomment-569748302
Thanks for reviewing, @chenjunjiedada and @jerryshao!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [incubator-iceberg] rdblue commented on a change in pull request
#706: Add DeleteFrom support for Spark 3.0
Posted by GitBox <gi...@apache.org>.
rdblue commented on a change in pull request #706: Add DeleteFrom support for Spark 3.0
URL: https://github.com/apache/incubator-iceberg/pull/706#discussion_r360471232
##########
File path: spark/src/main/java/org/apache/iceberg/spark/source/SparkTable.java
##########
@@ -119,4 +124,16 @@ public WriteBuilder newWriteBuilder(CaseInsensitiveStringMap options) {
return new SparkWriteBuilder(sparkSession(), icebergTable, options);
}
+ @Override
+ public void deleteWhere(Filter[] filters) {
+ icebergTable.newDelete()
+ .set("spark.app.id", sparkSession().sparkContext().applicationId())
+ .deleteFromRowFilter(SparkFilters.convert(filters))
Review comment:
The error message is fairly clear. It says that there was a file that may contain both records that should be deleted and records that should not be.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [incubator-iceberg] rdblue merged pull request #706: Add DeleteFrom
support for Spark 3.0
Posted by GitBox <gi...@apache.org>.
rdblue merged pull request #706: Add DeleteFrom support for Spark 3.0
URL: https://github.com/apache/incubator-iceberg/pull/706
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [incubator-iceberg] rdblue commented on a change in pull request
#706: Add DeleteFrom support for Spark 3.0
Posted by GitBox <gi...@apache.org>.
rdblue commented on a change in pull request #706: Add DeleteFrom support for Spark 3.0
URL: https://github.com/apache/incubator-iceberg/pull/706#discussion_r360471577
##########
File path: spark/src/main/java/org/apache/iceberg/spark/source/SparkTable.java
##########
@@ -119,4 +124,16 @@ public WriteBuilder newWriteBuilder(CaseInsensitiveStringMap options) {
return new SparkWriteBuilder(sparkSession(), icebergTable, options);
}
+ @Override
+ public void deleteWhere(Filter[] filters) {
+ icebergTable.newDelete()
+ .set("spark.app.id", sparkSession().sparkContext().applicationId())
+ .deleteFromRowFilter(SparkFilters.convert(filters))
Review comment:
The error message is fairly clear. It says that there was a file that may contain both records that should be deleted and records that should not be.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [incubator-iceberg] rdblue commented on a change in pull request
#706: Add DeleteFrom support for Spark 3.0
Posted by GitBox <gi...@apache.org>.
rdblue commented on a change in pull request #706: Add DeleteFrom support for Spark 3.0
URL: https://github.com/apache/incubator-iceberg/pull/706#discussion_r360471232
##########
File path: spark/src/main/java/org/apache/iceberg/spark/source/SparkTable.java
##########
@@ -119,4 +124,16 @@ public WriteBuilder newWriteBuilder(CaseInsensitiveStringMap options) {
return new SparkWriteBuilder(sparkSession(), icebergTable, options);
}
+ @Override
+ public void deleteWhere(Filter[] filters) {
+ icebergTable.newDelete()
+ .set("spark.app.id", sparkSession().sparkContext().applicationId())
+ .deleteFromRowFilter(SparkFilters.convert(filters))
Review comment:
The error message is fairly clear. It says that there was a file that may contain both records that should be deleted and records that should not be.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org