[GitHub] [netbeans] JaroslavTulach commented on issue #1092: Using Scripting API in platform/core.network

[GitBox <gi...@apache.org>]

JaroslavTulach commented on issue #1092: Using Scripting API in platform/core.network
URL: https://github.com/apache/netbeans/pull/1092#issuecomment-496434837
 
 
   After five months I believe I am ready for integration. Please review (again).
   
   1. Meanwhile [GraalVM](http://graalvm.org) managed to release official stable version - e.g. this PR updates to Graal.js 19.0.0
   2. the biggest complain I noticed in previous round of review: we don't want to have an open list of script engines to use for PAC evaluation - addressed by 7a90c43 and `ALLOWED_PAC_ENGINES` branding
   3. the PR contains a fix for networking issues during build - kind of unrelated, but I wasn't able to move on without it: a297bcf
   4. the rest of the PR is basically an attempt to make sure `Scripting.newBuilder().build()` provides consistent engines (Nashorn, Graal.js and GraalVM:js) secured by default
   5. `profiler.oql` is using `Scripting` as well, but it only runs trusted scripts and thus needs to run in `allowAllAccess` mode - hence the new API - `Scripting.newBuilder().allowAllAccess(true).build()`
   
   I hope the review goes well. I'd really like to get this out of my table. I've been playing with JavaScript engines secure integration since December 2018 and it is time to move to something else.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists