You are viewing a plain text version of this content. The canonical link for it is here.

Posted to common-issues@hadoop.apache.org by GitBox <gi...@apache.org> on 2020/05/01 00:31:35 UTC

[GitHub] [hadoop] babsingh commented on pull request #1951: HDFS-15270. Account for *env == NULL in hdfsThreadDestructor

babsingh commented on pull request #1951:
URL: https://github.com/apache/hadoop/pull/1951#issuecomment-622190741


   - **cc -1 ❌** ... Compilation warnings are unrelated to the proposed change.
   
   - **test4tests -1 ❌** ... Existing tests should already include coverage for the reported failure. OpenJ9 JVM needs to be used in order to reproduce the failure. Instructions to reproduce the failure: https://github.com/eclipse/openj9/issues/7752#issue-521732953. Manual steps taken to verify the patch: https://github.com/eclipse/openj9/issues/7752#issuecomment-612149993.
   
   @jojochuang Is the above justification sufficient to address the **💔 -1 overall**? Is there a specific protocol to justify **-1 ❌** for each subsystem?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org