You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@parquet.apache.org by fo...@apache.org on 2026/10/29 12:55:36 UTC

(parquet-java) branch master updated: GH-3897: Replace deprecated Class.newInstance() (#3903)

This is an automated email from the ASF dual-hosted git repository.

Fokko pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/parquet-java.git


The following commit(s) were added to refs/heads/master by this push:
     new 831760d70 GH-3897: Replace deprecated Class.newInstance() (#3903)
831760d70 is described below

commit 831760d7081d7b93d89d242a76af248adc84ebd1
Author: Fokko Driesprong <fo...@apache.org>
AuthorDate: Thu Oct 29 13:55:31 2026 +0100

    GH-3897: Replace deprecated Class.newInstance() (#3903)
    
    Class.newInstance() has been deprecated since Java 9. Use
    getDeclaredConstructor().newInstance() instead and widen the catch
    clauses to ReflectiveOperationException, keeping the existing wrapping
    exceptions and messages. As a result, checked exceptions thrown by a
    constructor now arrive wrapped in an InvocationTargetException instead
    of being sneaky-thrown.
    
    Co-authored-by: Isaac <no...@databricks.com>
---
 .../main/java/org/apache/parquet/filter2/predicate/Operators.java | 4 ++--
 .../src/main/java/org/apache/parquet/format/event/Consumers.java  | 4 ++--
 .../org/apache/parquet/crypto/DecryptionPropertiesFactory.java    | 5 +++--
 .../org/apache/parquet/crypto/EncryptionPropertiesFactory.java    | 5 +++--
 .../main/java/org/apache/parquet/crypto/keytools/KeyToolkit.java  | 4 ++--
 .../main/java/org/apache/parquet/hadoop/ParquetInputFormat.java   | 8 ++++----
 .../main/java/org/apache/parquet/hadoop/ParquetOutputFormat.java  | 3 ++-
 .../org/apache/parquet/hadoop/thrift/ThriftBytesWriteSupport.java | 6 ++++--
 .../main/java/org/apache/parquet/thrift/TBaseRecordConverter.java | 7 ++++---
 .../java/org/apache/parquet/thrift/TestProtocolReadToWrite.java   | 7 ++++---
 10 files changed, 30 insertions(+), 23 deletions(-)

diff --git a/parquet-column/src/main/java/org/apache/parquet/filter2/predicate/Operators.java b/parquet-column/src/main/java/org/apache/parquet/filter2/predicate/Operators.java
index 60dc80cd7..2df9ac726 100644
--- a/parquet-column/src/main/java/org/apache/parquet/filter2/predicate/Operators.java
+++ b/parquet-column/src/main/java/org/apache/parquet/filter2/predicate/Operators.java
@@ -662,8 +662,8 @@ public final class Operators {
     @Override
     public U getUserDefinedPredicate() {
       try {
-        return udpClass.newInstance();
-      } catch (InstantiationException | IllegalAccessException e) {
+        return udpClass.getDeclaredConstructor().newInstance();
+      } catch (ReflectiveOperationException e) {
         throw new RuntimeException(String.format(INSTANTIATION_ERROR_MESSAGE, udpClass), e);
       }
     }
diff --git a/parquet-format-structures/src/main/java/org/apache/parquet/format/event/Consumers.java b/parquet-format-structures/src/main/java/org/apache/parquet/format/event/Consumers.java
index 6e375c1c2..86f15112c 100644
--- a/parquet-format-structures/src/main/java/org/apache/parquet/format/event/Consumers.java
+++ b/parquet-format-structures/src/main/java/org/apache/parquet/format/event/Consumers.java
@@ -186,8 +186,8 @@ class TBaseStructConsumer<T extends TBase<T, ? extends TFieldIdEnum>> extends St
 
   protected T newObject() {
     try {
-      return c.newInstance();
-    } catch (InstantiationException | IllegalAccessException e) {
+      return c.getDeclaredConstructor().newInstance();
+    } catch (ReflectiveOperationException e) {
       throw new RuntimeException(c.getName(), e);
     }
   }
diff --git a/parquet-hadoop/src/main/java/org/apache/parquet/crypto/DecryptionPropertiesFactory.java b/parquet-hadoop/src/main/java/org/apache/parquet/crypto/DecryptionPropertiesFactory.java
index 621b91c0d..2d5aa32f7 100644
--- a/parquet-hadoop/src/main/java/org/apache/parquet/crypto/DecryptionPropertiesFactory.java
+++ b/parquet-hadoop/src/main/java/org/apache/parquet/crypto/DecryptionPropertiesFactory.java
@@ -66,8 +66,9 @@ public interface DecryptionPropertiesFactory {
     }
 
     try {
-      return (DecryptionPropertiesFactory) decryptionPropertiesFactoryClass.newInstance();
-    } catch (InstantiationException | IllegalAccessException e) {
+      return (DecryptionPropertiesFactory)
+          decryptionPropertiesFactoryClass.getDeclaredConstructor().newInstance();
+    } catch (ReflectiveOperationException e) {
       throw new BadConfigurationException(
           "could not instantiate decryptionPropertiesFactoryClass class: " + decryptionPropertiesFactoryClass,
           e);
diff --git a/parquet-hadoop/src/main/java/org/apache/parquet/crypto/EncryptionPropertiesFactory.java b/parquet-hadoop/src/main/java/org/apache/parquet/crypto/EncryptionPropertiesFactory.java
index a49ae2db1..77042214a 100644
--- a/parquet-hadoop/src/main/java/org/apache/parquet/crypto/EncryptionPropertiesFactory.java
+++ b/parquet-hadoop/src/main/java/org/apache/parquet/crypto/EncryptionPropertiesFactory.java
@@ -83,8 +83,9 @@ public interface EncryptionPropertiesFactory {
     }
 
     try {
-      return (EncryptionPropertiesFactory) encryptionPropertiesFactoryClass.newInstance();
-    } catch (InstantiationException | IllegalAccessException e) {
+      return (EncryptionPropertiesFactory)
+          encryptionPropertiesFactoryClass.getDeclaredConstructor().newInstance();
+    } catch (ReflectiveOperationException e) {
       throw new BadConfigurationException(
           "could not instantiate encryptionPropertiesFactoryClass class: " + encryptionPropertiesFactoryClass,
           e);
diff --git a/parquet-hadoop/src/main/java/org/apache/parquet/crypto/keytools/KeyToolkit.java b/parquet-hadoop/src/main/java/org/apache/parquet/crypto/keytools/KeyToolkit.java
index 9d3da61ec..f0124d0fc 100644
--- a/parquet-hadoop/src/main/java/org/apache/parquet/crypto/keytools/KeyToolkit.java
+++ b/parquet-hadoop/src/main/java/org/apache/parquet/crypto/keytools/KeyToolkit.java
@@ -562,8 +562,8 @@ public class KeyToolkit {
         if (null == kmsClientClass) {
           throw new ParquetCryptoRuntimeException("Unspecified " + KMS_CLIENT_CLASS_PROPERTY_NAME);
         }
-        kmsClient = (KmsClient) kmsClientClass.newInstance();
-      } catch (InstantiationException | IllegalAccessException | BadConfigurationException e) {
+        kmsClient = (KmsClient) kmsClientClass.getDeclaredConstructor().newInstance();
+      } catch (ReflectiveOperationException | BadConfigurationException e) {
         throw new ParquetCryptoRuntimeException("Could not instantiate KmsClient class: " + kmsClientClass, e);
       }
     }
diff --git a/parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ParquetInputFormat.java b/parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ParquetInputFormat.java
index 811e1f383..288e1d241 100644
--- a/parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ParquetInputFormat.java
+++ b/parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ParquetInputFormat.java
@@ -210,8 +210,8 @@ public class ParquetInputFormat<T> extends FileInputFormat<Void, T> {
       return null;
     }
     try {
-      return (UnboundRecordFilter) clazz.newInstance();
-    } catch (InstantiationException | IllegalAccessException e) {
+      return (UnboundRecordFilter) clazz.getDeclaredConstructor().newInstance();
+    } catch (ReflectiveOperationException e) {
       throw new BadConfigurationException("could not instantiate unbound record filter class", e);
     }
   }
@@ -332,8 +332,8 @@ public class ParquetInputFormat<T> extends FileInputFormat<Void, T> {
   @SuppressWarnings("unchecked")
   static <T> ReadSupport<T> getReadSupportInstance(Class<? extends ReadSupport<T>> readSupportClass) {
     try {
-      return readSupportClass.newInstance();
-    } catch (InstantiationException | IllegalAccessException e) {
+      return readSupportClass.getDeclaredConstructor().newInstance();
+    } catch (ReflectiveOperationException e) {
       throw new BadConfigurationException("could not instantiate read support class", e);
     }
   }
diff --git a/parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ParquetOutputFormat.java b/parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ParquetOutputFormat.java
index 4db288f45..0e8823001 100644
--- a/parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ParquetOutputFormat.java
+++ b/parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ParquetOutputFormat.java
@@ -628,8 +628,9 @@ public class ParquetOutputFormat<T> extends FileOutputFormat<Void, T> {
     Class<?> writeSupportClass = getWriteSupportClass(configuration);
     try {
       return (WriteSupport<T>) Objects.requireNonNull(writeSupportClass, "writeSupportClass cannot be null")
+          .getDeclaredConstructor()
           .newInstance();
-    } catch (InstantiationException | IllegalAccessException e) {
+    } catch (ReflectiveOperationException e) {
       throw new BadConfigurationException("could not instantiate write support class: " + writeSupportClass, e);
     }
   }
diff --git a/parquet-thrift/src/main/java/org/apache/parquet/hadoop/thrift/ThriftBytesWriteSupport.java b/parquet-thrift/src/main/java/org/apache/parquet/hadoop/thrift/ThriftBytesWriteSupport.java
index 0ed3f0edf..790e65de5 100644
--- a/parquet-thrift/src/main/java/org/apache/parquet/hadoop/thrift/ThriftBytesWriteSupport.java
+++ b/parquet-thrift/src/main/java/org/apache/parquet/hadoop/thrift/ThriftBytesWriteSupport.java
@@ -154,8 +154,10 @@ public class ThriftBytesWriteSupport extends WriteSupport<BytesWritable> {
     this.configuration = configuration;
     if (this.protocolFactory == null) {
       try {
-        this.protocolFactory = getTProtocolFactoryClass(configuration).newInstance();
-      } catch (InstantiationException | IllegalAccessException e) {
+        this.protocolFactory = getTProtocolFactoryClass(configuration)
+            .getDeclaredConstructor()
+            .newInstance();
+      } catch (ReflectiveOperationException e) {
         throw new RuntimeException(e);
       }
     }
diff --git a/parquet-thrift/src/main/java/org/apache/parquet/thrift/TBaseRecordConverter.java b/parquet-thrift/src/main/java/org/apache/parquet/thrift/TBaseRecordConverter.java
index 22c928137..144b6e553 100644
--- a/parquet-thrift/src/main/java/org/apache/parquet/thrift/TBaseRecordConverter.java
+++ b/parquet-thrift/src/main/java/org/apache/parquet/thrift/TBaseRecordConverter.java
@@ -59,14 +59,15 @@ public class TBaseRecordConverter<T extends TBase<?, ?>> extends ThriftRecordCon
           @Override
           public T readOneRecord(TProtocol protocol) throws TException {
             try {
-              T thriftObject = thriftClass.newInstance();
+              T thriftObject =
+                  thriftClass.getDeclaredConstructor().newInstance();
               thriftObject.read(protocol);
               return thriftObject;
-            } catch (InstantiationException e) {
-              throw new ParquetDecodingException("Could not instantiate Thrift " + thriftClass, e);
             } catch (IllegalAccessException e) {
               throw new ParquetDecodingException(
                   "Thrift class or constructor not public " + thriftClass, e);
+            } catch (ReflectiveOperationException e) {
+              throw new ParquetDecodingException("Could not instantiate Thrift " + thriftClass, e);
             }
           }
         },
diff --git a/parquet-thrift/src/test/java/org/apache/parquet/thrift/TestProtocolReadToWrite.java b/parquet-thrift/src/test/java/org/apache/parquet/thrift/TestProtocolReadToWrite.java
index a92027637..1918dd5ba 100644
--- a/parquet-thrift/src/test/java/org/apache/parquet/thrift/TestProtocolReadToWrite.java
+++ b/parquet-thrift/src/test/java/org/apache/parquet/thrift/TestProtocolReadToWrite.java
@@ -124,7 +124,7 @@ public class TestProtocolReadToWrite {
     writeReadCompare(a);
   }
 
-  private void writeReadCompare(TBase<?, ?> a) throws TException, InstantiationException, IllegalAccessException {
+  private void writeReadCompare(TBase<?, ?> a) throws TException, ReflectiveOperationException {
     ProtocolPipe[] pipes = {
       new ProtocolReadToWrite(),
       new BufferedProtocolReadToWrite(ThriftSchemaConverter.toStructType((Class<TBase<?, ?>>) a.getClass()))
@@ -134,7 +134,7 @@ public class TestProtocolReadToWrite {
       final ByteArrayOutputStream out = new ByteArrayOutputStream();
       a.write(protocol(in));
       p.readOne(protocol(new ByteArrayInputStream(in.toByteArray())), protocol(out));
-      TBase<?, ?> b = a.getClass().newInstance();
+      TBase<?, ?> b = a.getClass().getDeclaredConstructor().newInstance();
       b.read(protocol(new ByteArrayInputStream(out.toByteArray())));
 
       assertThat(b).as(p.getClass().getSimpleName()).isEqualTo(a);
@@ -372,7 +372,8 @@ public class TestProtocolReadToWrite {
     assertThat(countingHandler.recordCountOfMissingFields).isEqualTo(1);
     assertThat(countingHandler.fieldIgnoredCount).isEqualTo(1);
 
-    StructV4WithExtracStructField b = StructV4WithExtracStructField.class.newInstance();
+    StructV4WithExtracStructField b =
+        StructV4WithExtracStructField.class.getDeclaredConstructor().newInstance();
     b.read(protocol(new ByteArrayInputStream(out.toByteArray())));
     assertThat(b.getName()).isEqualTo(dataWithNewSchema.getName());
     assertThat(b.getAge()).isEqualTo(dataWithNewSchema.getAge());