You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@openjpa.apache.org by GitBox <gi...@apache.org> on 2022/07/12 09:56:07 UTC
[GitHub] [openjpa] fuubo opened a new pull request, #98: fix H2 Dictionary autoAssignClause value
fuubo opened a new pull request, #98:
URL: https://github.com/apache/openjpa/pull/98
according to https://github.com/h2database/h2database/issues/3386, `identity` is invalid.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@openjpa.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openjpa] solomax commented on pull request #98: [OPENJPA-2902] fix H2 Dictionary autoAssignClause value
Posted by GitBox <gi...@apache.org>.
solomax commented on PR #98:
URL: https://github.com/apache/openjpa/pull/98#issuecomment-1183042476
Hello @fuubo,
just tried to run current tests without your fix
My steps were:
1. modified https://github.com/apache/openjpa/blob/master/pom.xml#L470
```
diff --git a/pom.xml b/pom.xml
index 1b2516694..c512df03b 100644
--- a/pom.xml
+++ b/pom.xml
@@ -474,9 +474,9 @@
</property>
</activation>
<properties>
- <h2.version>2.0.202</h2.version>
+ <h2.version>2.1.210</h2.version>
<connection.driver.name>org.h2.Driver</connection.driver.name>
- <connection.url>jdbc:h2:./target/database/openjpa-h2-database</connection.url>
+ <connection.url>jdbc:h2:./target/database/openjpa-h2-database;MODE=STRICT</connection.url>
<connection.username />
<connection.password />
<!-- TCK specific properties -->
```
2. Run `mvn clean install -Ptest-h2-2`
Got lots of errors in `SELECT ` statements
I guess I should get some errors in CREATE DATABASE statements without your fix
What am I doing wrong?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@openjpa.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openjpa] fuubo closed pull request #98: [OPENJPA-2902] fix H2 Dictionary autoAssignClause value
Posted by GitBox <gi...@apache.org>.
fuubo closed pull request #98: [OPENJPA-2902] fix H2 Dictionary autoAssignClause value
URL: https://github.com/apache/openjpa/pull/98
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@openjpa.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openjpa] fuubo commented on pull request #98: fix H2 Dictionary autoAssignClause value
Posted by GitBox <gi...@apache.org>.
fuubo commented on PR #98:
URL: https://github.com/apache/openjpa/pull/98#issuecomment-1182891466
> @fuubo can you please create JIRA here: https://issues.apache.org/jira/projects/OPENJPA ? so we can merge this one and get the line in CHANGELOG :)))
https://issues.apache.org/jira/browse/OPENJPA-2902
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@openjpa.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openjpa] solomax commented on pull request #98: [OPENJPA-2902] fix H2 Dictionary autoAssignClause value
Posted by GitBox <gi...@apache.org>.
solomax commented on PR #98:
URL: https://github.com/apache/openjpa/pull/98#issuecomment-1189959513
@fuubo ping? :)))
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@openjpa.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openjpa] solomax commented on pull request #98: fix H2 Dictionary autoAssignClause value
Posted by GitBox <gi...@apache.org>.
solomax commented on PR #98:
URL: https://github.com/apache/openjpa/pull/98#issuecomment-1182707087
@fuubo can you please create JIRA here: https://issues.apache.org/jira/projects/OPENJPA ?
so we can merge this one and get the line in CHANGELOG :)))
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@openjpa.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org