[Bug 53405] New: ExtensionPoint doesn't work with nested import/include

[bu...@apache.org]

https://issues.apache.org/bugzilla/show_bug.cgi?id=53405

          Priority: P2
            Bug ID: 53405
          Assignee: notifications@ant.apache.org
           Summary: ExtensionPoint doesn't work with nested import/include
          Severity: normal
    Classification: Unclassified
                OS: Linux
          Reporter: jlboudart@apache.org
          Hardware: PC
            Status: NEW
           Version: unspecified
         Component: Core
           Product: Ant

Created attachment 28923
  --> https://issues.apache.org/bugzilla/attachment.cgi?id=28923&action=edit
enhanced extension-point-test.xml to reproduce the use case with nested
include/import

ExtensionPoint doesn't work when using nested import/include and fails with a
message "referenced target XXXX is not an extension-point".

Example :
Say we have three distinct build file :
* abstract-compile.xml defining an extension point named "compile"
* compile-java.xml imports abstract-compile.xml and define a concrete target
"compile-java" referenced as an extension-of "compile" 
* build.xml (the main script) including compile-java.xml with a prefix
"myprefix".

When project helper try to handle this use case, the build fail with the
following message :
"referenced target 'compile' is not an extension-point".

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 53405] ExtensionPoint doesn't work with nested import/include

[bu...@apache.org]

https://issues.apache.org/bugzilla/show_bug.cgi?id=53405

Nicolas Lalevée <ni...@hibnet.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #2 from Nicolas Lalevée <ni...@hibnet.org> ---
Patch applied.
Thanks!

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 53405] ExtensionPoint doesn't work with nested import/include

[bu...@apache.org]

https://issues.apache.org/bugzilla/show_bug.cgi?id=53405

Jean-Louis Boudart <jl...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #28923|0                           |1
        is obsolete|                            |

--- Comment #1 from Jean-Louis Boudart <jl...@apache.org> ---
Created attachment 28924
  --> https://issues.apache.org/bugzilla/attachment.cgi?id=28924&action=edit
patch to add support of extensionpoint with nested import and include

The problems seems to come when ProjectHelper duplicate the extension point
while importing a build file.
ProjectHelper2 implementation is cloning the extension point as if it was a
Target (using Target clone constructor).
Then, implementation check instanceof extension point and fails with the
message mentioned in original description as it is a Target instance and not an
ExtensionPoint instance.

I attached a patch to fix this.

-- 
You are receiving this mail because:
You are the assignee for the bug.