You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by davinash <gi...@git.apache.org> on 2016/12/17 10:59:22 UTC
[GitHub] geode pull request #322: [GEODE-165] Fix for Add build support for generatin...
GitHub user davinash opened a pull request:
https://github.com/apache/geode/pull/322
[GEODE-165] Fix for Add build support for generating antlr classes from grammar
1. Updated spotless configuration to exclude 'generated-src' directory.
2. Removed
OQLLexerTokenTypes.java
OQLLexerTokenTypes.txt
OQLParser.java
OQLLexer.java
3. Removed above files entry from rat
Thanks @metatype for helping in gradle configuration.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/davinash/geode feature/GEODE-165
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/geode/pull/322.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #322
----
commit d68d32c63fa90254b34116320bc2889a366c12c3
Author: adongre <ad...@apache.org>
Date: 2016-12-16T08:47:10Z
GEODE-165: Removed OQL generated files and added the target into geode-core/build.gradle.
commit e83732fdd3890783c991a81b824a5c4207a2ddaf
Author: adongre <ad...@apache.org>
Date: 2016-12-17T10:38:55Z
GEODE-165 : Updating spotless configuration to exclude 'generated-src' directory.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode issue #322: [GEODE-165] Fix for Add build support for generating antlr...
Posted by upthewaterspout <gi...@git.apache.org>.
Github user upthewaterspout commented on the issue:
https://github.com/apache/geode/pull/322
Yeah, I think it's good to go.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode issue #322: [GEODE-165] Fix for Add build support for generating antlr...
Posted by agingade <gi...@git.apache.org>.
Github user agingade commented on the issue:
https://github.com/apache/geode/pull/322
Earlier the files used to be generated when the grammar files are changed (which was a rare case); with this change are we generating the files, every time when the build/compilation is done?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode pull request #322: [GEODE-165] Fix for Add build support for generatin...
Posted by davinash <gi...@git.apache.org>.
Github user davinash closed the pull request at:
https://github.com/apache/geode/pull/322
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode issue #322: [GEODE-165] Fix for Add build support for generating antlr...
Posted by davinash <gi...@git.apache.org>.
Github user davinash commented on the issue:
https://github.com/apache/geode/pull/322
Thanks @upthewaterspout , Is this PR good for merge to develop now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode issue #322: [GEODE-165] Fix for Add build support for generating antlr...
Posted by upthewaterspout <gi...@git.apache.org>.
Github user upthewaterspout commented on the issue:
https://github.com/apache/geode/pull/322
@agingade - Yeah, they'll get generated every time you do a clean followed a by a build. Presumably if you don't do a clean the antlr plugin will detect if the files are up to date.
Prior to this fix I don't think there was even a README on how to generate these files. This fix is really the ideal solution - generated files should never be checked in to the source. This way everyone knows they need to modify oql.g, and everyone knows how to generate the resulting files because it happens automatically as part of the build.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode issue #322: [GEODE-165] Fix for Add build support for generating antlr...
Posted by scmbuildguy <gi...@git.apache.org>.
Github user scmbuildguy commented on the issue:
https://github.com/apache/geode/pull/322
+1 - I agree with generating these files should be done at build time and not checked into source.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode issue #322: [GEODE-165] Fix for Add build support for generating antlr...
Posted by upthewaterspout <gi...@git.apache.org>.
Github user upthewaterspout commented on the issue:
https://github.com/apache/geode/pull/322
+1 Awesome!!!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---