[GitHub] [hadoop] ayushtkn commented on a diff in pull request #4339: HDFS-16587. Allow configuring the number of JournalNodeRPCServer Hand…

[GitBox <gi...@apache.org>]

ayushtkn commented on code in PR #4339:
URL: https://github.com/apache/hadoop/pull/4339#discussion_r882092952


##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/qjournal/server/JournalNodeRpcServer.java:
##########
@@ -90,13 +91,15 @@ public class JournalNodeRpcServer implements QJournalProtocol,
         new QJournalProtocolServerSideTranslatorPB(this);
     BlockingService service = QJournalProtocolService
         .newReflectiveBlockingService(translator);
+    int handler = conf.getInt(DFS_JOURNALNODE_HANDLER_COUNT_KEY,
+        DFS_JOURNALNODE_HANDLER_COUNT_DEFAULT);

Review Comment:
   Add some validation here for a valid value range, as in shouldn't be negative or so.
   If it is an invalid entry, Add a warn log and use the default value.
   Post that have a INFO log telling about the handler count...



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org