You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hawq.apache.org by jiny2 <gi...@git.apache.org> on 2016/12/29 04:06:04 UTC
[GitHub] incubator-hawq pull request #1071: HAWQ-1242. hawq-site.xml default content ...
GitHub user jiny2 opened a pull request:
https://github.com/apache/incubator-hawq/pull/1071
HAWQ-1242. hawq-site.xml default content has wrong guc variable names
Fixed the wrong names in hawq-site.xml and its template file.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jiny2/incubator-hawq HAWQ-1242
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-hawq/pull/1071.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1071
----
commit 4b2655bc17aceaa67e9db7b53147584f7860c61e
Author: Yi <yj...@pivotal.io>
Date: 2016-12-29T04:03:11Z
HAWQ-1242. hawq-site.xml default content has wrong guc variable names
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #1071: HAWQ-1242. hawq-site.xml default content ...
Posted by jiny2 <gi...@git.apache.org>.
Github user jiny2 closed the pull request at:
https://github.com/apache/incubator-hawq/pull/1071
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq issue #1071: HAWQ-1242. hawq-site.xml default content has wro...
Posted by stanlyxiang <gi...@git.apache.org>.
Github user stanlyxiang commented on the issue:
https://github.com/apache/incubator-hawq/pull/1071
Some of the concourse feature tests failed with this commit. There are some other place use these guc name with the prefix 'hawq_'. So what about keep the prefix in the hawq-site.xml and add the prefix to the guc in guc.c ? This can reduce the work to find all the places use the several guc you changed and keep the name consistently with other gucs name.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq issue #1071: HAWQ-1242. hawq-site.xml default content has wro...
Posted by stanlyxiang <gi...@git.apache.org>.
Github user stanlyxiang commented on the issue:
https://github.com/apache/incubator-hawq/pull/1071
@radarwave In my investigate, I found that hawq read these GUCs from a config file which set these values when init, since there is no database to store them before init. Maybe no one config / show them using hawq config or they use option "--skipValidation". No one change and no one hit this problem, only some warnings exist in logs. No function read "dfs_url" "master_directory" "seg_directory".
But RM function sendIMAlive() will use "standby_addr_host" and I haven't found the reason. Maybe @jiny2 knows why.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq issue #1071: HAWQ-1242. hawq-site.xml default content has wro...
Posted by jiny2 <gi...@git.apache.org>.
Github user jiny2 commented on the issue:
https://github.com/apache/incubator-hawq/pull/1071
I find there is some python script logic using the hawq_* guc names, I will keep those hawq_* guc names to avoid changing python scripts.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq issue #1071: HAWQ-1242. hawq-site.xml default content has wro...
Posted by jiny2 <gi...@git.apache.org>.
Github user jiny2 commented on the issue:
https://github.com/apache/incubator-hawq/pull/1071
@huor @radarwave Please have a review. Thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq issue #1071: HAWQ-1242. hawq-site.xml default content has wro...
Posted by radarwave <gi...@git.apache.org>.
Github user radarwave commented on the issue:
https://github.com/apache/incubator-hawq/pull/1071
LGTM.
Just wondering how hawq read these mis-match GUCs before you change them? Seems they still can get the right values.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq issue #1071: HAWQ-1242. hawq-site.xml default content has wro...
Posted by paul-guo- <gi...@git.apache.org>.
Github user paul-guo- commented on the issue:
https://github.com/apache/incubator-hawq/pull/1071
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq issue #1071: HAWQ-1242. hawq-site.xml default content has wro...
Posted by jiny2 <gi...@git.apache.org>.
Github user jiny2 commented on the issue:
https://github.com/apache/incubator-hawq/pull/1071
In fact some gucs are not used by reading from hawq-site.xml, for example, hawq_master_directory. But for standby_addr_host, it is useful for RM as RM switches its heart-beat to standby server when master server is not achievable.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq issue #1071: HAWQ-1242. hawq-site.xml default content has wro...
Posted by huor <gi...@git.apache.org>.
Github user huor commented on the issue:
https://github.com/apache/incubator-hawq/pull/1071
+1 for the fix
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq issue #1071: HAWQ-1242. hawq-site.xml default content has wro...
Posted by jiny2 <gi...@git.apache.org>.
Github user jiny2 commented on the issue:
https://github.com/apache/incubator-hawq/pull/1071
@huor @stanlyxiang @paul-guo-
@stanlyxiang is right, the correct approach is to fix guc.c as all external scripts and documentation are using hawq_* names.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq issue #1071: HAWQ-1242. hawq-site.xml default content has wro...
Posted by paul-guo- <gi...@git.apache.org>.
Github user paul-guo- commented on the issue:
https://github.com/apache/incubator-hawq/pull/1071
Otherwise +1. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq issue #1071: HAWQ-1242. hawq-site.xml default content has wro...
Posted by paul-guo- <gi...@git.apache.org>.
Github user paul-guo- commented on the issue:
https://github.com/apache/incubator-hawq/pull/1071
1) Please make sure the doc has corresponding change if needed (notify them if needed). If I remember correctly, dfs_url is still in that doc.
2) Please make the commit message begin with HAWQ-1242 since we have a script, which needs this pattern, to detect the Apache JIRA status.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---