[GitHub] [hadoop] mukund-thakur commented on a change in pull request #1944: HADOOP-16900. Very large files can be truncated when written through S3AFileSystem

[GitBox <gi...@apache.org>]

mukund-thakur commented on a change in pull request #1944:
URL: https://github.com/apache/hadoop/pull/1944#discussion_r415614919



##########
File path: hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/commit/CommitOperations.java
##########
@@ -481,6 +483,15 @@ public SinglePendingCommit uploadFileToPendingCommit(File localFile,
       if (numParts == 0) {
         numParts = 1;
       }
+      if (numParts >= InternalConstants.UPLOAD_PART_COUNT_LIMIT) {

Review comment:
       Should be greater than only right??




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org