[jira] [Commented] (TRB-98) Fulcrum Torque

["Thomas Vandahl (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TRB-98?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15404330#comment-15404330 ] 

Thomas Vandahl commented on TRB-98:
-----------------------------------

For the record: Torque 4.x is no longer limited to hard-coded databases nor table names. The "database name" is only a pointer to a connection pool name that can connect to any database - and always has been. The table names can be overridden in the table map.

I'm a bit concerned that this change will create more complexity than it resolves. If it is that complicated to get Fulcrum Security to work with Torque, we can just drop support for it and go with Hibernate (or JPA, for that matter).


> Fulcrum Torque
> --------------
>
>                 Key: TRB-98
>                 URL: https://issues.apache.org/jira/browse/TRB-98
>             Project: Turbine
>          Issue Type: Improvement
>          Components: Fulcrum
>    Affects Versions: Core 4.0-M2
>            Reporter: Georg Kallidis
>            Assignee: Georg Kallidis
>             Fix For: Core 4.0 Final
>
>
> The separation of security component from Turbine to Fulcrum Security has one backdraw. The component contains generated classes and as the schema is hard coded (database name fulcrum, table names fulcrum_turbine_user, etc.)  - if you don´t care about the abstract classes it would not matter - but as the interface hierarchy is more complex now than before (TorqueAbstractSecurityEntity etcetera), one would really like to have those convenience classes ready at hand, especially in at least one context more: The old Turbine schema, which was removed after Turbine-M1, which could be found before in turbine/src/torque/schema/torque-security-schema.xml. 
> I would recommend to have generated classes according or very similar to this old schema with appropriate abstract classes. Configuration of managers could be made a little more generic removing import statements of special classes, and renaming others, but those abstract classes could not. It is done quite easily, but gets a little more similar generated code, but you have not break your head about, why it doesn´t match. Suggestions for naming? I would just remove the Torque at the beginning.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)