You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Jonathan Natkins (Created) (JIRA)" <ji...@apache.org> on 2012/03/20 02:19:37 UTC

[jira] [Created] (HADOOP-8189) LdapGroupsMapping shouldn't throw away IOException

LdapGroupsMapping shouldn't throw away IOException
--------------------------------------------------

                 Key: HADOOP-8189
                 URL: https://issues.apache.org/jira/browse/HADOOP-8189
             Project: Hadoop Common
          Issue Type: Bug
          Components: security
            Reporter: Jonathan Natkins
            Assignee: Jonathan Natkins


When extracting a password from a file during the config setup, the LdapGroupsMapping throws a RuntimeException, but doesn't bubble up the IOException that caused it

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HADOOP-8189) LdapGroupsMapping shouldn't throw away IOException

Posted by "Aaron T. Myers (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-8189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Aaron T. Myers updated HADOOP-8189:
-----------------------------------

       Resolution: Fixed
    Fix Version/s: 0.23.3
     Hadoop Flags: Reviewed
           Status: Resolved  (was: Patch Available)

I've just committed this to trunk and branch-0.23. Thanks a lot, Natty.
                
> LdapGroupsMapping shouldn't throw away IOException
> --------------------------------------------------
>
>                 Key: HADOOP-8189
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8189
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: security
>    Affects Versions: 0.23.3
>            Reporter: Jonathan Natkins
>            Assignee: Jonathan Natkins
>             Fix For: 0.23.3
>
>         Attachments: HADOOP-8189.patch, HADOOP-8189.patch
>
>
> When extracting a password from a file during the config setup, the LdapGroupsMapping throws a RuntimeException, but doesn't bubble up the IOException that caused it

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-8189) LdapGroupsMapping shouldn't throw away IOException

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13233794#comment-13233794 ] 

Hudson commented on HADOOP-8189:
--------------------------------

Integrated in Hadoop-Hdfs-0.23-Commit #699 (See [https://builds.apache.org/job/Hadoop-Hdfs-0.23-Commit/699/])
    HADOOP-8189. LdapGroupsMapping shouldn't throw away IOException. Contributed by Jonathan Natkins. (Revision 1302784)

     Result = SUCCESS
atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1302784
Files : 
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/LdapGroupsMapping.java

                
> LdapGroupsMapping shouldn't throw away IOException
> --------------------------------------------------
>
>                 Key: HADOOP-8189
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8189
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: security
>    Affects Versions: 0.23.3
>            Reporter: Jonathan Natkins
>            Assignee: Jonathan Natkins
>             Fix For: 0.23.3
>
>         Attachments: HADOOP-8189.patch, HADOOP-8189.patch
>
>
> When extracting a password from a file during the config setup, the LdapGroupsMapping throws a RuntimeException, but doesn't bubble up the IOException that caused it

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-8189) LdapGroupsMapping shouldn't throw away IOException

Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13233128#comment-13233128 ] 

Hadoop QA commented on HADOOP-8189:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12519003/HADOOP-8189.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 eclipse:eclipse.  The patch built with eclipse:eclipse.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed unit tests in .

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/734//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/734//console

This message is automatically generated.
                
> LdapGroupsMapping shouldn't throw away IOException
> --------------------------------------------------
>
>                 Key: HADOOP-8189
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8189
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: security
>    Affects Versions: 0.23.3
>            Reporter: Jonathan Natkins
>            Assignee: Jonathan Natkins
>         Attachments: HADOOP-8189.patch, HADOOP-8189.patch
>
>
> When extracting a password from a file during the config setup, the LdapGroupsMapping throws a RuntimeException, but doesn't bubble up the IOException that caused it

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HADOOP-8189) LdapGroupsMapping shouldn't throw away IOException

Posted by "Jonathan Natkins (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-8189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonathan Natkins updated HADOOP-8189:
-------------------------------------

    Attachment: HADOOP-8189.patch
    
> LdapGroupsMapping shouldn't throw away IOException
> --------------------------------------------------
>
>                 Key: HADOOP-8189
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8189
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: security
>    Affects Versions: 0.23.3
>            Reporter: Jonathan Natkins
>            Assignee: Jonathan Natkins
>         Attachments: HADOOP-8189.patch, HADOOP-8189.patch
>
>
> When extracting a password from a file during the config setup, the LdapGroupsMapping throws a RuntimeException, but doesn't bubble up the IOException that caused it

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-8189) LdapGroupsMapping shouldn't throw away IOException

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13233833#comment-13233833 ] 

Hudson commented on HADOOP-8189:
--------------------------------

Integrated in Hadoop-Mapreduce-trunk #1025 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1025/])
    HADOOP-8189. LdapGroupsMapping shouldn't throw away IOException. Contributed by Jonathan Natkins. (Revision 1302783)

     Result = SUCCESS
atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1302783
Files : 
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/LdapGroupsMapping.java

                
> LdapGroupsMapping shouldn't throw away IOException
> --------------------------------------------------
>
>                 Key: HADOOP-8189
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8189
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: security
>    Affects Versions: 0.23.3
>            Reporter: Jonathan Natkins
>            Assignee: Jonathan Natkins
>             Fix For: 0.23.3
>
>         Attachments: HADOOP-8189.patch, HADOOP-8189.patch
>
>
> When extracting a password from a file during the config setup, the LdapGroupsMapping throws a RuntimeException, but doesn't bubble up the IOException that caused it

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HADOOP-8189) LdapGroupsMapping shouldn't throw away IOException

Posted by "Jonathan Natkins (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-8189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonathan Natkins updated HADOOP-8189:
-------------------------------------

    Status: Patch Available  (was: Open)
    
> LdapGroupsMapping shouldn't throw away IOException
> --------------------------------------------------
>
>                 Key: HADOOP-8189
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8189
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: security
>            Reporter: Jonathan Natkins
>            Assignee: Jonathan Natkins
>         Attachments: HADOOP-8189.patch
>
>
> When extracting a password from a file during the config setup, the LdapGroupsMapping throws a RuntimeException, but doesn't bubble up the IOException that caused it

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-8189) LdapGroupsMapping shouldn't throw away IOException

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13233757#comment-13233757 ] 

Hudson commented on HADOOP-8189:
--------------------------------

Integrated in Hadoop-Mapreduce-0.23-Build #231 (See [https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Build/231/])
    HADOOP-8189. LdapGroupsMapping shouldn't throw away IOException. Contributed by Jonathan Natkins. (Revision 1302784)

     Result = FAILURE
atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1302784
Files : 
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/LdapGroupsMapping.java

                
> LdapGroupsMapping shouldn't throw away IOException
> --------------------------------------------------
>
>                 Key: HADOOP-8189
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8189
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: security
>    Affects Versions: 0.23.3
>            Reporter: Jonathan Natkins
>            Assignee: Jonathan Natkins
>             Fix For: 0.23.3
>
>         Attachments: HADOOP-8189.patch, HADOOP-8189.patch
>
>
> When extracting a password from a file during the config setup, the LdapGroupsMapping throws a RuntimeException, but doesn't bubble up the IOException that caused it

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-8189) LdapGroupsMapping shouldn't throw away IOException

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13233784#comment-13233784 ] 

Hudson commented on HADOOP-8189:
--------------------------------

Integrated in Hadoop-Common-trunk-Commit #1907 (See [https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1907/])
    HADOOP-8189. LdapGroupsMapping shouldn't throw away IOException. Contributed by Jonathan Natkins. (Revision 1302783)

     Result = SUCCESS
atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1302783
Files : 
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/LdapGroupsMapping.java

                
> LdapGroupsMapping shouldn't throw away IOException
> --------------------------------------------------
>
>                 Key: HADOOP-8189
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8189
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: security
>    Affects Versions: 0.23.3
>            Reporter: Jonathan Natkins
>            Assignee: Jonathan Natkins
>             Fix For: 0.23.3
>
>         Attachments: HADOOP-8189.patch, HADOOP-8189.patch
>
>
> When extracting a password from a file during the config setup, the LdapGroupsMapping throws a RuntimeException, but doesn't bubble up the IOException that caused it

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-8189) LdapGroupsMapping shouldn't throw away IOException

Posted by "Jonathan Natkins (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13233118#comment-13233118 ] 

Jonathan Natkins commented on HADOOP-8189:
------------------------------------------

Attaching patch that renames exception variable to ioe
                
> LdapGroupsMapping shouldn't throw away IOException
> --------------------------------------------------
>
>                 Key: HADOOP-8189
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8189
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: security
>    Affects Versions: 0.23.3
>            Reporter: Jonathan Natkins
>            Assignee: Jonathan Natkins
>         Attachments: HADOOP-8189.patch, HADOOP-8189.patch
>
>
> When extracting a password from a file during the config setup, the LdapGroupsMapping throws a RuntimeException, but doesn't bubble up the IOException that caused it

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HADOOP-8189) LdapGroupsMapping shouldn't throw away IOException

Posted by "Aaron T. Myers (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-8189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Aaron T. Myers updated HADOOP-8189:
-----------------------------------

     Target Version/s: 0.23.3
    Affects Version/s: 0.23.3
    
> LdapGroupsMapping shouldn't throw away IOException
> --------------------------------------------------
>
>                 Key: HADOOP-8189
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8189
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: security
>    Affects Versions: 0.23.3
>            Reporter: Jonathan Natkins
>            Assignee: Jonathan Natkins
>         Attachments: HADOOP-8189.patch
>
>
> When extracting a password from a file during the config setup, the LdapGroupsMapping throws a RuntimeException, but doesn't bubble up the IOException that caused it

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-8189) LdapGroupsMapping shouldn't throw away IOException

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13233771#comment-13233771 ] 

Hudson commented on HADOOP-8189:
--------------------------------

Integrated in Hadoop-Common-0.23-Commit #708 (See [https://builds.apache.org/job/Hadoop-Common-0.23-Commit/708/])
    HADOOP-8189. LdapGroupsMapping shouldn't throw away IOException. Contributed by Jonathan Natkins. (Revision 1302784)

     Result = SUCCESS
atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1302784
Files : 
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/LdapGroupsMapping.java

                
> LdapGroupsMapping shouldn't throw away IOException
> --------------------------------------------------
>
>                 Key: HADOOP-8189
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8189
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: security
>    Affects Versions: 0.23.3
>            Reporter: Jonathan Natkins
>            Assignee: Jonathan Natkins
>             Fix For: 0.23.3
>
>         Attachments: HADOOP-8189.patch, HADOOP-8189.patch
>
>
> When extracting a password from a file during the config setup, the LdapGroupsMapping throws a RuntimeException, but doesn't bubble up the IOException that caused it

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-8189) LdapGroupsMapping shouldn't throw away IOException

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13233800#comment-13233800 ] 

Hudson commented on HADOOP-8189:
--------------------------------

Integrated in Hadoop-Hdfs-trunk-Commit #1981 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1981/])
    HADOOP-8189. LdapGroupsMapping shouldn't throw away IOException. Contributed by Jonathan Natkins. (Revision 1302783)

     Result = SUCCESS
atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1302783
Files : 
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/LdapGroupsMapping.java

                
> LdapGroupsMapping shouldn't throw away IOException
> --------------------------------------------------
>
>                 Key: HADOOP-8189
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8189
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: security
>    Affects Versions: 0.23.3
>            Reporter: Jonathan Natkins
>            Assignee: Jonathan Natkins
>             Fix For: 0.23.3
>
>         Attachments: HADOOP-8189.patch, HADOOP-8189.patch
>
>
> When extracting a password from a file during the config setup, the LdapGroupsMapping throws a RuntimeException, but doesn't bubble up the IOException that caused it

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-8189) LdapGroupsMapping shouldn't throw away IOException

Posted by "Aaron T. Myers (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13233113#comment-13233113 ] 

Aaron T. Myers commented on HADOOP-8189:
----------------------------------------

Patch looks good to me. One tiny nit:

# Please rename the exception variable to "ioe", as is standard in the Hadoop code.

+1 once this is addressed and Jenkins comes back clean.
                
> LdapGroupsMapping shouldn't throw away IOException
> --------------------------------------------------
>
>                 Key: HADOOP-8189
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8189
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: security
>    Affects Versions: 0.23.3
>            Reporter: Jonathan Natkins
>            Assignee: Jonathan Natkins
>         Attachments: HADOOP-8189.patch
>
>
> When extracting a password from a file during the config setup, the LdapGroupsMapping throws a RuntimeException, but doesn't bubble up the IOException that caused it

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-8189) LdapGroupsMapping shouldn't throw away IOException

Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13233112#comment-13233112 ] 

Hadoop QA commented on HADOOP-8189:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12518997/HADOOP-8189.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 eclipse:eclipse.  The patch built with eclipse:eclipse.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    -1 core tests.  The patch failed these unit tests:
                  org.apache.hadoop.fs.viewfs.TestViewFsTrash

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/733//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/733//console

This message is automatically generated.
                
> LdapGroupsMapping shouldn't throw away IOException
> --------------------------------------------------
>
>                 Key: HADOOP-8189
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8189
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: security
>    Affects Versions: 0.23.3
>            Reporter: Jonathan Natkins
>            Assignee: Jonathan Natkins
>         Attachments: HADOOP-8189.patch
>
>
> When extracting a password from a file during the config setup, the LdapGroupsMapping throws a RuntimeException, but doesn't bubble up the IOException that caused it

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HADOOP-8189) LdapGroupsMapping shouldn't throw away IOException

Posted by "Jonathan Natkins (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-8189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonathan Natkins updated HADOOP-8189:
-------------------------------------

    Attachment: HADOOP-8189.patch
    
> LdapGroupsMapping shouldn't throw away IOException
> --------------------------------------------------
>
>                 Key: HADOOP-8189
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8189
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: security
>            Reporter: Jonathan Natkins
>            Assignee: Jonathan Natkins
>         Attachments: HADOOP-8189.patch
>
>
> When extracting a password from a file during the config setup, the LdapGroupsMapping throws a RuntimeException, but doesn't bubble up the IOException that caused it

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira