[GitHub] [superset] AAfghahi commented on a diff in pull request #19753: fix(QueryContext): validation does not validate query_context metrics

[GitBox <gi...@apache.org>]

AAfghahi commented on code in PR #19753:
URL: https://github.com/apache/superset/pull/19753#discussion_r854217388


##########
tests/integration_tests/databases/api_tests.py:
##########
@@ -1111,6 +1111,7 @@ def test_get_allow_file_upload_true_csv(self):
     def mock_empty_csv_function(d, user):
         return []
 
+    @pytest.mark.skip("the excepted count is not well defined")

Review Comment:
   Looked at this today in the context of your PR. The unfortunate fact is that this is a filter that depends on side effects from other tests, since it is just querying every database. When I created the test the value was consistently 0 in my local test environment, but it failed in the CI with a count of 1, which we attributed to these side effects. I think it is good to change this to 0 and not skip it. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org