You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "zeroshade (via GitHub)" <gi...@apache.org> on 2023/05/23 15:35:47 UTC

[GitHub] [arrow] zeroshade commented on issue #35711: Add ability to read values from (Dictionary) Builders

zeroshade commented on issue #35711:
URL: https://github.com/apache/arrow/issues/35711#issuecomment-1559683214

   @metalmatze this seems like a good idea (though for the dictionary builder getting an index you only have to handle the integral types, int8/16/32/64 and uint8/16/32/64, as all the other types are not valid dictionary index types).
   
   For a binary memo table, since it maintains a binary builder internally and only stores the dictionary indices in the hash table as the values, it should be pretty easy to add a `Value` method which takes in an index and returns the value by calling `b.builder.Value(idx)`. The other types would be a bit harder and would likely require maintaining some sort of reverse mapping.
   
   Would you be willing to make a PR for this? At least for the binary dictionary types since that would be pretty easy to implement as suggested above.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org