You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/03/26 14:24:56 UTC

[GitHub] [spark] awdavidson commented on a change in pull request #35976: SPARK-38661: [TESTS][FOLLOWUP] Replace Symbol usage with $"" in unit tests

awdavidson commented on a change in pull request #35976:
URL: https://github.com/apache/spark/pull/35976#discussion_r835770569



##########
File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/CatalystTypeConvertersSuite.scala
##########
@@ -148,7 +148,7 @@ class CatalystTypeConvertersSuite extends SparkFunSuite with SQLHelper {
   }
 
   test("SPARK-24571: convert Char to String") {
-    val chr: Char = 'X'
+    val chr: Char = $"X"'

Review comment:
       Doesn’t look like this should have been changed?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org