You are viewing a plain text version of this content. The canonical link for it is here.
Posted to codereview@trafodion.apache.org by DaveBirdsall <gi...@git.apache.org> on 2016/01/29 02:11:46 UTC

[GitHub] incubator-trafodion pull request: [TRAFODION-1775][TRAFODION-1777]...

GitHub user DaveBirdsall opened a pull request:

    https://github.com/apache/incubator-trafodion/pull/292

    [TRAFODION-1775][TRAFODION-1777] UPDATE STATS usability improvements

    For [TRAFODION-1775], added a check to UPDATE STATISTICS to return a new error (9243) if UPDATE STATISTICS is attempted on a large table (100,000,000 or more rows) without a SAMPLE clause. Added an explicit NO SAMPLE clause to the syntax to override this check. The value 100,000,000 is not hard-coded; it can be changed via CQD USTAT_YOULL_LIKELY_BE_SORRY.
    
    For [TRAFODION-1777], fixed a minor annoyance. UPDATE STATISTICS on a non-existing object would return three error messages that the object doesn't exist. Changed it to return just one.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/DaveBirdsall/incubator-trafodion Trafodion1775

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-trafodion/pull/292.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #292
    
----
commit 758d97baf3727ba0634ed4cdd280d11e1f7a1947
Author: Dave Birdsall <db...@apache.org>
Date:   2016-01-29T01:05:29Z

    [TRAFODION-1775][TRAFODION-1777] UPDATE STATS usability improvements

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafodion pull request: [TRAFODION-1775][TRAFODION-1777]...

Posted by zellerh <gi...@git.apache.org>.
Github user zellerh commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/292#discussion_r51222120
  
    --- Diff: core/sql/sqlcomp/DefaultConstants.h ---
    @@ -709,6 +709,7 @@ enum DefaultConstants
                                                 // CQDs are delimited by ","
       USTAT_MIN_CHAR_UEC_FOR_IS,     // minimum UEC for char type to use internal sort
       USTAT_MIN_DEC_BIN_UEC_FOR_IS,  // minimum UEC for binary types to use internal sort
    +  USTAT_YOULL_LIKELY_BE_SORRY, // minimum row count where explicit NO SAMPLE clause is required
    --- End diff --
    
    :-)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafodion pull request: [TRAFODION-1775][TRAFODION-1777]...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-trafodion/pull/292


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---