[GitHub] [spark] cloud-fan commented on a diff in pull request #37228: [SPARK-37980][SQL] Extend METADATA column to support row indexes for Parquet files

[GitBox <gi...@apache.org>]

cloud-fan commented on code in PR #37228:
URL: https://github.com/apache/spark/pull/37228#discussion_r945887348


##########
sql/core/src/main/java/org/apache/spark/sql/execution/datasources/parquet/VectorizedParquetRecordReader.java:
##########
@@ -324,6 +331,10 @@ public boolean nextBatch() throws IOException {
       }
       cv.assemble();
     }
+    // If needed, compute row indexes within a file.
+    if (rowIndexGenerator != null) {
+      rowIndexGenerator.populateRowIndex(columnVectors, num);

Review Comment:
   Sorry I'm not very familiar with parquet read codebase, does this happen after row group skipping or not?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org