[jira] [Commented] (KNOX-1651) Cleanup *IdentityAsserterMessages interfaces

["Kevin Risden (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KNOX-1651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16708901#comment-16708901 ] 

Kevin Risden commented on KNOX-1651:
------------------------------------

There are unused *IdentityAsserterMessages interfaces that look like they are leftover from older logging. This should avoid having the issue in the future.

> Cleanup *IdentityAsserterMessages interfaces
> --------------------------------------------
>
>                 Key: KNOX-1651
>                 URL: https://issues.apache.org/jira/browse/KNOX-1651
>             Project: Apache Knox
>          Issue Type: Bug
>            Reporter: Kevin Risden
>            Assignee: Kevin Risden
>            Priority: Blocker
>             Fix For: 1.2.0
>
>         Attachments: KNOX-1651.patch
>
>
> Currently there are multiple IdentityAsserterMessages interfaces defined in two different modules. 
> {code:java}
> gateway-provider-identity-assertion-common/src/main/java/org/apache/knox/gateway/IdentityAsserterMessages.java:public interface IdentityAsserterMessages {
> gateway-provider-identity-assertion-pseudo/src/main/java/org/apache/knox/gateway/IdentityAsserterMessages.java:public interface IdentityAsserterMessages {
> {code}
> This doesn't cause any issues during mvn testing since each Maven module gets a different classpath. This came up when misconfiguring Knoxsso and got the following stacktrace.
> {code:java}
> Caused by: java.lang.NoSuchMethodError: org.apache.knox.gateway.IdentityAsserterMessages.subjectNotAvailable()V
> at org.apache.knox.gateway.identityasserter.common.filter.CommonIdentityAssertionFilter.doFilter(CommonIdentityAssertionFilter.java:78)
> at org.apache.knox.gateway.GatewayFilter$Holder.doFilter(GatewayFilter.java:369)
> at org.apache.knox.gateway.GatewayFilter$Chain.doFilter(GatewayFilter.java:269)
> at org.apache.knox.gateway.webappsec.filter.XFrameOptionsFilter.doFilter(XFrameOptionsFilter.java:52)
> at org.apache.knox.gateway.GatewayFilter$Holder.doFilter(GatewayFilter.java:369)
> at org.apache.knox.gateway.GatewayFilter$Chain.doFilter(GatewayFilter.java:269)
> at org.apache.knox.gateway.filter.XForwardedHeaderFilter.doFilter(XForwardedHeaderFilter.java:30)
> at org.apache.knox.gateway.filter.AbstractGatewayFilter.doFilter(AbstractGatewayFilter.java:58){code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)