You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/10/14 20:25:08 UTC

[GitHub] [beam] robertwb commented on a change in pull request #13102: [BEAM-9547] Add support for `DataFrame.assign`

robertwb commented on a change in pull request #13102:
URL: https://github.com/apache/beam/pull/13102#discussion_r504950839



##########
File path: sdks/python/apache_beam/dataframe/frame_base.py
##########
@@ -216,20 +216,42 @@ def wrapper(*args, **kwargs):
       else:
         constant_args[ix] = arg
 
+    deferred_kwarg_keys = []

Review comment:
       It might be worth an explicit test in frame_base_test for the kwargs functionality. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org