You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jmeter.apache.org by Philippe Mouawad <p....@ubik-ingenierie.com> on 2017/02/25 22:17:27 UTC
Drop HTMLAssertion
Hello,
I propose to drop HTML Assertion element as it does not support HTML5 and
it seems not possible to support it easily :
- https://bz.apache.org/bugzilla/show_bug.cgi?id=60774
Besides, I am not sure it is really a useful element.
Regards
Philippe
Re: Drop HTMLAssertion
Posted by Philippe Mouawad <ph...@gmail.com>.
Hi Felix,
Thanks for your answer.
I never use this feature neither.
I raised this subject while reviewing code.
Regards
On Sun, Apr 30, 2017 at 12:28 PM, Felix Schumacher <
felix.schumacher@internetallee.de> wrote:
> Am 19.04.2017 um 22:32 schrieb Philippe Mouawad:
>
>> Hello Felix,
>> What shall we do with this ?
>> Will you be committing your patch ?
>>
> Sorry for the late response.
>
> I can commit the patch, I have even done some further implementation, that
> enables the selection of xhtml, or normal html, BUT I think the parser is
> too lax, to be of real value.
>
> Can you try the current implementation, if it is good enough for your use
> case? I have to admit, that I never really used this feature.
>
> Felix
>
>
> Thanks
>>
>> On Sun, Feb 26, 2017 at 1:28 PM, Philippe Mouawad <
>> philippe.mouawad@gmail.com> wrote:
>>
>> Hello,
>>> As Felix has found a way to do it with reasonable piece of work, I change
>>> my opinion to keep it with following changes:
>>> - Drop JTidy and use JSoup
>>> - or keep JTidy but make JSoup the default
>>>
>>> Regards
>>>
>>> On Sun, Feb 26, 2017 at 1:16 PM, sebb <se...@gmail.com> wrote:
>>>
>>> Please ask the User list whether or not it is being used.
>>>>
>>>> On 26 February 2017 at 12:02, Maxime Chassagneux
>>>> <ma...@gmail.com> wrote:
>>>>
>>>>> +1 too
>>>>>
>>>>> 2017-02-26 10:58 GMT+01:00 Antonio Gomes Rodrigues <ra...@gmail.com>:
>>>>>
>>>>> +1 to me
>>>>>>
>>>>>> Le 26 févr. 2017 10:17, "Graham Russell" <gr...@ham1.co.uk> a écrit
>>>>>> :
>>>>>>
>>>>>> +1
>>>>>>>
>>>>>>> Sounds good to me too; I only really use the "Response Assertion".
>>>>>>> I think it's a good thing to remove rarely used features to save
>>>>>>> effort reading/testing/maintaining/fixing/supporting these.
>>>>>>>
>>>>>>> Thanks
>>>>>>>
>>>>>>> Graham
>>>>>>>
>>>>>>> On 25 February 2017 at 22:17, Philippe Mouawad
>>>>>>> <p....@ubik-ingenierie.com> wrote:
>>>>>>>
>>>>>>>> Hello,
>>>>>>>> I propose to drop HTML Assertion element as it does not support
>>>>>>>>
>>>>>>> HTML5
>>>>
>>>>> and
>>>>>>
>>>>>>> it seems not possible to support it easily :
>>>>>>>> - https://bz.apache.org/bugzilla/show_bug.cgi?id=60774
>>>>>>>>
>>>>>>>> Besides, I am not sure it is really a useful element.
>>>>>>>>
>>>>>>>> Regards
>>>>>>>> Philippe
>>>>>>>>
>>>>>>>
>>>
>>> --
>>> Cordialement.
>>> Philippe Mouawad.
>>>
>>>
>>>
>>>
>>
>
--
Cordialement.
Philippe Mouawad.
Re: Drop HTMLAssertion
Posted by Felix Schumacher <fe...@internetallee.de>.
Am 19.04.2017 um 22:32 schrieb Philippe Mouawad:
> Hello Felix,
> What shall we do with this ?
> Will you be committing your patch ?
Sorry for the late response.
I can commit the patch, I have even done some further implementation,
that enables the selection of xhtml, or normal html, BUT I think the
parser is too lax, to be of real value.
Can you try the current implementation, if it is good enough for your
use case? I have to admit, that I never really used this feature.
Felix
> Thanks
>
> On Sun, Feb 26, 2017 at 1:28 PM, Philippe Mouawad <
> philippe.mouawad@gmail.com> wrote:
>
>> Hello,
>> As Felix has found a way to do it with reasonable piece of work, I change
>> my opinion to keep it with following changes:
>> - Drop JTidy and use JSoup
>> - or keep JTidy but make JSoup the default
>>
>> Regards
>>
>> On Sun, Feb 26, 2017 at 1:16 PM, sebb <se...@gmail.com> wrote:
>>
>>> Please ask the User list whether or not it is being used.
>>>
>>> On 26 February 2017 at 12:02, Maxime Chassagneux
>>> <ma...@gmail.com> wrote:
>>>> +1 too
>>>>
>>>> 2017-02-26 10:58 GMT+01:00 Antonio Gomes Rodrigues <ra...@gmail.com>:
>>>>
>>>>> +1 to me
>>>>>
>>>>> Le 26 f�vr. 2017 10:17, "Graham Russell" <gr...@ham1.co.uk> a �crit :
>>>>>
>>>>>> +1
>>>>>>
>>>>>> Sounds good to me too; I only really use the "Response Assertion".
>>>>>> I think it's a good thing to remove rarely used features to save
>>>>>> effort reading/testing/maintaining/fixing/supporting these.
>>>>>>
>>>>>> Thanks
>>>>>>
>>>>>> Graham
>>>>>>
>>>>>> On 25 February 2017 at 22:17, Philippe Mouawad
>>>>>> <p....@ubik-ingenierie.com> wrote:
>>>>>>> Hello,
>>>>>>> I propose to drop HTML Assertion element as it does not support
>>> HTML5
>>>>> and
>>>>>>> it seems not possible to support it easily :
>>>>>>> - https://bz.apache.org/bugzilla/show_bug.cgi?id=60774
>>>>>>>
>>>>>>> Besides, I am not sure it is really a useful element.
>>>>>>>
>>>>>>> Regards
>>>>>>> Philippe
>>
>>
>> --
>> Cordialement.
>> Philippe Mouawad.
>>
>>
>>
>
Re: Drop HTMLAssertion
Posted by Philippe Mouawad <ph...@gmail.com>.
Hello Felix,
What shall we do with this ?
Will you be committing your patch ?
Thanks
On Sun, Feb 26, 2017 at 1:28 PM, Philippe Mouawad <
philippe.mouawad@gmail.com> wrote:
> Hello,
> As Felix has found a way to do it with reasonable piece of work, I change
> my opinion to keep it with following changes:
> - Drop JTidy and use JSoup
> - or keep JTidy but make JSoup the default
>
> Regards
>
> On Sun, Feb 26, 2017 at 1:16 PM, sebb <se...@gmail.com> wrote:
>
>> Please ask the User list whether or not it is being used.
>>
>> On 26 February 2017 at 12:02, Maxime Chassagneux
>> <ma...@gmail.com> wrote:
>> > +1 too
>> >
>> > 2017-02-26 10:58 GMT+01:00 Antonio Gomes Rodrigues <ra...@gmail.com>:
>> >
>> >> +1 to me
>> >>
>> >> Le 26 févr. 2017 10:17, "Graham Russell" <gr...@ham1.co.uk> a écrit :
>> >>
>> >> > +1
>> >> >
>> >> > Sounds good to me too; I only really use the "Response Assertion".
>> >> > I think it's a good thing to remove rarely used features to save
>> >> > effort reading/testing/maintaining/fixing/supporting these.
>> >> >
>> >> > Thanks
>> >> >
>> >> > Graham
>> >> >
>> >> > On 25 February 2017 at 22:17, Philippe Mouawad
>> >> > <p....@ubik-ingenierie.com> wrote:
>> >> > > Hello,
>> >> > > I propose to drop HTML Assertion element as it does not support
>> HTML5
>> >> and
>> >> > > it seems not possible to support it easily :
>> >> > > - https://bz.apache.org/bugzilla/show_bug.cgi?id=60774
>> >> > >
>> >> > > Besides, I am not sure it is really a useful element.
>> >> > >
>> >> > > Regards
>> >> > > Philippe
>> >> >
>> >>
>>
>
>
>
> --
> Cordialement.
> Philippe Mouawad.
>
>
>
--
Cordialement.
Philippe Mouawad.
Re: Drop HTMLAssertion
Posted by Philippe Mouawad <ph...@gmail.com>.
Hello,
As Felix has found a way to do it with reasonable piece of work, I change
my opinion to keep it with following changes:
- Drop JTidy and use JSoup
- or keep JTidy but make JSoup the default
Regards
On Sun, Feb 26, 2017 at 1:16 PM, sebb <se...@gmail.com> wrote:
> Please ask the User list whether or not it is being used.
>
> On 26 February 2017 at 12:02, Maxime Chassagneux
> <ma...@gmail.com> wrote:
> > +1 too
> >
> > 2017-02-26 10:58 GMT+01:00 Antonio Gomes Rodrigues <ra...@gmail.com>:
> >
> >> +1 to me
> >>
> >> Le 26 févr. 2017 10:17, "Graham Russell" <gr...@ham1.co.uk> a écrit :
> >>
> >> > +1
> >> >
> >> > Sounds good to me too; I only really use the "Response Assertion".
> >> > I think it's a good thing to remove rarely used features to save
> >> > effort reading/testing/maintaining/fixing/supporting these.
> >> >
> >> > Thanks
> >> >
> >> > Graham
> >> >
> >> > On 25 February 2017 at 22:17, Philippe Mouawad
> >> > <p....@ubik-ingenierie.com> wrote:
> >> > > Hello,
> >> > > I propose to drop HTML Assertion element as it does not support
> HTML5
> >> and
> >> > > it seems not possible to support it easily :
> >> > > - https://bz.apache.org/bugzilla/show_bug.cgi?id=60774
> >> > >
> >> > > Besides, I am not sure it is really a useful element.
> >> > >
> >> > > Regards
> >> > > Philippe
> >> >
> >>
>
--
Cordialement.
Philippe Mouawad.
Re: Drop HTMLAssertion
Posted by sebb <se...@gmail.com>.
Please ask the User list whether or not it is being used.
On 26 February 2017 at 12:02, Maxime Chassagneux
<ma...@gmail.com> wrote:
> +1 too
>
> 2017-02-26 10:58 GMT+01:00 Antonio Gomes Rodrigues <ra...@gmail.com>:
>
>> +1 to me
>>
>> Le 26 févr. 2017 10:17, "Graham Russell" <gr...@ham1.co.uk> a écrit :
>>
>> > +1
>> >
>> > Sounds good to me too; I only really use the "Response Assertion".
>> > I think it's a good thing to remove rarely used features to save
>> > effort reading/testing/maintaining/fixing/supporting these.
>> >
>> > Thanks
>> >
>> > Graham
>> >
>> > On 25 February 2017 at 22:17, Philippe Mouawad
>> > <p....@ubik-ingenierie.com> wrote:
>> > > Hello,
>> > > I propose to drop HTML Assertion element as it does not support HTML5
>> and
>> > > it seems not possible to support it easily :
>> > > - https://bz.apache.org/bugzilla/show_bug.cgi?id=60774
>> > >
>> > > Besides, I am not sure it is really a useful element.
>> > >
>> > > Regards
>> > > Philippe
>> >
>>
Re: Drop HTMLAssertion
Posted by Maxime Chassagneux <ma...@gmail.com>.
+1 too
2017-02-26 10:58 GMT+01:00 Antonio Gomes Rodrigues <ra...@gmail.com>:
> +1 to me
>
> Le 26 févr. 2017 10:17, "Graham Russell" <gr...@ham1.co.uk> a écrit :
>
> > +1
> >
> > Sounds good to me too; I only really use the "Response Assertion".
> > I think it's a good thing to remove rarely used features to save
> > effort reading/testing/maintaining/fixing/supporting these.
> >
> > Thanks
> >
> > Graham
> >
> > On 25 February 2017 at 22:17, Philippe Mouawad
> > <p....@ubik-ingenierie.com> wrote:
> > > Hello,
> > > I propose to drop HTML Assertion element as it does not support HTML5
> and
> > > it seems not possible to support it easily :
> > > - https://bz.apache.org/bugzilla/show_bug.cgi?id=60774
> > >
> > > Besides, I am not sure it is really a useful element.
> > >
> > > Regards
> > > Philippe
> >
>
Re: Drop HTMLAssertion
Posted by Antonio Gomes Rodrigues <ra...@gmail.com>.
+1 to me
Le 26 févr. 2017 10:17, "Graham Russell" <gr...@ham1.co.uk> a écrit :
> +1
>
> Sounds good to me too; I only really use the "Response Assertion".
> I think it's a good thing to remove rarely used features to save
> effort reading/testing/maintaining/fixing/supporting these.
>
> Thanks
>
> Graham
>
> On 25 February 2017 at 22:17, Philippe Mouawad
> <p....@ubik-ingenierie.com> wrote:
> > Hello,
> > I propose to drop HTML Assertion element as it does not support HTML5 and
> > it seems not possible to support it easily :
> > - https://bz.apache.org/bugzilla/show_bug.cgi?id=60774
> >
> > Besides, I am not sure it is really a useful element.
> >
> > Regards
> > Philippe
>
Re: Drop HTMLAssertion
Posted by Graham Russell <gr...@ham1.co.uk>.
+1
Sounds good to me too; I only really use the "Response Assertion".
I think it's a good thing to remove rarely used features to save
effort reading/testing/maintaining/fixing/supporting these.
Thanks
Graham
On 25 February 2017 at 22:17, Philippe Mouawad
<p....@ubik-ingenierie.com> wrote:
> Hello,
> I propose to drop HTML Assertion element as it does not support HTML5 and
> it seems not possible to support it easily :
> - https://bz.apache.org/bugzilla/show_bug.cgi?id=60774
>
> Besides, I am not sure it is really a useful element.
>
> Regards
> Philippe
Re: Drop HTMLAssertion
Posted by Felix Schumacher <fe...@internetallee.de>.
Am 25.02.2017 um 23:17 schrieb Philippe Mouawad:
> Hello,
> I propose to drop HTML Assertion element as it does not support HTML5 and
> it seems not possible to support it easily :
> - https://bz.apache.org/bugzilla/show_bug.cgi?id=60774
I will attach a patch to that entry, as we could use jsoup to parse the
html element, which should support html5.
However it will not have that many configurable elements, as it only
reports errors and doesn't differentiate between warnings and errors.
>
> Besides, I am not sure it is really a useful element.
I haven't used it, but we would have to ask on the user list, if it is
widely used.
All in all, I am +-0.
Felix
>
> Regards
> Philippe
>
Re: Drop HTMLAssertion
Posted by Andrey Pokhilko <ap...@ya.ru>.
Hi,
+1 for me.
Also, I'm ready to accept it into plugins repo to keep it for community
for compatibility of old plans.
Andrey Pokhilko
On 02/26/2017 12:17 AM, Philippe Mouawad wrote:
> Hello,
> I propose to drop HTML Assertion element as it does not support HTML5 and
> it seems not possible to support it easily :
> - https://bz.apache.org/bugzilla/show_bug.cgi?id=60774
>
> Besides, I am not sure it is really a useful element.
>
> Regards
> Philippe
>