You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-issues@hadoop.apache.org by "Eli Collins (JIRA)" <ji...@apache.org> on 2012/10/11 00:55:02 UTC
[jira] [Updated] (HDFS-4029) GenerationStamp should use an
AtomicLong
[ https://issues.apache.org/jira/browse/HDFS-4029?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eli Collins updated HDFS-4029:
------------------------------
Attachment: hdfs-4029.txt
Patch attached. Verified this fixes the findbugs warning generated when upgrading to findbugs 2.5.2.
> GenerationStamp should use an AtomicLong
> -----------------------------------------
>
> Key: HDFS-4029
> URL: https://issues.apache.org/jira/browse/HDFS-4029
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: name-node
> Affects Versions: 2.0.0-alpha
> Reporter: Eli Collins
> Assignee: Eli Collins
> Attachments: hdfs-4029.txt
>
>
> GenerationStamp#genstamp is a volatile long. Incrementing volatiles is not thread safe, which is currently not an issue because the only increment is done in nextStamp which is synchronized (theoretically setStamp could race with nextStamp though that wouldn't happen given the current code). It would be cleaner to use an AtomicLong so that genstamp itself is atomic and we don't have to synchronize the various accesses to it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira