You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/01/11 21:24:33 UTC

[GitHub] [airflow] mustafagok commented on issue #7136: [AIRFLOW-6536] Make job_id parameter optional

mustafagok commented on issue #7136: [AIRFLOW-6536] Make job_id parameter optional
URL: https://github.com/apache/airflow/pull/7136#issuecomment-573355737
 
 
   Actually there are some tests in the test_databricks_operator.py file:
   line 278:
   `test_init_with_json()` method (already updated in this PR) the job_id is not passed directly, and it is in the json dict in this test.
   Does it like the "one with the default param from json" or what kind of test should I implement other than this?
   line 267:
   `test_init_with_named_parameters()` job_id is not in the json, it passed directly. Also, in the all of the other tests except `test_init_with_json()`, job_id parameter passed because it was a required paremeter until now. So, does it like "the other with the param passed directly" or what kind of test should I implement other than this?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services